summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRami Rosen <ramirose@gmail.com>2010-06-03 05:02:29 +0000
committerDavid S. Miller <davem@davemloft.net>2010-06-05 02:23:15 -0700
commit55c95e738da85373965cb03b4f975d0fd559865b (patch)
treedc3fe475c410606c2ce9cb43fcd204fcec805975
parent5918e2fb9035b35164002c3a268feaf70b7c04d5 (diff)
fix return value of __pppoe_xmit() method.
Hi, __pppoe_xmit() in drivers/net/pppoe always returns 1. When the methods fails (via goto abort), it should return 0 and not 1. Regards, Rami Rosen Signed-off-by: Rami Rosen <ramirose@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/pppoe.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c
index 805b64d1e893..7ebb8e87efa4 100644
--- a/drivers/net/pppoe.c
+++ b/drivers/net/pppoe.c
@@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb)
abort:
kfree_skb(skb);
- return 1;
+ return 0;
}
/************************************************************************