diff options
| author | David Howells <dhowells@redhat.com> | 2016-10-13 08:39:52 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2016-10-13 08:39:52 +0100 |
| commit | 54fde4234579d3b1311b3ed1a1e95526a7cfdcd7 (patch) | |
| tree | 0694aa1b68d45dc1b06fb4ae2dc40027dc6b693d | |
| parent | 233c9edcca0136f2b9b304fd4f32e9bb6ce88ea9 (diff) | |
rxrpc: Fix checker warning by not passing always-zero value to ERR_PTR()
Fix the following checker warning:
net/rxrpc/call_object.c:279 rxrpc_new_client_call()
warn: passing zero to 'ERR_PTR'
where a value that's always zero is passed to ERR_PTR() so that it can be
passed to a tracepoint in an auxiliary pointer field.
Just pass NULL instead to the tracepoint.
Fixes: a84a46d73050 ("rxrpc: Add some additional call tracing")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
| -rw-r--r-- | net/rxrpc/call_object.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/call_object.c b/net/rxrpc/call_object.c index 4353a29f3b57..1ed18d8c9c9f 100644 --- a/net/rxrpc/call_object.c +++ b/net/rxrpc/call_object.c @@ -276,7 +276,7 @@ struct rxrpc_call *rxrpc_new_client_call(struct rxrpc_sock *rx, goto error; trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage), - here, ERR_PTR(ret)); + here, NULL); spin_lock_bh(&call->conn->params.peer->lock); hlist_add_head(&call->error_link, |