diff options
author | Larry Finger <Larry.Finger@lwfinger.net> | 2011-09-01 12:23:19 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-09-06 16:35:59 -0700 |
commit | 52a7fb0951b35840a79a5b162fb853b78cec3c09 (patch) | |
tree | 1c529e67b070c54238b3030ecc890d6126a87903 | |
parent | ce7b393f50e93da441a4a532ff6ca393fb6bd64a (diff) |
staging: rtl8192e: Fix smatch error in r8192E_phy.c
Smatch reports the following:
CHECK drivers/staging/rtl8192e/r8192E_phy.c
drivers/staging/rtl8192e/r8192E_phy.c +940 rtl8192_phy_SwChnlStepByStep(92) error: potential null derefence 'CurrentCmd'.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/staging/rtl8192e/r8192E_phy.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/staging/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/r8192E_phy.c index 83e00d72199a..7ec6139cb4fb 100644 --- a/drivers/staging/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/r8192E_phy.c @@ -937,7 +937,7 @@ static u8 rtl8192_phy_SwChnlStepByStep(struct net_device *dev, u8 channel, break; } - if (CurrentCmd->CmdID == CmdID_End) { + if (CurrentCmd && CurrentCmd->CmdID == CmdID_End) { if ((*stage) == 2) { return true; } else { @@ -947,6 +947,8 @@ static u8 rtl8192_phy_SwChnlStepByStep(struct net_device *dev, u8 channel, } } + if (!CurrentCmd) + continue; switch (CurrentCmd->CmdID) { case CmdID_SetTxPowerLevel: if (priv->IC_Cut > (u8)VERSION_8190_BD) |