summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeng Li <lipeng321@huawei.com>2018-08-27 09:59:30 +0800
committerDavid S. Miller <davem@davemloft.net>2018-08-29 18:08:20 -0700
commit455c4401fe7a538facaffb35b906ce19f1ece474 (patch)
tree1d0e8330fda26f8dfe73346cec46f01f159bdbe9
parent31fabbee8f5c658c3fa1603c66e9e4f51ea8c2c6 (diff)
net: hns: add netif_carrier_off before change speed and duplex
If there are packets in hardware when changing the speed or duplex, it may cause hardware hang up. This patch adds netif_carrier_off before change speed and duplex in ethtool_ops.set_link_ksettings, and adds netif_carrier_on after complete the change. Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/hisilicon/hns/hns_ethtool.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
index 08f3c4743f74..774beda040a1 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
@@ -243,7 +243,9 @@ static int hns_nic_set_link_ksettings(struct net_device *net_dev,
}
if (h->dev->ops->adjust_link) {
+ netif_carrier_off(net_dev);
h->dev->ops->adjust_link(h, (int)speed, cmd->base.duplex);
+ netif_carrier_on(net_dev);
return 0;
}