summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcel Holtmann <marcel@holtmann.org>2014-02-23 20:25:55 -0800
committerJohan Hedberg <johan.hedberg@intel.com>2014-02-24 08:48:02 +0200
commit41c90c186a3b51207cb1f2583fbadec3c76e4730 (patch)
treee992a3dfd81778e9219acc06b1276aa402899561
parent94b1fc92cd7cf550460ffd4bcc08c2707564aa49 (diff)
Bluetooth: Use privacy mode for non-connectable advertising
When enabling non-connectable advertising, there is no need to advertise with a public address or static address. In case LE privacy has not been enabled a unresolvable private address will be used. Signed-off-by: Marcel Holtmann <marcel@holtmann.org> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
-rw-r--r--net/bluetooth/mgmt.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 5d309d4ab527..53b9408af16b 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -841,12 +841,14 @@ static void enable_advertising(struct hci_request *req)
struct hci_dev *hdev = req->hdev;
struct hci_cp_le_set_adv_param cp;
u8 own_addr_type, enable = 0x01;
+ bool require_privacy;
- memset(&cp, 0, sizeof(cp));
+ require_privacy = !test_bit(HCI_CONNECTABLE, &hdev->dev_flags);
- if (hci_update_random_address(req, false, &own_addr_type) < 0)
+ if (hci_update_random_address(req, require_privacy, &own_addr_type) < 0)
return;
+ memset(&cp, 0, sizeof(cp));
cp.min_interval = __constant_cpu_to_le16(0x0800);
cp.max_interval = __constant_cpu_to_le16(0x0800);
cp.type = get_adv_type(hdev);