diff options
| author | David Howells <dhowells@redhat.com> | 2020-06-12 23:58:51 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-06-15 15:41:02 +0100 |
| commit | 1f32ef79897052ef7d3d154610d8d6af95abde83 (patch) | |
| tree | fe3ccf578175dc55a56649013676cb78150866b1 | |
| parent | bb413489288e4e457353bac513fddb6330d245ca (diff) | |
afs: afs_write_end() should change i_size under the right lock
Fix afs_write_end() to change i_size under vnode->cb_lock rather than
->wb_lock so that it doesn't race with afs_vnode_commit_status() and
afs_getattr().
The ->wb_lock is only meant to guard access to ->wb_keys which isn't
accessed by that piece of code.
Fixes: 4343d00872e1 ("afs: Get rid of the afs_writeback record")
Signed-off-by: David Howells <dhowells@redhat.com>
| -rw-r--r-- | fs/afs/write.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/afs/write.c b/fs/afs/write.c index 9270bb01be67..a55cb73e0449 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c @@ -194,11 +194,11 @@ int afs_write_end(struct file *file, struct address_space *mapping, i_size = i_size_read(&vnode->vfs_inode); if (maybe_i_size > i_size) { - spin_lock(&vnode->wb_lock); + write_seqlock(&vnode->cb_lock); i_size = i_size_read(&vnode->vfs_inode); if (maybe_i_size > i_size) i_size_write(&vnode->vfs_inode, maybe_i_size); - spin_unlock(&vnode->wb_lock); + write_sequnlock(&vnode->cb_lock); } if (!PageUptodate(page)) { |