summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Zimmermann <tzimmermann@suse.de>2018-09-10 11:36:44 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-09-10 17:02:52 +0200
commit1485e2fb627b3507f1caca0a28cd75293d192b1f (patch)
tree0a1c8075c5e55c7d16a0e138ceb3a873d2ac985a
parent8627995cf711ed0e9ff84cf34b5b389fa01fa4c9 (diff)
staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put
The function ttm_bo_put releases a reference to a TTM buffer object. The function's name is more aligned to the Linux kernel convention of naming ref-counting function _get and _put. A call to ttm_bo_unref takes the address of the TTM BO object's pointer and clears the pointer's value to NULL. This is not necessary in most cases and sometimes even worked around by the calling code. A call to ttm_bo_put only releases the reference without clearing the pointer. The current behaviour of cleaning the pointer is kept in the calling code, but should be removed if not required in a later patch. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/vboxvideo/vbox_main.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
index 429f6a453619..b6cff31903b3 100644
--- a/drivers/staging/vboxvideo/vbox_main.c
+++ b/drivers/staging/vboxvideo/vbox_main.c
@@ -490,9 +490,8 @@ static void vbox_bo_unref(struct vbox_bo **bo)
return;
tbo = &((*bo)->bo);
- ttm_bo_unref(&tbo);
- if (!tbo)
- *bo = NULL;
+ ttm_bo_put(tbo);
+ *bo = NULL;
}
void vbox_gem_free_object(struct drm_gem_object *obj)