diff options
| author | Bernard Zhao <bernard@vivo.com> | 2020-08-14 01:30:19 -0700 |
|---|---|---|
| committer | Sam Ravnborg <sam@ravnborg.org> | 2020-10-17 10:10:24 +0200 |
| commit | 14212fe77ef6f9b0ec61f9ad946dea90a22496ec (patch) | |
| tree | b98f2542c741140a85ecc20d559ed5be897c338c | |
| parent | 77bb5aaf2bb8180e7d1bb70b4df306f511707a7d (diff) | |
drm/via: reduce no need mutex_lock area
In function via_mem_alloc`s error branch, DRM_ERROR is protected
in the mutex_lock(&dev->struct_mutex) area.
>From the code, we see that DRM_ERROR is just an error log print
without any struct element, there is no need to protect this.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200814083021.8962-1-bernard@vivo.com
| -rw-r--r-- | drivers/gpu/drm/via/via_mm.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/via/via_mm.c b/drivers/gpu/drm/via/via_mm.c index 45cc9e900260..dae1bacd86c1 100644 --- a/drivers/gpu/drm/via/via_mm.c +++ b/drivers/gpu/drm/via/via_mm.c @@ -129,9 +129,9 @@ int via_mem_alloc(struct drm_device *dev, void *data, mutex_lock(&dev->struct_mutex); if (0 == ((mem->type == VIA_MEM_VIDEO) ? dev_priv->vram_initialized : dev_priv->agp_initialized)) { + mutex_unlock(&dev->struct_mutex); DRM_ERROR ("Attempt to allocate from uninitialized memory manager.\n"); - mutex_unlock(&dev->struct_mutex); return -EINVAL; } |