From efa497c69b813852d3704dbd96207f1186eb941a Mon Sep 17 00:00:00 2001 From: Okke Formsma Date: Sun, 7 Mar 2021 14:50:30 +0100 Subject: fix(behaviors): Fix timing of delayed hold-tap trigger A hold-tap timer event would be triggered too soon if the hold-tap was delayed for longer than its tapping-term. This may cause accidental hold behavior when the correct behavior would be tap. By queuing the timer event instead of executing it immediately, other delayed events get a chance to be processed properly. --- .../tap-preferred/6-nested-timeouts/keycode_events.snapshot | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 app/tests/hold-tap/tap-preferred/6-nested-timeouts/keycode_events.snapshot (limited to 'app/tests/hold-tap/tap-preferred/6-nested-timeouts/keycode_events.snapshot') diff --git a/app/tests/hold-tap/tap-preferred/6-nested-timeouts/keycode_events.snapshot b/app/tests/hold-tap/tap-preferred/6-nested-timeouts/keycode_events.snapshot new file mode 100644 index 0000000..54ac986 --- /dev/null +++ b/app/tests/hold-tap/tap-preferred/6-nested-timeouts/keycode_events.snapshot @@ -0,0 +1,10 @@ +ht_binding_pressed: 0 new undecided hold_tap +ht_decide: 0 decided hold-timer (tap-preferred decision moment timer) +kp_pressed: usage_page 0x07 keycode 0xe1 implicit_mods 0x00 explicit_mods 0x00 +ht_binding_pressed: 1 new undecided hold_tap +ht_decide: 1 decided tap (tap-preferred decision moment key-up) +kp_pressed: usage_page 0x07 keycode 0x0d implicit_mods 0x00 explicit_mods 0x00 +kp_released: usage_page 0x07 keycode 0x0d implicit_mods 0x00 explicit_mods 0x00 +ht_binding_released: 1 cleaning up hold-tap +kp_released: usage_page 0x07 keycode 0xe1 implicit_mods 0x00 explicit_mods 0x00 +ht_binding_released: 0 cleaning up hold-tap -- cgit v1.2.3