style(hold-tap)!: Write hold-tap params with dashes

tapping_term_ms -> tapping-term-ms
quick_tap_ms -> quick-tap-ms

The old style works, although it's deprecated.

10 files changed, 17 insertions, 14 deletions

diff --git a/app/boards/shields/qaz/qaz.keymap b/app/boards/shields/qaz/qaz.keymap
index 8ac61f6..a832860 100644
--- a/app/boards/shields/qaz/qaz.keymap
+++ b/app/boards/shields/qaz/qaz.keymap
@@ -18,7 +18,7 @@
             compatible = "zmk,behavior-hold-tap";
             label = "homerow mods";
             #binding-cells = <2>;
-            tapping_term_ms = <225>;
+            tapping-term-ms = <225>;
             flavor = "tap-preferred";
             bindings = <&kp>, <&kp>;
         };
diff --git a/app/boards/shields/tg4x/tg4x.keymap b/app/boards/shields/tg4x/tg4x.keymap
index d5e2009..84ca327 100644
--- a/app/boards/shields/tg4x/tg4x.keymap
+++ b/app/boards/shields/tg4x/tg4x.keymap
@@ -14,7 +14,7 @@
 			compatible = "zmk,behavior-hold-tap";
 			label = "Hold Tap";
 			#binding-cells = <2>;
-			tapping_term_ms = <200>;
+			tapping-term-ms = <200>;
 			flavor = "tap-preferred";
 			bindings = <&kp>, <&kp>;
 		};
diff --git a/app/dts/behaviors/layer_tap.dtsi b/app/dts/behaviors/layer_tap.dtsi
index b4539b3..21fd9d5 100644
--- a/app/dts/behaviors/layer_tap.dtsi
+++ b/app/dts/behaviors/layer_tap.dtsi
@@ -11,7 +11,7 @@
 			label = "LAYER_TAP";
 			#binding-cells = <2>;
 			flavor = "tap-preferred";
-			tapping_term_ms = <200>;
+			tapping-term-ms = <200>;
 			bindings = <&mo>, <&kp>;
 		};
 	};
diff --git a/app/dts/behaviors/mod_tap.dtsi b/app/dts/behaviors/mod_tap.dtsi
index 79ce10c..7a98713 100644
--- a/app/dts/behaviors/mod_tap.dtsi
+++ b/app/dts/behaviors/mod_tap.dtsi
@@ -11,7 +11,7 @@
 			label = "MOD_TAP";
 			#binding-cells = <2>;
 			flavor = "hold-preferred";
-			tapping_term_ms = <200>;
+			tapping-term-ms = <200>;
 			bindings = <&kp>, <&kp>;
 		};
 	};
diff --git a/app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml b/app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml
index 56f0cc2..50fa5d5 100644
--- a/app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml
+++ b/app/dts/bindings/behaviors/zmk,behavior-hold-tap.yaml
@@ -11,11 +11,15 @@ properties:
   bindings:
     type: phandles
     required: true
-  tapping_term_ms:
+  tapping-term-ms:
     type: int
-  quick_tap_ms:
+  tapping_term_ms: # deprecated
+    type: int
+  quick-tap-ms:
     type: int
     default: -1
+  quick_tap_ms: # deprecated
+    type: int
   flavor:
     type: string
     required: false
diff --git a/app/src/behaviors/behavior_hold_tap.c b/app/src/behaviors/behavior_hold_tap.c
index a7185fb..ab25c3c 100644
--- a/app/src/behaviors/behavior_hold_tap.c
+++ b/app/src/behaviors/behavior_hold_tap.c
@@ -47,7 +47,6 @@ struct behavior_hold_tap_config {
 // this data is specific for each hold-tap
 struct active_hold_tap {
     int32_t position;
-    // todo: move these params into the config->behaviors->tap and
     uint32_t param_hold;
     uint32_t param_tap;
     int64_t timestamp;
diff --git a/app/tests/hold-tap/balanced/behavior_keymap.dtsi b/app/tests/hold-tap/balanced/behavior_keymap.dtsi
index 972b606..d62be88 100644
--- a/app/tests/hold-tap/balanced/behavior_keymap.dtsi
+++ b/app/tests/hold-tap/balanced/behavior_keymap.dtsi
@@ -9,8 +9,8 @@
 			label = "HOLD_TAP_BALANCED";
 			#binding-cells = <2>;
 			flavor = "balanced";
-			tapping_term_ms = <300>;
-			quick_tap_ms = <200>;
+			tapping-term-ms = <300>;
+			quick-tap-ms = <200>;
 			bindings = <&kp>, <&kp>;
 		};
 	};
diff --git a/app/tests/hold-tap/balanced/many-nested/native_posix.keymap b/app/tests/hold-tap/balanced/many-nested/native_posix.keymap
index 7941e4d..2698f05 100644
--- a/app/tests/hold-tap/balanced/many-nested/native_posix.keymap
+++ b/app/tests/hold-tap/balanced/many-nested/native_posix.keymap
@@ -9,7 +9,7 @@
 			label = "HOLD_TAP_BALANCED";
 			#binding-cells = <2>;
 			flavor = "balanced";
-			tapping_term_ms = <300>;
+			tapping-term-ms = <300>;
 			bindings = <&kp>, <&kp>;
 		};
 	};
diff --git a/app/tests/hold-tap/hold-preferred/behavior_keymap.dtsi b/app/tests/hold-tap/hold-preferred/behavior_keymap.dtsi
index 2b35f89..41c84e1 100644
--- a/app/tests/hold-tap/hold-preferred/behavior_keymap.dtsi
+++ b/app/tests/hold-tap/hold-preferred/behavior_keymap.dtsi
@@ -11,8 +11,8 @@
 			label = "hold_hold_tap";
 			#binding-cells = <2>;
 			flavor = "hold-preferred";
-			tapping_term_ms = <300>;
-			quick_tap_ms = <200>;
+			tapping-term-ms = <300>;
+			quick-tap-ms = <200>;
 			bindings = <&kp>, <&kp>;
 		};
 	};
diff --git a/app/tests/hold-tap/tap-preferred/behavior_keymap.dtsi b/app/tests/hold-tap/tap-preferred/behavior_keymap.dtsi
index 80d6b0a..cdeb959 100644
--- a/app/tests/hold-tap/tap-preferred/behavior_keymap.dtsi
+++ b/app/tests/hold-tap/tap-preferred/behavior_keymap.dtsi
@@ -9,8 +9,8 @@
 			label = "MOD_TAP";
 			#binding-cells = <2>;
 			flavor = "tap-preferred";
-			tapping_term_ms = <300>;
-			quick_tap_ms = <200>;
+			tapping-term-ms = <300>;
+			quick-tap-ms = <200>;
 			bindings = <&kp>, <&kp>;
 		};
 	};