From a99a12737593c8fe9afad09bea908198e3e02ecf Mon Sep 17 00:00:00 2001 From: Noah Silvera Date: Wed, 12 May 2021 10:24:29 -0700 Subject: Lock ExecJS version ExecJS released a minor version update with a breaking change. We want to lock to the previous version (2.7) for now until a fix is released. Co-authored-by: Nick Van Doorn Co-authored-by: Adam Mueller --- Gemfile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Gemfile b/Gemfile index 8e43ed3..a11d93f 100644 --- a/Gemfile +++ b/Gemfile @@ -13,6 +13,10 @@ gem "rails", ENV.fetch("RAILS_VERSION") { ">0.a" } # Provides basic authentication functionality for testing parts of your engine gem "solidus_auth_devise" +# ExecJS 2.8 has a bug in it which breaks js precompiling, which is required for our features +# specs. Many other solidus extensions are also experiencing failing specs because of this. +# For now, we should lock the version of ExecJS until a new release comes out that fixes this bug. +gem "execjs", '~> 2.7.0' case ENV["DB"] when "mysql" -- cgit v1.2.3