| Age | Commit message (Collapse) | Author |
|---|
|
We want to switch from travis CI to circle CI as we have run out of
credits on travis, and circle CI has a robust orb for running tests
for solidus extensions.
|
|
Add TaxJar `nexus_regions` API call
|
|
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
We want to start syncing nexus data from TaxJar to this extension. As
such we start by implementing an API call to fetch nexus regions from
TaxJar.
Future commits should offer path for users to persist this data in their
Solidus store.
Co-authored-by: Noah Silvera <noah@super.gd>
Co-authored-by: Adnan Abdulally <adnan.abdulally@printivity.com>
|
|
nvandoorn/update-pull-request-template-to-include-sandbox-test
Update PR template to include sandbox testing step
|
|
|
|
|
|
Fix critical bug in API class
|
|
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
A recent release contained a critical regression, so we're adding an
extra pre merge step to prevent this from happening.
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
In #34, we modified `.default_taxjar_client` to include the API version,
and then the name of the plugin, but we also introduced a critical bug.
`Taxjar::Client#set_api_config` returns a hash and not the TaxJar
client, so it is not safe to chain the method call. As such, we add a
spec to cover this case and patch the class method.
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
This was not used and should be removed.
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
Fix typo in address parameter helper
|
|
This links to the PR where we fixed the issue from the changelog file,
so we can know what is in the next release of the gem.
|
|
This change fixes a typo in the params helper for addresses without a
`state` association. This was a previously untested behaviour so we never
caught this. This change also marks the failing test as no longer
pending.
|
|
This change adds a failing spec which exposes a typo in our API params
helper method. In the next change we'll fix the issue and un-pend the
spec.
|
|
Support zeitwerk loading (0.18.0)
|
|
Add information around the breaking changes added and upgrade
instructions for 0.17.X to 0.18.X
Co-authored-by: Nick Van Doorn <nick@super.gd>
|
|
Improve the installation instructions and remove outdated messaging
|
|
Previous changes allow this gem to support zeitwerk loading, and by
extension, rails 6. We should add a test case for this in the CI.
Co-authored-by: Nick Van Doorn <nick@super.gd>
|
|
This done so Zeitwerk can correctly can correctly load the class
from the filename.
Co-authored-by: Nick Van Doorn <nick@super.gd>
|
|
In order for the Zeitwerk loader to properly identity our classes
from the file names, we should remove camel casing from this name
that isn't consistent with underscores in the file name itself.
Co-authored-by: Nick Van Doorn <nick@super.gd>
|
|
Update the engine name
|
|
Once we add an install generator with migrations, having an engine name
with a dash in it will cause the migration generation to fail, as
migrations will be created with the engine name in it, and dashes are
not allowed.
Co-authored-by: Nick Van Doorn <nick@super.gd>
|
|
Put plugin name in API request headers
|
|
Add pull request template
|
|
Add taxjar rails engine
|
|
To meet Taxjar's certification requirements, we need to supply a 'plugin'
name in each API request header. As such we add this header where the
API version header is supplied.
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
This template just asks contributors to state the goal of the PR, and
provide a testing and merging checklist.
|
|
Add a note about the addition of the rails engine.
|
|
Upcoming work to get this extension officially certified with Taxjar
will require the addition of UI components into the solidus backend.
Creating a rails engine for the new rails components of this extension
is a prerequisite to any UI work.
Co-authored-by: Nick Van Doorn <nick@super.gd>
Co-authored-by: Adam Mueller <adam@super.gd>
|
|
Add information to README about versions in setup
|
|
When setting up this project and running specs, it's important to make
sure all versions are compatible. As such we make a note in the README
and provide the versions from the CI
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
|
|
TaxJar requires certified extensions to include an API version in the
header of each request. This extensions wraps the official TaxJar Ruby
Gem with another API client, so we make sure the version gets set in
when our wrapper class is constructed.
Co-authored-by: Noah Silvera <noah@super.gd>
|
|
Update extension name
|
|
Without this update, the following would fail:
$ bundle exec rake sandbox
|
|
Fix handling of no results for address validation
|
|
According to the documentation, and some testing, the API will raise a
Taxjar::Error::NotFound error if the API finds no addresses. Instead of
raising this error to others, we should handle it ourselves and return
nil/an empty array like we originally intended.
https://developers.taxjar.com/api/reference/#post-validate-an-address
|
|
|
|
Support for TaxJar Address Validation API
|
|
|
|
|
|
This is used by any class that interacts with the TaxJar API and is
meant to be able to be consumed by applications for custom needs, so
let's just make it exposed at the top level.
|
|
This adds support to the API module for performing address validation
lookups. It doesn't hook anything up to that, but you can now call:
SuperGood::SolidusTaxjar.new.validate_spree_address(address)
to hit the TaxJar address validation API and a list of validated
addresses back.
|
|
I'm going to add support for address validation. This is the first step,
ensuring that we can take a Spree::Address and transform it into the
params that TaxJar expects for the address validation endpoint.
|
|
|
|
solidus_dev_support-support
|
|
|
|
|
