summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-03Update changelog to reflect PR contentadd-basic-taxjar-settings-uiNoah Silvera
Add a note in the changelog describing how this PR adds a admin interface for basic taxjar settings.
2021-05-03Provide helpful links for setting up TaxjarNoah Silvera
To comply with the certification guidelines for Taxjar, we should provide links to signup for Taxjar, and a link to a help article on aquiring a Taxjar token.
2021-05-03Add basic UI for Taxjar settings in solidus adminNoah Silvera
This commit adds a tab to the taxes section of the solidus admin settings. This provides the foundation for further configuration of taxjar through the solidus admin. The settings should be hidden if an API key has not been provided. This is to conform to the certification guidelines for an official Taxjar extension. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-05-03Don't set global environment variables in testsNoah Silvera
If you set the `ENV` variable in a test, this carries over to other tests. This was affecting different tests which relied on the environment. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-05-03Use `solidus_dev_support` feature helperNicholas Van Doorn
We are going to be writing feature specs for new admin user interface components. Note that we can remove the line that requires `rails_helper` as `feature_helper` also includes this. Co-authored-by: Noah Silvera <noah@super.gd>
2021-04-16Merge pull request #59 from Noah-Silvera/add-debugging-toolsNoah Silvera
Add pry debugging tools
2021-04-15Update changelogNoah Silvera
2021-04-15Add pry debugging toolsNoah Silvera
Pry stack explorer and byebug are useful tools to have for debugging this extension.
2021-04-15Merge pull request #58 from ↵Nicholas Van Doorn
Noah-Silvera/56-take-adjustments-into-account-when-calculating-shipping Take adjustments into account when calculating shipping
2021-04-13Update changelogNoah Silvera
2021-04-13Consider promotions in default shipping calculatorNoah Silvera
Previously, the shipment_total method on order was used, which does not take into account shipment promotions. Instead, we should manually sum the shipment cost taking into account any adjustments. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-04-12Add a simple spec for the shipping calculatorNoah Silvera
We are going to be changing the shipping calculator, so we should add a simple spec to test the existing behavior. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-03-31Merge pull request #55 from SuperGoodSoft/circleci-project-setupNoah Silvera
Add .circleci/config.yml
2021-03-31Add .circleci/config.ymlcircleci-project-setupNoah Silvera
We want to switch from travis CI to circle CI as we have run out of credits on travis, and circle CI has a robust orb for running tests for solidus extensions.
2021-03-26Merge pull request #51 from nvandoorn/add-taxjar-nexus-api-callNoah Silvera
Add TaxJar `nexus_regions` API call
2021-03-25Update CHANGELOG.mdNicholas Van Doorn
Co-authored-by: Noah Silvera <noah@super.gd>
2021-03-25Add nexus regions method to APINicholas Van Doorn
We want to start syncing nexus data from TaxJar to this extension. As such we start by implementing an API call to fetch nexus regions from TaxJar. Future commits should offer path for users to persist this data in their Solidus store. Co-authored-by: Noah Silvera <noah@super.gd> Co-authored-by: Adnan Abdulally <adnan.abdulally@printivity.com>
2021-03-25Merge pull request #53 from ↵Noah Silvera
nvandoorn/update-pull-request-template-to-include-sandbox-test Update PR template to include sandbox testing step
2021-03-25Update changelog for v0.18.10.18.1Jared Norman
2021-03-25Bump super_good-solidus_taxjar to 0.18.1Jared Norman
2021-03-24Merge pull request #52 from nvandoorn/fix-bug-in-api-classNicholas Van Doorn
Fix critical bug in API class
2021-03-24Update CHANGELOG.mdNicholas Van Doorn
Co-authored-by: Noah Silvera <noah@super.gd>
2021-03-24Update PR template to include sandbox testing stepNicholas Van Doorn
A recent release contained a critical regression, so we're adding an extra pre merge step to prevent this from happening. Co-authored-by: Noah Silvera <noah@super.gd>
2021-03-24Fix `.default_taxjar_client`Nicholas Van Doorn
In #34, we modified `.default_taxjar_client` to include the API version, and then the name of the plugin, but we also introduced a critical bug. `Taxjar::Client#set_api_config` returns a hash and not the TaxJar client, so it is not safe to chain the method call. As such, we add a spec to cover this case and patch the class method. Co-authored-by: Noah Silvera <noah@super.gd>
2021-03-24Remove unused spec variableNicholas Van Doorn
This was not used and should be removed. Co-authored-by: Noah Silvera <noah@super.gd>
2021-03-22Merge pull request #47 from SuperGoodSoft/forkata/fix-typoChris Todorov
Fix typo in address parameter helper
2021-03-19Add changelog entry for bug fixChris Todorov
This links to the PR where we fixed the issue from the changelog file, so we can know what is in the next release of the gem.
2021-03-18Fix typo in `validate_address_params` helperChris Todorov
This change fixes a typo in the params helper for addresses without a `state` association. This was a previously untested behaviour so we never caught this. This change also marks the failing test as no longer pending.
2021-03-18Add pending failing spec for address paramsChris Todorov
This change adds a failing spec which exposes a typo in our API params helper method. In the next change we'll fix the issue and un-pend the spec.
2021-03-17Merge pull request #43 from Noah-Silvera/support-zeitwerk-loading0.18.0Noah Silvera
Support zeitwerk loading (0.18.0)
2021-03-17Update CHANGELOG.mdAdnan Abdulally
Add information around the breaking changes added and upgrade instructions for 0.17.X to 0.18.X Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-03-17Update README.mdAdnan Abdulally
Improve the installation instructions and remove outdated messaging
2021-03-17Test against rails 6Noah Silvera
Previous changes allow this gem to support zeitwerk loading, and by extension, rails 6. We should add a test case for this in the CI. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-03-17Rename classes that have API in their name to ApiAdnan Abdulally
This done so Zeitwerk can correctly can correctly load the class from the filename. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-03-17Rename module SolidusTaxJar to SolidusTaxjarAdnan Abdulally
In order for the Zeitwerk loader to properly identity our classes from the file names, we should remove camel casing from this name that isn't consistent with underscores in the file name itself. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-03-11Merge pull request #45 from Noah-Silvera/update-engine-nameNoah Silvera
Update the engine name
2021-03-10Update the engine nameNoah Silvera
Once we add an install generator with migrations, having an engine name with a dash in it will cause the migration generation to fail, as migrations will be created with the engine name in it, and dashes are not allowed. Co-authored-by: Nick Van Doorn <nick@super.gd>
2021-02-25Merge pull request #41 from nvandoorn/put-plugin-name-in-headersNoah Silvera
Put plugin name in API request headers
2021-02-24Merge pull request #40 from Noah-Silvera/add-pull-request-templateJared Norman
Add pull request template
2021-02-24Merge pull request #39 from Noah-Silvera/add-taxjar-rails-engineNicholas Van Doorn
Add taxjar rails engine
2021-02-24Put plugin name in API request headersNicholas Van Doorn
To meet Taxjar's certification requirements, we need to supply a 'plugin' name in each API request header. As such we add this header where the API version header is supplied. Co-authored-by: Noah Silvera <noah@super.gd>
2021-02-24Add a basic pull request templateNoah Silvera
This template just asks contributors to state the goal of the PR, and provide a testing and merging checklist.
2021-02-22Update the changelogNoah Silvera
Add a note about the addition of the rails engine.
2021-02-22Add Taxjar Rails engineNoah Silvera
Upcoming work to get this extension officially certified with Taxjar will require the addition of UI components into the solidus backend. Creating a rails engine for the new rails components of this extension is a prerequisite to any UI work. Co-authored-by: Nick Van Doorn <nick@super.gd> Co-authored-by: Adam Mueller <adam@super.gd>
2021-02-10Merge pull request #38 from nvandoorn/add-version-information-to-readmeJared Norman
Add information to README about versions in setup
2021-02-10Add information to README about versions in setupNicholas Van Doorn
When setting up this project and running specs, it's important to make sure all versions are compatible. As such we make a note in the README and provide the versions from the CI Co-authored-by: Noah Silvera <noah@super.gd>
2021-02-08Merge pull request #34 from nvandoorn/33-put-api-version-in-request-headersJared Norman
2021-02-08Include API version in request headersNicholas Van Doorn
TaxJar requires certified extensions to include an API version in the header of each request. This extensions wraps the official TaxJar Ruby Gem with another API client, so we make sure the version gets set in when our wrapper class is constructed. Co-authored-by: Noah Silvera <noah@super.gd>
2020-10-11Merge pull request #27 from cmhnk/fix/extension_nameJared Norman
Update extension name
2020-10-09Update extension namecmhnk
Without this update, the following would fail: $ bundle exec rake sandbox
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-14 22:41:58 +0000