summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJared Norman <jared@super.gd>2019-05-28 15:52:40 -0700
committerJared Norman <jared@super.gd>2019-05-28 15:52:40 -0700
commita7befa9c98f4863edc617ef791c7518e5b1fe168 (patch)
treecbf6cc9d3f4a542034948f6dee1eccd844a2af8c
parentc3e66f3b548ef7e829b97ccebf5e45ce9d25f04d (diff)
Add configuration option for order tax check
This will allow apps to use properties of an order to determine whether an order is taxable.
-rw-r--r--lib/super_good/solidus_taxjar.rb2
-rw-r--r--spec/super_good/solidus_taxjar_spec.rb8
2 files changed, 10 insertions, 0 deletions
diff --git a/lib/super_good/solidus_taxjar.rb b/lib/super_good/solidus_taxjar.rb
index 6d6c47c..af2c7e8 100644
--- a/lib/super_good/solidus_taxjar.rb
+++ b/lib/super_good/solidus_taxjar.rb
@@ -19,6 +19,7 @@ module SuperGood
attr_accessor :shipping_calculator
attr_accessor :shipping_tax_label_maker
attr_accessor :taxable_address_check
+ attr_accessor :taxable_order_check
attr_accessor :test_mode
end
@@ -32,6 +33,7 @@ module SuperGood
self.shipping_calculator = ->(order) { order.shipment_total }
self.shipping_tax_label_maker = ->(shipment, shipping_tax) { "Sales Tax" }
self.taxable_address_check = ->(address) { true }
+ self.taxable_order_check = ->(order) { true }
self.test_mode = false
end
end
diff --git a/spec/super_good/solidus_taxjar_spec.rb b/spec/super_good/solidus_taxjar_spec.rb
index dafc4fb..efc38b0 100644
--- a/spec/super_good/solidus_taxjar_spec.rb
+++ b/spec/super_good/solidus_taxjar_spec.rb
@@ -37,6 +37,14 @@ RSpec.describe SuperGood::SolidusTaxJar do
it { is_expected.to eq true }
end
+ describe ".taxable_order_check" do
+ subject { described_class.taxable_order_check.(order) }
+
+ let(:order) { Spree::Order.new }
+
+ it { is_expected.to eq true }
+ end
+
describe ".shipping_tax_label_maker" do
subject { described_class.shipping_tax_label_maker.(shipment, shipping_tax) }
let(:shipment) { Spree::Shipment.new }