diff options
| author | Chris Todorov <chris@super.gd> | 2021-03-15 14:59:10 -0700 |
|---|---|---|
| committer | Chris Todorov <chris@super.gd> | 2021-03-18 00:49:57 -0700 |
| commit | f994ce1c323397c74c81fb53aa7c56fdd1cbe2e0 (patch) | |
| tree | 4f8f4877b0ae87618813c77d44f16f164ca7a55d | |
| parent | cbc9db074cad3de73e6cbc8482cc34c66b022ef5 (diff) | |
Fix typo in `validate_address_params` helper
This change fixes a typo in the params helper for addresses without a
`state` association. This was a previously untested behaviour so we never
caught this. This change also marks the failing test as no longer
pending.
| -rw-r--r-- | lib/super_good/solidus_taxjar/api_params.rb | 2 | ||||
| -rw-r--r-- | spec/super_good/solidus_taxjar/api_params_spec.rb | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/lib/super_good/solidus_taxjar/api_params.rb b/lib/super_good/solidus_taxjar/api_params.rb index ebf034d..ef189e9 100644 --- a/lib/super_good/solidus_taxjar/api_params.rb +++ b/lib/super_good/solidus_taxjar/api_params.rb @@ -69,7 +69,7 @@ module SuperGood def validate_address_params(spree_address) { country: spree_address.country&.iso, - state: spree_address.state&.abbr || adddress.state_name, + state: spree_address.state&.abbr || spree_address.state_name, zip: spree_address.zipcode, city: spree_address.city, street: spree_address.address1 diff --git a/spec/super_good/solidus_taxjar/api_params_spec.rb b/spec/super_good/solidus_taxjar/api_params_spec.rb index a86b7c6..6c13e03 100644 --- a/spec/super_good/solidus_taxjar/api_params_spec.rb +++ b/spec/super_good/solidus_taxjar/api_params_spec.rb @@ -389,7 +389,6 @@ RSpec.describe SuperGood::SolidusTaxjar::ApiParams do end it "uses the state_name to build address params" do - pending("fix for state name fallback") expect(subject).to eq({ country: "GB", state: "West Midlands", |