From 6cfe54f911648e46da4e65face658ce4f91c491f Mon Sep 17 00:00:00 2001 From: Alessandro Desantis Date: Wed, 7 Oct 2020 16:33:01 +0200 Subject: Simplify line item management permissions It isn't possible to manage line items through an order anymore, so we can greatly simplify the permission set. --- .../permission_sets/subscription_management.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'lib') diff --git a/lib/solidus_subscriptions/permission_sets/subscription_management.rb b/lib/solidus_subscriptions/permission_sets/subscription_management.rb index 8f5edfb..76c1e94 100644 --- a/lib/solidus_subscriptions/permission_sets/subscription_management.rb +++ b/lib/solidus_subscriptions/permission_sets/subscription_management.rb @@ -5,12 +5,11 @@ module SolidusSubscriptions class SubscriptionManagement < ::Spree::PermissionSets::Base def activate! can :manage, Subscription do |subscription| - subscription.user == user + subscription.user && subscription.user == user end - can :manage, LineItem do |line_item, order| - (line_item.order && line_item.order == order) || - (line_item.order&.user && line_item.order.user == user) + can :manage, LineItem do |line_item| + line_item.subscription&.user && line_item.subscription.user == user end end end -- cgit v1.2.3