summaryrefslogtreecommitdiff
path: root/apps/tagtree.c
AgeCommit message (Collapse)Author
2009-11-03Comment out LOGF_ENABLE defines everywhere, replace evil commentsJeffrey Goode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23497 a1c6a512-1295-4272-9138-f99709370657
2009-10-31FS#10739: playback.c code splitJeffrey Goode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23444 a1c6a512-1295-4272-9138-f99709370657
2009-10-20Correct wrong usage of event callbacks all over the place. It's not supposed ↵Thomas Martitz
to return anything, and should take a data parameter. Fixing it because correcting the event api prototypes causes many warnings. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23301 a1c6a512-1295-4272-9138-f99709370657
2009-08-20Fix displaying of the database browser's progress splash so that it works as ↵Thomas Martitz
intended (according to r16432: hide until 0.5s have passed, but never if the disk isn't spinning). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22442 a1c6a512-1295-4272-9138-f99709370657
2009-08-12Make kbd_input() show a cancel splash to indicate user abort better and for ↵Thomas Martitz
better consistency all over the place. Change checking for its return value (style-wise) at some places too. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22269 a1c6a512-1295-4272-9138-f99709370657
2009-07-14FS#10080Nils Wallménius
* Move strncpy() from core to the pluginlib * Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins * Drop strncpy() from the codec api as no codec used it * Bump codec and plugin api versions git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-06-20A bunch of stability fixes into tagcache engine and database browser. Mainly ↵Miika Pekkarinen
data retrieval problems, races, data corruption of sorted index files at the end with junk data, access to unitialized memory and so on. Should fix FS#8710 and may fix FS#8414. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21402 a1c6a512-1295-4272-9138-f99709370657
2009-06-03Replace arrays of tags that are numeric/sorted/uniqued with bitfields ↵Andrew Mahone
flagging each tag that is a member of the set, and replace the membership tests with a shift and bitwise and. The test is still done inside a function on SH, as this saves some space vs the macro used on other targets. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21175 a1c6a512-1295-4272-9138-f99709370657
2009-05-30Rename struct root_menu and the global int root_menu to avoid clashes with ↵Thomas Martitz
#including plugin.h (which #includes root_menu.h), which will be needed for pictureflow in the database (I have some code for that). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21137 a1c6a512-1295-4272-9138-f99709370657
2009-05-30Move enum table into tagtree.c as it's not used elsewhere and switch to ↵Thomas Martitz
uppercase for its constants as per docs/CONTRIBUTING. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21135 a1c6a512-1295-4272-9138-f99709370657
2009-05-21Remove some unused declarationsBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21010 a1c6a512-1295-4272-9138-f99709370657
2009-03-08Yet more #include cleanupsBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20249 a1c6a512-1295-4272-9138-f99709370657
2008-11-01Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do ↵Frank Gevaerts
that, it also introduces sd_*, nand_*, and mmc_*. This should be a good first step to allow multi-driver targets, like the Elio (ATA/SD), or the D2 (NAND/SD). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18960 a1c6a512-1295-4272-9138-f99709370657
2008-10-16Accept FS#9480 - centralise and organise the events in the apps/ layer. Jonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18819 a1c6a512-1295-4272-9138-f99709370657
2008-10-07add HAVE_DISK_STORAGE, and use that instead of HAVE_FLASH_STORAGE when ↵Frank Gevaerts
checking for an actual disk (i.e. related to spindown, skipping,...) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18735 a1c6a512-1295-4272-9138-f99709370657
2008-08-19dont let the database create a new playlist when party mode is on. (fixes ↵Jonathan Gordon
FS#8292) its not consistant with the filebrowser though, i.e you have to open the context menu for the item to add it to the playlist (whereas in the filebrowser it automatically gets queued if its selected) still better than ignoreing the setting though git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18316 a1c6a512-1295-4272-9138-f99709370657
2008-08-15FS#9281 Rename of splash functions.Nils Wallménius
* Remove gui_splash() * Rename gui_syncsplash() to splashf() and remove its voice capabilities. * Rename the internal splash() to splash_internal() and introduce an externally visible splash() that handles simple splashing without printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, "foo"); if a LANG_* id is passed it will be voiced. * Adjust all places that called gui_syncsplash() to use the correct variant from above. * Export both new functions to plugins and adjust places calling rb->splash() to use the correct variant so that we now have naming consistency between the core and plugins. * Fix one latent bug that would cause my sim to crash with the above changes and correct P2STR and P2ID macros, thanks to pondlife. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-07-03Implement FS#8947 - Add a stub in the simulator for ata_disk_is_active. This ↵Bertrik Sikken
make it possible to clean up some #ifdef SIMULATOR macros. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17927 a1c6a512-1295-4272-9138-f99709370657
2008-07-01fix FS#9104 - Database sorting does not work on un-filtered list Robert Kukla
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17910 a1c6a512-1295-4272-9138-f99709370657
2008-06-29very minor code police. also fix a possible but unlikely missed cpu_boost(false)Jonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17867 a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg
later. We still need to hunt down snippets used that are not. 1324 modified files... http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-05-01Introduce a small helper function that asks the user if the dynamic playlist ↵Nils Wallménius
should be erased to increase code re-use git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17295 a1c6a512-1295-4272-9138-f99709370657
2008-04-28Moved atoi declaration to stdlib.h. Deleted atoi.hBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-27Updated use of events.h header file.Bertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17267 a1c6a512-1295-4272-9138-f99709370657
2008-04-26Const police raid, making a lot of pointers to lang strings const and ↵Nils Wallménius
removing some ugly casting git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-20Renamed remove_all_tracks to playlist_remove_all_tracks to make it ↵Bertrik Sikken
consistent with the naming of the other functions in playlist.c git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17186 a1c6a512-1295-4272-9138-f99709370657
2008-03-17It makes more sense for the callback registrar to decide if its a "oneshot" ↵Jonathan Gordon
then the callback caller. (Doing it this way means playback could(/should?) registar a disk spinup callback at init which is called every spinup without needing to be reregistered) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16685 a1c6a512-1295-4272-9138-f99709370657
2008-03-16Implement the playback event handling as a system-wide multi-purpose event ↵Miika Pekkarinen
system. Unified mpeg.c and playback.c audio event handling. Converted ata_idle_notify to use the new event handling system also. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16682 a1c6a512-1295-4272-9138-f99709370657
2008-03-07Fixed red. HWCODEC platforms still use the old api.Miika Pekkarinen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16549 a1c6a512-1295-4272-9138-f99709370657
2008-03-07Rewritten playback event handling. Should fix runtime statistics gathering.Miika Pekkarinen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16546 a1c6a512-1295-4272-9138-f99709370657
2008-02-27Fix sim builds.Barry Wardell
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16433 a1c6a512-1295-4272-9138-f99709370657
2008-02-27More improvement to the display of Searching... splashes in the tagtree:Barry Wardell
1) Only show splashes on searches after 1/2 second has passed. This avoids splashes for very short searches. 2) Update the splash a little more frequently for better feedback. 3) Fix a bug where the number of items found was reported wrongly a lot of the time. 4) Display the splash straight away if the disk needs to spin up because it's definitely going to be waiting at least a couple of seconds then. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16432 a1c6a512-1295-4272-9138-f99709370657
2008-02-26Remove the annoying 'Searching...0 tracks found' splash on Sansa when using ↵Barry Wardell
the database. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16429 a1c6a512-1295-4272-9138-f99709370657
2008-02-12fix FS#8599 - First Song in Tagcache can't be ratedRobert Kukla
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16291 a1c6a512-1295-4272-9138-f99709370657
2008-01-03FS#8375 - Fix division by zero using the random database selection in a ↵Steve Bavin
near-empty subset. Thanks to Henri Valta. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15989 a1c6a512-1295-4272-9138-f99709370657
2007-12-21FS#6960 - Add random selection option to database, by Mark Reiche. This ↵Steve Bavin
satisfies FS#6915. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15957 a1c6a512-1295-4272-9138-f99709370657
2007-11-23revise commit r15463 - we still get the immediate display of runtime data in ↵Robert Kukla
the wps, but avoid unnecessary calls while initialising/updating the database. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15781 a1c6a512-1295-4272-9138-f99709370657
2007-11-23Fixed compile errors with logf enabled.Miika Pekkarinen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15777 a1c6a512-1295-4272-9138-f99709370657
2007-11-04Fix for FS#8082:Robert Kukla
runtime data fields are filled like any other fields in the mp3entry struct during the call to get_metadata(); HWCODEC still uses the old callback mechanism git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15463 a1c6a512-1295-4272-9138-f99709370657
2007-10-31Accept FS#8053 by Bertrik Sikken: playback.c and mpeg.c simplification by ↵Nicolas Pennequin
removal of last_track argument in track_(un)buffer callback. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15384 a1c6a512-1295-4272-9138-f99709370657
2007-10-30some improvements to FS#8008 - see tracker entry for detailsRobert Kukla
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15371 a1c6a512-1295-4272-9138-f99709370657
2007-10-29rework my previous commit (FS#8008) to be able to work for any of the ↵Jonathan Gordon
strings in the id3 info struct, new ones need to be added to tagtree.c and tagnavi.config *currently available tags are* #title# #artist# #album# #genre# #composer# #albumartist# and #directory# git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15358 a1c6a512-1295-4272-9138-f99709370657
2007-10-29fix yellowJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15355 a1c6a512-1295-4272-9138-f99709370657
2007-10-29Accept FS#8008 - allows the current artist or album to be used in databse ↵Jonathan Gordon
searches (use the #artist# or #album# keywords in tagnavi.config) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15354 a1c6a512-1295-4272-9138-f99709370657
2007-08-08Add support for grouping tags. From FS#7362.Dan Everton
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14242 a1c6a512-1295-4272-9138-f99709370657
2007-08-06Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by ↵Nils Wallménius
Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
2007-08-05*** Lang v2 cleanup (FS#6574) ***Nils Wallménius
1) Introduces apps/features.txt that controls which strings are included for each target based on defines. 2) .lng and .voice files are now target specific and the format versions of both these file types have been bumped, which means that new voice files are needed. 3) Use the 'features' mechanism to exclude strings for targets that didn't use them. 4) Delete unused and deprecated and duplicated strings, sort strings in english.lang Some string IDs were changed so translations will be slightly worse than before. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-03Add support for parsing the disc number tag from metadata and use of it in ↵Dan Everton
the database. Patch originally from FS#4961 with some minor tweaks by me. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14154 a1c6a512-1295-4272-9138-f99709370657
2007-07-21Queue song statistical data to the tagcache system and update entirely in ↵Miika Pekkarinen
background. Fixes ratings disappearing or not saving in the DB at all. Fixes also UI delay when stopping playback and new statistics are committed to DB. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13955 a1c6a512-1295-4272-9138-f99709370657
2007-06-22FS#7003 - Allow forward references of menus in tagnavi.config.Miika Pekkarinen
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13685 a1c6a512-1295-4272-9138-f99709370657