summaryrefslogtreecommitdiff
path: root/apps/player
AgeCommit message (Collapse)Author
2019-09-24Bug fix icon.c crashes with negative icon indexWilliam Wilgus
The index for Icon_NOICON is -1 which is caught properly as is icon > Icon_Last_Themeable But if you pass an index lower than Icon_NOICON screen_put_iconxy() tries to read memory prior to the iconset resulting in a crash Change-Id: I415e650932d65214d883a1595e22261f22e776b6
2010-05-14Fix remaining reds/yellows.Thomas Martitz
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@26024 a1c6a512-1295-4272-9138-f99709370657
2010-05-07Revert hotkey bitmapsJeffrey Goode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25875 a1c6a512-1295-4272-9138-f99709370657
2010-05-07Hotkey menu items have their own iconJeffrey Goode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25866 a1c6a512-1295-4272-9138-f99709370657
2010-05-06Move c/h files implementing/defining standard library stuff into a new libc ↵Thomas Martitz
directory, also standard'ify some parts of the code base (almost entirely #include fixes). This is to a) to cleanup firmware/common and firmware/include a bit, but also b) for Rockbox as an application which should use the host system's c library and headers, separating makes it easy to exclude our files from the build. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25850 a1c6a512-1295-4272-9138-f99709370657
2009-08-12Fix yellows.Thomas Martitz
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22271 a1c6a512-1295-4272-9138-f99709370657
2009-08-12Make kbd_input() show a cancel splash to indicate user abort better and for ↵Thomas Martitz
better consistency all over the place. Change checking for its return value (style-wise) at some places too. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22269 a1c6a512-1295-4272-9138-f99709370657
2009-03-23Correct Björn's name in various file headers.Nicolas Pennequin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20491 a1c6a512-1295-4272-9138-f99709370657
2008-09-12Make local function static and add missing #includes for Archos playerBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18505 a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg
later. We still need to hunt down snippets used that are not. 1324 modified files... http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-03-08Revert accidental tree commit. Sorry for that.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16576 a1c6a512-1295-4272-9138-f99709370657
2008-03-08Revert accidental tree commit. Sorry for that.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16574 a1c6a512-1295-4272-9138-f99709370657
2008-03-08Revert accidental tree commit. Sorry for that.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16572 a1c6a512-1295-4272-9138-f99709370657
2008-03-08No need to have \n here. panicf() won't output it anyway.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16570 a1c6a512-1295-4272-9138-f99709370657
2008-02-23Small fixes for icon behaviour on the Player: Read viewer icon numbers from ↵Jens Arnold
viewers.config, and correct the icon selection in icons.c. Now viewer supported filetypes get the mirrored question mark icon instead of no icon at all. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16389 a1c6a512-1295-4272-9138-f99709370657
2008-01-05Stop the player vkeyboard from freezing when voice is enabled and it tries ↵Jens Arnold
to spell a non-ASCII character. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15999 a1c6a512-1295-4272-9138-f99709370657
2007-10-19FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not ↵Steve Bavin
just menus), hopefully save some space. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15206 a1c6a512-1295-4272-9138-f99709370657
2007-10-10Slight code policing.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15065 a1c6a512-1295-4272-9138-f99709370657
2007-10-10Fix red Ondio builds. Hwcodec targets can't beep that way, so disable that ↵Jens Arnold
beep for them.* Port the other vkeyboard enhancements (fixed character spelling and edit mode announcement) to the charcell vkeyboard (Player). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15064 a1c6a512-1295-4272-9138-f99709370657
2007-06-11...forgot one.Steve Bavin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13616 a1c6a512-1295-4272-9138-f99709370657
2007-05-19More header and dead code cleanup.Nils Wallménius
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13430 a1c6a512-1295-4272-9138-f99709370657
2007-04-16Customizable icons for all bitmap targets. (FS#7013)Jonathan Gordon
http://www.rockbox.org/twiki/bin/view/Main/CustomIcons for info on format and how to load them git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13177 a1c6a512-1295-4272-9138-f99709370657
2007-03-27Make the charset more maintainable by using an enum for font indexing, fix ↵Jens Arnold
wrong U circumflex, and add 2 missing characters to the vkeyboard. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12940 a1c6a512-1295-4272-9138-f99709370657
2007-03-26Ooops.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12917 a1c6a512-1295-4272-9138-f99709370657
2007-03-26First step of charcell LCD code rework: * Make it fully unicode aware so ↵Jens Arnold
that adding non-ISO8859-1 scripts becomes possible (limited by the LCD capabilities of course). * Make the API more similar to the bitmap LCD code's API. * Moved hardware dependent parts to target tree. * Simplified code. * Jumpscroll temporarily non-functional. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12916 a1c6a512-1295-4272-9138-f99709370657
2007-03-03Remove the need to double up the MENU macros in manu.h.Jonathan Gordon
Icons are now used by their id which must be part of the icons_6x8 enum, or Icon_NOICON for none git-svn-id: svn://svn.rockbox.org/rockbox/trunk@12571 a1c6a512-1295-4272-9138-f99709370657
2005-12-07Code cleanup.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8182 a1c6a512-1295-4272-9138-f99709370657
2005-12-07Fixed player vkeyboard to properly work with unicode on target.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8181 a1c6a512-1295-4272-9138-f99709370657
2005-12-06waiting is over: initial unicode commitMarcoen Hirschberg
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8169 a1c6a512-1295-4272-9138-f99709370657
2005-11-20removed old statusbar and buttonbar codeKevin Ferrare
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8004 a1c6a512-1295-4272-9138-f99709370657
2005-11-16Multi screen support for playlist viewer, some fixes in other gui filesKevin Ferrare
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7901 a1c6a512-1295-4272-9138-f99709370657
2005-08-24Keyboard code cleanup & optimisation. Corrected potential overflow problem.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7397 a1c6a512-1295-4272-9138-f99709370657
2005-08-24Icon code cleanup, optimisation & policeing. Removed unused icons. Applied ↵Jens Arnold
uniform icon naming scheme. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7396 a1c6a512-1295-4272-9138-f99709370657
2005-02-08A bit more elegant cursor position handling.Jens Arnold
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5851 a1c6a512-1295-4272-9138-f99709370657
2005-02-06New virtual keyboard for player: (1) Much more user friendly (button ↵Jens Arnold
directions, no submenu). (2) Now voiced like the recorder keypad. (3) More compact and straightforward code. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5819 a1c6a512-1295-4272-9138-f99709370657
2004-09-19Redesigned the button handling. The code now uses symbolic function defines ↵Björn Stenberg
instead of checking for specific buttons. This makes it easier to add support for new devices with different button layouts. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@5091 a1c6a512-1295-4272-9138-f99709370657
2004-07-14Added bookmark icon for the Player/StudioLinus Nielsen Feltzing
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4880 a1c6a512-1295-4272-9138-f99709370657
2004-07-09Fixed the Player keyboard cursor positioning, bug #983404Linus Nielsen Feltzing
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4861 a1c6a512-1295-4272-9138-f99709370657
2004-05-21Plugin/file type association system. Patch #879411 by Henrik BackeBjörn Stenberg
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4677 a1c6a512-1295-4272-9138-f99709370657
2003-12-12Initial suppport for building Rockbox for Neo. The Neo has a differentDaniel Stenberg
key layout so we need to check for this. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@4138 a1c6a512-1295-4272-9138-f99709370657
2003-06-29Added plugin loader. Moved games, demos and the text viewer to loadable ↵Björn Stenberg
plugins. Copy your *.rock files to /.rockbox/rocks/ git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3769 a1c6a512-1295-4272-9138-f99709370657
2003-06-02We missed the null byte at the end of the string.Kjell Ericson
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3718 a1c6a512-1295-4272-9138-f99709370657
2003-03-11Synched with recorder: Starts editing at the end of the string.Mats Lidell
Bug with long strings fixed (Strings longer than newchars was truncated.) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3431 a1c6a512-1295-4272-9138-f99709370657
2003-01-31Language support for player keyboard.Mats Lidell
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3196 a1c6a512-1295-4272-9138-f99709370657
2003-01-29Removed cursor before adding it.Kjell Ericson
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3183 a1c6a512-1295-4272-9138-f99709370657
2003-01-27Added a "cursor"-function for the keyvoard.Kjell Ericson
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3171 a1c6a512-1295-4272-9138-f99709370657
2003-01-26Cursor movement in the middle of the screen only moves the cursor.Mats Lidell
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3162 a1c6a512-1295-4272-9138-f99709370657
2003-01-24Adds cursor blink and forward and backwards delete to keyboard input. (No ↵Mats Lidell
lang support yet. Still experimental.) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3161 a1c6a512-1295-4272-9138-f99709370657
2003-01-21First version of a "better" keyboard handling for the Player.Kjell Ericson
More to come from Mats and me. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3141 a1c6a512-1295-4272-9138-f99709370657
2003-01-20First attempt in rocklatin1 input for player.Mats Lidell
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3134 a1c6a512-1295-4272-9138-f99709370657