summaryrefslogtreecommitdiff
path: root/apps/onplay.c
AgeCommit message (Collapse)Author
2009-03-08Fix playlist "Insert" a bit.Thomas Martitz
If insert was used to create a new playlist (e.g. inserting without audio playing), the insert position wasn't updated. Thus, the playlist created was in reversed order (except for the first song). This was the reason "Insert last" was actually used as Insert in this case. BUT, this one doesn't update the insert position eiterh, but the order of the songs is fine, at least (due to appending). Now, insert always updates the insert position properly, so that the aforementioned bugs are fixed. Insert is always used now. Other impact: If you create a playlist using insert, every subsequent insert will append songs at the end of the playlist,if you start playback pressing select on songs, every subsequent insert will insert after the current track. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20241 a1c6a512-1295-4272-9138-f99709370657
2009-02-26Fix FS#9945 - Paste operation doesn't detect disk full (and possibly other ↵Jonas Häggqvist
errors). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20121 a1c6a512-1295-4272-9138-f99709370657
2008-12-31Decouple the statusbar drawing from the rest of the screen drawing. it is ↵Jonathan Gordon
not drawn roughly 4x per second automatically. viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.) All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false). This commit also includes some menu/list viewport cleanups from kugel in FS#9603 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-21fix FS#9687 - 'set song rating' should not be shown if the DB isnt useableJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19523 a1c6a512-1295-4272-9138-f99709370657
2008-12-01Fix FS#9357 'Cut/Paste does not remove old folder when replacing', fix ↵Nils Wallménius
suggested by Dan Everton git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19285 a1c6a512-1295-4272-9138-f99709370657
2008-11-30Make struct text_message const in apps/onplay.cBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19270 a1c6a512-1295-4272-9138-f99709370657
2008-10-15Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. ↵Björn Stenberg
Moved mp3data.c/h from firmware to apps. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-05Accept FS#9231 - viewportify the pitch screen by Thomas Martitz.Jonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18714 a1c6a512-1295-4272-9138-f99709370657
2008-09-11Used correct voice messages for some splash screens.Alessio Lenzi
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18498 a1c6a512-1295-4272-9138-f99709370657
2008-09-07Change screens memebers char_width, char_height and nb_lines to functions ↵Peter D'Hoye
returning a calculated value. Fixes FS #9361 because the values were calculated based on sysfont, not the user selected font. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18441 a1c6a512-1295-4272-9138-f99709370657
2008-08-15FS#9281 Rename of splash functions.Nils Wallménius
* Remove gui_splash() * Rename gui_syncsplash() to splashf() and remove its voice capabilities. * Rename the internal splash() to splash_internal() and introduce an externally visible splash() that handles simple splashing without printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, "foo"); if a LANG_* id is passed it will be voiced. * Adjust all places that called gui_syncsplash() to use the correct variant from above. * Export both new functions to plugins and adjust places calling rb->splash() to use the correct variant so that we now have naming consistency between the core and plugins. * Fix one latent bug that would cause my sim to crash with the above changes and correct P2STR and P2ID macros, thanks to pondlife. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg
later. We still need to hunt down snippets used that are not. 1324 modified files... http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-05-29the splash should set the viewport to NULL untill we start passing it a vp. ↵Jonathan Gordon
(not any time soon though) "fix" FS#9044 by changing the delete dir screen to use the splash instead so it doesnt have to worry about the statusbar height git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17654 a1c6a512-1295-4272-9138-f99709370657
2008-05-28Create WPS context (onplay) menus using MAKE_ONPLAYMENU macro. Partial fix ↵Bertrik Sikken
for FS#9037 - Menu exit behaviour is inconsistent in WPS context menu. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17646 a1c6a512-1295-4272-9138-f99709370657
2008-05-22Restore the 'Open With...' menu item to the wps context menu wich was lost ↵Nils Wallménius
somewhere also document the wps context menu delete option git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17608 a1c6a512-1295-4272-9138-f99709370657
2008-05-22FS#9019 - Tidied up WPS context menu. Moved playlist to the top, added ↵Steve Bavin
Playback Settings optiona and removed duplicate options. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17603 a1c6a512-1295-4272-9138-f99709370657
2008-05-13Fix FS#8986, problem where current file changes during deletion.Steve Bavin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17494 a1c6a512-1295-4272-9138-f99709370657
2008-05-05Convert the whole codebase to UTF-8, except docs/COMMITTERS and ↵Nicolas Pennequin
tools/creative.c, which need checking. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17369 a1c6a512-1295-4272-9138-f99709370657
2008-05-04Accept FS#6188: study mode.Stéphane Doyon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17355 a1c6a512-1295-4272-9138-f99709370657
2008-05-04use the playlist catalog code to generate the playlists under Playlist > ↵Jonathan Gordon
Create playlist git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17352 a1c6a512-1295-4272-9138-f99709370657
2008-04-26Const police raid, making a lot of pointers to lang strings const and ↵Nils Wallménius
removing some ugly casting git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-21fix FS#7780 - remove some possibly dangerous items from the file browser ↵Jonathan Gordon
context menu if the <microSD> (or mmc) is selected git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17206 a1c6a512-1295-4272-9138-f99709370657
2008-04-16Use file_exists and dir_exists functions where appropriate, fix one wrong ↵Nils Wallménius
file descriptor check and one possible dir descriptor leak git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
2008-04-14Dont show the playlist catalog item in the file context menu unless the file ↵Jonathan Gordon
is audio or a m3u(8). Mentinoed in FS#8752 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17106 a1c6a512-1295-4272-9138-f99709370657
2008-04-09FS#8738 - move the progress bar to the bottom of the screen (fixes FS#8736 ↵Robert Kukla
- "fake" progress bar when deleting a folder overlaps the text since r16527) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17055 a1c6a512-1295-4272-9138-f99709370657
2008-04-09fix FS#8860 - File browser context menu shows unnecessary items in an empty ↵Robert Kukla
directory git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17047 a1c6a512-1295-4272-9138-f99709370657
2008-03-29Remove unnecessary (and incorrect) #ifdefs surrounding #include ↵Dave Chapman
"backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
2008-03-26the menu and list now accepts a parent viewport to draw in (and the menu can ↵Jonathan Gordon
be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-02-12fix FS#8599 - First Song in Tagcache can't be ratedRobert Kukla
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16291 a1c6a512-1295-4272-9138-f99709370657
2008-02-10Accept FS #8570 by Thomas Martitz: recording dir location was not saved when ↵Peter D'Hoye
set via context menu. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16275 a1c6a512-1295-4272-9138-f99709370657
2007-11-08only display set rating menu entry if "gather runtime data" is enabled (was ↵Robert Kukla
removed with jdGordon's last commit). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15538 a1c6a512-1295-4272-9138-f99709370657
2007-11-08rework the set song rating setting so it uses the standard list. also the ↵Jonathan Gordon
menu item will not disappear if the rating cant actually be set like it used to (it will splash <No Info> instead... ) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15529 a1c6a512-1295-4272-9138-f99709370657
2007-11-04revert my previous commit and do it in a much less hacky way (both of these ↵Jonathan Gordon
were for FS#8084) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
2007-11-04return to the main menu if stop is pressed in the wps context menu, (blame ↵Jonathan Gordon
pondlife for the hack :D ) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15457 a1c6a512-1295-4272-9138-f99709370657
2007-10-09Add a voice callback to dynamic menus, along side the text_callback.Stéphane Doyon
From FS#7563. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-09-03Accept FS #7667 by Alexander Levin with minor fixes by me. Splits the ↵Peter D'Hoye
shortcuts plugin into two, one for adding and one for viewing. Removes hard-coded file extension and allows to link from one shortcut file to another. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14599 a1c6a512-1295-4272-9138-f99709370657
2007-08-22Fix bug where cross volume cut/paste would report failure even though it ↵Barry Wardell
succeeded. Reported in a comment in FS#7634. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14422 a1c6a512-1295-4272-9138-f99709370657
2007-08-06Accept FS#6159 'Add voice to roughly 100 splash screens and yes-no menus' by ↵Nils Wallménius
Stephane Doyon with some minor tweaks by me. Rerun 'configure' and do a 'make clean' before rebuilding your voice files. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14213 a1c6a512-1295-4272-9138-f99709370657
2007-08-05Oops remove misleading left-behind commentNils Wallménius
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14205 a1c6a512-1295-4272-9138-f99709370657
2007-08-05*** Lang v2 cleanup (FS#6574) ***Nils Wallménius
1) Introduces apps/features.txt that controls which strings are included for each target based on defines. 2) .lng and .voice files are now target specific and the format versions of both these file types have been bumped, which means that new voice files are needed. 3) Use the 'features' mechanism to exclude strings for targets that didn't use them. 4) Delete unused and deprecated and duplicated strings, sort strings in english.lang Some string IDs were changed so translations will be slightly worse than before. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14198 a1c6a512-1295-4272-9138-f99709370657
2007-08-05Accept FS#7486 - shortcuts plugin.Jonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14191 a1c6a512-1295-4272-9138-f99709370657
2007-08-05Address FS#6310 - shows an "infinite" slider when deleting/copying/moving files.Jonathan Gordon
maybe add this to other parts of the code so it doesnt look like the ui has stalled git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14189 a1c6a512-1295-4272-9138-f99709370657
2007-07-31Accept FS#7437 - add the delete option to the wps context menu so the ↵Jonathan Gordon
currently playing file can be deleted. tested with a 130mb file on my sansa and it didnt cause problems git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14099 a1c6a512-1295-4272-9138-f99709370657
2007-07-21Queue song statistical data to the tagcache system and update entirely in ↵Miika Pekkarinen
background. Fixes ratings disappearing or not saving in the DB at all. Fixes also UI delay when stopping playback and new statistics are committed to DB. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13955 a1c6a512-1295-4272-9138-f99709370657
2007-07-10User configurable recording path (my patch in FS#7201). path defaults to / ↵Jonathan Gordon
and can be changed in the folder context menu (cleared in the recording settings menu) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13838 a1c6a512-1295-4272-9138-f99709370657
2007-05-20Add splash messages while copying, moving, and deleting files. Also boost ↵Dan Everton
the CPU during move/copy since it seems to make things faster. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13441 a1c6a512-1295-4272-9138-f99709370657
2007-05-19Remove unused function and unused headerNils Wallménius
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13424 a1c6a512-1295-4272-9138-f99709370657
2007-05-15Use INSERT_LAST when inserting tracks before playback has started. Fixes ↵Hardeep Sidhu
FS#7153. Also code policed for 80 col limit. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13396 a1c6a512-1295-4272-9138-f99709370657
2007-05-14Add an item to the WPS context menu to browse a currently playing cuesheet. ↵Nicolas Pennequin
The menu that appears allows changing tracks within the cuesheet. It was already reachable by selecting the right cuesheet file in the file browser, but this makes it easier to use (and should help users noticing that possibility because many seemed to ignore this viewer existed). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13388 a1c6a512-1295-4272-9138-f99709370657
2007-05-03Enable playlist functions for m3u filesHardeep Sidhu
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@13308 a1c6a512-1295-4272-9138-f99709370657
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 14:05:57 +0000