summaryrefslogtreecommitdiff
path: root/apps/onplay.c
AgeCommit message (Collapse)Author
2010-01-01Simplify some expressions using the ? operatorBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24136 a1c6a512-1295-4272-9138-f99709370657
2010-01-01Make the delete_handler function return the actual result, instead of just ↵Mohamed Tarek
'false'. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24135 a1c6a512-1295-4272-9138-f99709370657
2009-12-18Fix FS#10433 - "Play Next" should use the "warn on playlist change" setting ↵Jonathan Gordon
like the rest of the options that erase the playlist git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24064 a1c6a512-1295-4272-9138-f99709370657
2009-11-11remove 3 bad viewport functions:Jonathan Gordon
* viewport_set_current_vp() because if a screen wants to not use the user setting it shouldn't be dealing with the viewport manager at all (other than to disable the bars) * viewport_ui_vp_get_state() is unused (and not needed) * viewport_get_current_vp() because you should be using set_defaults() instead. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23606 a1c6a512-1295-4272-9138-f99709370657
2009-11-09Removed unneeded includesJeffrey Goode
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23578 a1c6a512-1295-4272-9138-f99709370657
2009-11-01Show insert_last_shuffled item and queue_last_shuffled item when playlist ↵Teruaki Kawashima
file is selected. break long lines. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23464 a1c6a512-1295-4272-9138-f99709370657
2009-10-28Committing FS#10717 by Tomasz Kowalyczyk: add PLAYLIST_INSERT_LAST_SHUFFLED ↵Dave Hooper
(appends the inserted folder into shuffled order to end of playlist) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@23385 a1c6a512-1295-4272-9138-f99709370657
2009-08-23Change the "Rename failed" message to a splash.Thomas Martitz
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22472 a1c6a512-1295-4272-9138-f99709370657
2009-08-23Bound the progress slider into the currently used viewport (which should be ↵Thomas Martitz
the ui viewport at virtually any time). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22471 a1c6a512-1295-4272-9138-f99709370657
2009-08-06Add backdrop functions to the multiscreen api and add a enum backdrop_type ↵Thomas Martitz
parameter for different backdrops (main, wps), symplifying calls and removing dozens of #ifdefs (stubs added for non-backdrop displays that can't do backdrops). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@22176 a1c6a512-1295-4272-9138-f99709370657
2009-07-20rework cuesheet support:Jonathan Gordon
swcodec: search for a .cue during buffering (with the possibility of adding embedded cuesheets later) hwcodec: search for a .cue when the id3 info for the current track is requested for the first time (disk should be spining so non issue) major beenfit from this is simplofy cuesheet handling code a bit... if mp3entry.cuesheet != NULL then there is a valid cuesheet.. no need to worry about if its enabled and preloaded. There is the possibility of putting the next/prev subtrack handling inside the playback code (as well as the id3 updating stuff (see FS#9789 for more info), but thats probably not a good idea. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21978 a1c6a512-1295-4272-9138-f99709370657
2009-07-14FS#10080Nils Wallménius
* Move strncpy() from core to the pluginlib * Introduce strlcpy() and use that instead in most places (use memcpy in a few) in core and some plugins * Drop strncpy() from the codec api as no codec used it * Bump codec and plugin api versions git-svn-id: svn://svn.rockbox.org/rockbox/trunk@21863 a1c6a512-1295-4272-9138-f99709370657
2009-05-09Remove unneeded #include "backdrop.h"Bertrik Sikken
Remove unneeded #include "statusbar.h" git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20891 a1c6a512-1295-4272-9138-f99709370657
2009-03-08Fix playlist "Insert" a bit.Thomas Martitz
If insert was used to create a new playlist (e.g. inserting without audio playing), the insert position wasn't updated. Thus, the playlist created was in reversed order (except for the first song). This was the reason "Insert last" was actually used as Insert in this case. BUT, this one doesn't update the insert position eiterh, but the order of the songs is fine, at least (due to appending). Now, insert always updates the insert position properly, so that the aforementioned bugs are fixed. Insert is always used now. Other impact: If you create a playlist using insert, every subsequent insert will append songs at the end of the playlist,if you start playback pressing select on songs, every subsequent insert will insert after the current track. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20241 a1c6a512-1295-4272-9138-f99709370657
2009-02-26Fix FS#9945 - Paste operation doesn't detect disk full (and possibly other ↵Jonas Häggqvist
errors). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@20121 a1c6a512-1295-4272-9138-f99709370657
2008-12-31Decouple the statusbar drawing from the rest of the screen drawing. it is ↵Jonathan Gordon
not drawn roughly 4x per second automatically. viewport_Set_defaults() will setup the given viewport with the correct "full screen" dimensions (so start at 0,0 if statusbars are disabled or 0,8 if they are enabled.) All screens should keep the statusbar enabled, but if you really want to ignore the user setting you can disbaled it with viewportmanager_set_statusbar(false). This commit also includes some menu/list viewport cleanups from kugel in FS#9603 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19622 a1c6a512-1295-4272-9138-f99709370657
2008-12-21fix FS#9687 - 'set song rating' should not be shown if the DB isnt useableJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19523 a1c6a512-1295-4272-9138-f99709370657
2008-12-01Fix FS#9357 'Cut/Paste does not remove old folder when replacing', fix ↵Nils Wallménius
suggested by Dan Everton git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19285 a1c6a512-1295-4272-9138-f99709370657
2008-11-30Make struct text_message const in apps/onplay.cBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@19270 a1c6a512-1295-4272-9138-f99709370657
2008-10-15Split id3.c/h into metadata.c/h and metadata/mp3.c. Updated all references. ↵Björn Stenberg
Moved mp3data.c/h from firmware to apps. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18814 a1c6a512-1295-4272-9138-f99709370657
2008-10-05Accept FS#9231 - viewportify the pitch screen by Thomas Martitz.Jonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18714 a1c6a512-1295-4272-9138-f99709370657
2008-09-11Used correct voice messages for some splash screens.Alessio Lenzi
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18498 a1c6a512-1295-4272-9138-f99709370657
2008-09-07Change screens memebers char_width, char_height and nb_lines to functions ↵Peter D'Hoye
returning a calculated value. Fixes FS #9361 because the values were calculated based on sysfont, not the user selected font. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18441 a1c6a512-1295-4272-9138-f99709370657
2008-08-15FS#9281 Rename of splash functions.Nils Wallménius
* Remove gui_splash() * Rename gui_syncsplash() to splashf() and remove its voice capabilities. * Rename the internal splash() to splash_internal() and introduce an externally visible splash() that handles simple splashing without printf functionality e.g. splash(HZ, ID2P(LANG_FOO)); or splash(HZ, "foo"); if a LANG_* id is passed it will be voiced. * Adjust all places that called gui_syncsplash() to use the correct variant from above. * Export both new functions to plugins and adjust places calling rb->splash() to use the correct variant so that we now have naming consistency between the core and plugins. * Fix one latent bug that would cause my sim to crash with the above changes and correct P2STR and P2ID macros, thanks to pondlife. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@18282 a1c6a512-1295-4272-9138-f99709370657
2008-06-28Updated our source code header to explicitly mention that we are GPL v2 orDaniel Stenberg
later. We still need to hunt down snippets used that are not. 1324 modified files... http://www.rockbox.org/mail/archive/rockbox-dev-archive-2008-06/0060.shtml git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17847 a1c6a512-1295-4272-9138-f99709370657
2008-05-29the splash should set the viewport to NULL untill we start passing it a vp. ↵Jonathan Gordon
(not any time soon though) "fix" FS#9044 by changing the delete dir screen to use the splash instead so it doesnt have to worry about the statusbar height git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17654 a1c6a512-1295-4272-9138-f99709370657
2008-05-28Create WPS context (onplay) menus using MAKE_ONPLAYMENU macro. Partial fix ↵Bertrik Sikken
for FS#9037 - Menu exit behaviour is inconsistent in WPS context menu. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17646 a1c6a512-1295-4272-9138-f99709370657
2008-05-22Restore the 'Open With...' menu item to the wps context menu wich was lost ↵Nils Wallménius
somewhere also document the wps context menu delete option git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17608 a1c6a512-1295-4272-9138-f99709370657
2008-05-22FS#9019 - Tidied up WPS context menu. Moved playlist to the top, added ↵Steve Bavin
Playback Settings optiona and removed duplicate options. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17603 a1c6a512-1295-4272-9138-f99709370657
2008-05-13Fix FS#8986, problem where current file changes during deletion.Steve Bavin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17494 a1c6a512-1295-4272-9138-f99709370657
2008-05-05Convert the whole codebase to UTF-8, except docs/COMMITTERS and ↵Nicolas Pennequin
tools/creative.c, which need checking. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17369 a1c6a512-1295-4272-9138-f99709370657
2008-05-04Accept FS#6188: study mode.Stéphane Doyon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17355 a1c6a512-1295-4272-9138-f99709370657
2008-05-04use the playlist catalog code to generate the playlists under Playlist > ↵Jonathan Gordon
Create playlist git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17352 a1c6a512-1295-4272-9138-f99709370657
2008-04-26Const police raid, making a lot of pointers to lang strings const and ↵Nils Wallménius
removing some ugly casting git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-21fix FS#7780 - remove some possibly dangerous items from the file browser ↵Jonathan Gordon
context menu if the <microSD> (or mmc) is selected git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17206 a1c6a512-1295-4272-9138-f99709370657
2008-04-16Use file_exists and dir_exists functions where appropriate, fix one wrong ↵Nils Wallménius
file descriptor check and one possible dir descriptor leak git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17147 a1c6a512-1295-4272-9138-f99709370657
2008-04-14Dont show the playlist catalog item in the file context menu unless the file ↵Jonathan Gordon
is audio or a m3u(8). Mentinoed in FS#8752 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17106 a1c6a512-1295-4272-9138-f99709370657
2008-04-09FS#8738 - move the progress bar to the bottom of the screen (fixes FS#8736 ↵Robert Kukla
- "fake" progress bar when deleting a folder overlaps the text since r16527) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17055 a1c6a512-1295-4272-9138-f99709370657
2008-04-09fix FS#8860 - File browser context menu shows unnecessary items in an empty ↵Robert Kukla
directory git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17047 a1c6a512-1295-4272-9138-f99709370657
2008-03-29Remove unnecessary (and incorrect) #ifdefs surrounding #include ↵Dave Chapman
"backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
2008-03-26the menu and list now accepts a parent viewport to draw in (and the menu can ↵Jonathan Gordon
be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-02-12fix FS#8599 - First Song in Tagcache can't be ratedRobert Kukla
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16291 a1c6a512-1295-4272-9138-f99709370657
2008-02-10Accept FS #8570 by Thomas Martitz: recording dir location was not saved when ↵Peter D'Hoye
set via context menu. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16275 a1c6a512-1295-4272-9138-f99709370657
2007-11-08only display set rating menu entry if "gather runtime data" is enabled (was ↵Robert Kukla
removed with jdGordon's last commit). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15538 a1c6a512-1295-4272-9138-f99709370657
2007-11-08rework the set song rating setting so it uses the standard list. also the ↵Jonathan Gordon
menu item will not disappear if the rating cant actually be set like it used to (it will splash <No Info> instead... ) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15529 a1c6a512-1295-4272-9138-f99709370657
2007-11-04revert my previous commit and do it in a much less hacky way (both of these ↵Jonathan Gordon
were for FS#8084) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15458 a1c6a512-1295-4272-9138-f99709370657
2007-11-04return to the main menu if stop is pressed in the wps context menu, (blame ↵Jonathan Gordon
pondlife for the hack :D ) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15457 a1c6a512-1295-4272-9138-f99709370657
2007-10-09Add a voice callback to dynamic menus, along side the text_callback.Stéphane Doyon
From FS#7563. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@15042 a1c6a512-1295-4272-9138-f99709370657
2007-09-03Accept FS #7667 by Alexander Levin with minor fixes by me. Splits the ↵Peter D'Hoye
shortcuts plugin into two, one for adding and one for viewing. Removes hard-coded file extension and allows to link from one shortcut file to another. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14599 a1c6a512-1295-4272-9138-f99709370657
2007-08-22Fix bug where cross volume cut/paste would report failure even though it ↵Barry Wardell
succeeded. Reported in a comment in FS#7634. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14422 a1c6a512-1295-4272-9138-f99709370657
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 08:37:01 +0000