summaryrefslogtreecommitdiff
path: root/apps/metadata
AgeCommit message (Collapse)Author
2011-09-14Fix FS#12266, by skipping empty frames when reading ID3v2 tags. Also add ↵Magnus Holmgren
some length checks to be safe. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30550 a1c6a512-1295-4272-9138-f99709370657
2011-08-27FS#12163 by Sean BartellNils Wallménius
get_long_be shifts an unsigned char left--which results in a signed int. It then implicitly casts to unsigned long, which sign-extends the int, leaving unwanted 1's in the upper bits. This affects AIFF. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30364 a1c6a512-1295-4272-9138-f99709370657
2011-08-11libgme: make local functions static where possibleBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30280 a1c6a512-1295-4272-9138-f99709370657
2011-08-07Submit initial patch from FS#12176. Adds support for several new game music ↵Andree Buschmann
formats (AY, GBS, HES, KSS, SGC, VGM and VGZ) and replaces the current NSF and NSFE with a new implementation based on a port of the Game Music Emu library 'GME'. This first submit does not cover the full functionality provided by the author's original patch: Coleco-SGV is not supported, some GME-specific m3u-support has been removed and IRAM is not used yet. Further changes are very likely to follow this submit. Thanks to Mauricio Garrido. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30264 a1c6a512-1295-4272-9138-f99709370657
2011-08-07Submit FS#12218. Add support for embedded album art for ASF tags. For now ↵Andree Buschmann
the support is limited to embedded pictures of max 64 KB size. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30263 a1c6a512-1295-4272-9138-f99709370657
2011-08-06Fix replaygain for wma files which was broken since r29388.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30259 a1c6a512-1295-4272-9138-f99709370657
2011-07-25Submit FS#12196. Adds support for embedded album art (jpg) with APEv2 tags.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30210 a1c6a512-1295-4272-9138-f99709370657
2011-06-30Use id3v2buf to read the title of MOD files. Avoids additional declaration ↵Andree Buschmann
of a 1KB buffer and saves a bit codesize as well. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@30105 a1c6a512-1295-4272-9138-f99709370657
2011-05-01Remove tabs.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29813 a1c6a512-1295-4272-9138-f99709370657
2011-05-01Fix further 'variable set but not used' warnings reported from GCC 4.6.0.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29809 a1c6a512-1295-4272-9138-f99709370657
2011-04-28Get the NSF internal playlists working again. Fix a few wrongdoings in the ↵Michael Sevakis
metadata parser. Use the larger of track or playlist count to determine 'duration' so that the repeat-one switching to access the raw tracks works. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29793 a1c6a512-1295-4272-9138-f99709370657
2011-04-27Fix r29790 yellow. Need 'string-extra.h' for strlcpy().Michael Sevakis
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29791 a1c6a512-1295-4272-9138-f99709370657
2011-04-27Get NSF fixed up a bit and parse metadata in the core.Michael Sevakis
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29790 a1c6a512-1295-4272-9138-f99709370657
2011-04-27Commit FS#12069 - Playback rework - first stages. Gives as thorough as ↵Michael Sevakis
possible a treatment of codec management, track change and metadata logic as possible while maintaining fairly narrow focus and not rewriting everything all at once. Please see the rockbox-dev mail archive on 2011-04-25 (Playback engine rework) for a more thorough manifest of what was addressed. Plugins and codecs become incompatible. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29785 a1c6a512-1295-4272-9138-f99709370657
2011-04-06Removed some dead code identified by clang-analyzer.Björn Stenberg
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29685 a1c6a512-1295-4272-9138-f99709370657
2011-03-16Hopefully fix red now and reduce binsize for HWCODEC targets. This change ↵Andree Buschmann
implements a local read_uint32be() function within the mp3data parser. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29606 a1c6a512-1295-4272-9138-f99709370657
2011-03-16Fix red. read_uint32be() was not implemented in sim builds for HWCODEC targets.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29605 a1c6a512-1295-4272-9138-f99709370657
2011-03-15Disable debug output in wave format parser by default.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29592 a1c6a512-1295-4272-9138-f99709370657
2011-03-15Submit FS#12009. Add embedded album art support for m4a. Thanks to Jason Yu.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29591 a1c6a512-1295-4272-9138-f99709370657
2011-02-27Remove some useless code and variables in the area of metadata parsing. Bump ↵Andree Buschmann
codec API. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29438 a1c6a512-1295-4272-9138-f99709370657
2011-02-24FS#11964. Rework replaygain handling to save metadata buffer and binsize. ↵Andree Buschmann
Remove string representation of replaygain and use a dedicated ftoa implementation for WPS/screen info. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29388 a1c6a512-1295-4272-9138-f99709370657
2011-02-22Submit FS11960. Limit metadata item size like done for ID3 tags since r29174.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29377 a1c6a512-1295-4272-9138-f99709370657
2011-02-22Proper initialize dummy destination address to ensure correct functionality ↵Andree Buschmann
for replaygain in mp4 metadata. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29376 a1c6a512-1295-4272-9138-f99709370657
2011-02-22Fix FS#11956. Call parse_replaygain() with correct parameters in ID3 tag ↵Andree Buschmann
parsing. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29375 a1c6a512-1295-4272-9138-f99709370657
2011-02-21Fix FS#11955. ID3 tag parser was broken since r29349. Trimming strings must ↵Andree Buschmann
be done in the helper functions, not outside. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29372 a1c6a512-1295-4272-9138-f99709370657
2011-02-20FS#11920: Do not overwrite already existing metadata and take into account ↵Andree Buschmann
string termination. This can save several bytes of the metadata buffer when tags have multiple entries (e.g. multiple gerne tags) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29349 a1c6a512-1295-4272-9138-f99709370657
2011-02-17Ensure proper initialization of some variables and arrays in metadata ↵Andree Buschmann
parsing. Fixes FS#11948. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29323 a1c6a512-1295-4272-9138-f99709370657
2011-02-15Correct the metadata's VBR flag for MP4 files. ALAC is native VBR, AAC very ↵Andree Buschmann
unlikely is CBR. The VBR flag is used by several WPS. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29313 a1c6a512-1295-4272-9138-f99709370657
2011-02-152nd try: All AAC-HE files will double the frame sample count, not only ↵Andree Buschmann
AAC-HE files with SBR upsampling. This change fixes issues with some m4a files reported in the forums. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29312 a1c6a512-1295-4272-9138-f99709370657
2011-02-15Undo unwanted commit r29310.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29311 a1c6a512-1295-4272-9138-f99709370657
2011-02-15All AAC-HE files will double the frame sample count, not only AAC-HE files ↵Andree Buschmann
with SBR upsampling. This change fixes issues with some m4a files reported in the forums. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29310 a1c6a512-1295-4272-9138-f99709370657
2011-02-09Fix red. Not all targets have album art support.Thomas Martitz
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29260 a1c6a512-1295-4272-9138-f99709370657
2011-02-09Embedded album art support in MP3/ID3v2 tags.Thomas Martitz
- Support is limited to non-desync jpeg in id3v2 tags. Other formats (hopefully) follow in the future. - Embedded album art takes precedence over files in album art files. - No additional buffers are used, the jpeg is read directly from the audio file. Flyspray: FS#11216 Author: Yoshihisa Uchida and I git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29259 a1c6a512-1295-4272-9138-f99709370657
2011-02-03Changes in m4a parser: The metadata (e.g. sampling rate) for alac and aac ↵Andree Buschmann
must read from their dedicated metadata atom. Otherwise there might be wrong settings used. This patch also adds (commented) code which enables parsing for an alac metadata atom if neccessary. I have several sample files which require such parsing to find the metadata atom. Fixes FS#11719. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29201 a1c6a512-1295-4272-9138-f99709370657
2011-02-03Submit FS#11918: Add 2 more codec types to be able to differentiate between ↵Andree Buschmann
AAC / AAC-HE and MPC SV7 / SV8. Additionally handle ATARI soundfiles in get_codec_base_type() as intended. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29199 a1c6a512-1295-4272-9138-f99709370657
2011-02-02Find a more consistent and resilient way to handle SBR upsampled files. The ↵Andree Buschmann
detection is only done in one place (the metadata parser) and takes into account that the m4a header might already report corrected frame/sample sizes. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29188 a1c6a512-1295-4272-9138-f99709370657
2011-02-02Recognize AAC-HE SBR with upsampling and correct duration, bitrate, seek and ↵Andree Buschmann
resume behaviour for such files. When SBR upsampling is used the decoder outputs the double amount of samples per frame. As the seek and resume functions do not know about this fact a special handling is introduced. Fixes issues reported in FS#11916. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29186 a1c6a512-1295-4272-9138-f99709370657
2011-02-02Do not parse into 'ilst' atom if size is 0. Fixes playability issue in FS#11916.Andree Buschmann
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29185 a1c6a512-1295-4272-9138-f99709370657
2011-01-30Limit the size of each ID3 metadata item to avoid that the metadata buffer ↵Andree Buschmann
is filled by single items. Fixes FS#11875, FS#9805 and FS#9299. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29174 a1c6a512-1295-4272-9138-f99709370657
2011-01-21FS#11828: Fix in core mod parser to blindly accept any .mod you throw at it. ↵Thomas Martitz
Based on MikMod. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29105 a1c6a512-1295-4272-9138-f99709370657
2011-01-09Fix FS#11858 which was introduced with r28937. Several *.rm were not played ↵Andree Buschmann
because the parser aborted with error for several files. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29015 a1c6a512-1295-4272-9138-f99709370657
2011-01-01Fix FS#11845 by rejecting unknown header signatures in the audio stream info ↵Mohamed Tarek
block. RALF uses a different header signature than ('.', 'r', 'a', 0xfd). Apparently ('L', 'S', 'D', ':'). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28937 a1c6a512-1295-4272-9138-f99709370657
2010-12-25Add stdio.h include for SEEK_SET define to various files.Thomas Martitz
Patch by Thomas Jarosch. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28892 a1c6a512-1295-4272-9138-f99709370657
2010-12-11Correct mistake in the RealMedia parser that prevented rejecting files with ↵Michael Giacomelli
unsupported codecs. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28788 a1c6a512-1295-4272-9138-f99709370657
2010-12-05remove a little redundant code from the WavPack metadata module to partially ↵Dave Bryant
make up for the code just added git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28738 a1c6a512-1295-4272-9138-f99709370657
2010-12-05make WavPack library check the extent of the block that it is parsing so ↵Dave Bryant
that it cannot run into the next block; also enhance the metadata code to handle the case of files with non-audio blocks at the beginning (which can happen if the source WAV file has lots of RIFF data) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28736 a1c6a512-1295-4272-9138-f99709370657
2010-11-26Change how all the metadata parsers are read from a giant swich/case to ↵Thomas Martitz
function pointers via array index. Also unify the api. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28672 a1c6a512-1295-4272-9138-f99709370657
2010-10-10Fix FS# 11414 : .mod files - metadata in incorrect fieldsBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28228 a1c6a512-1295-4272-9138-f99709370657
2010-09-28id3 parser: also add id3v2.2 TCM tag for "composer" since that's the only ↵Torne Wuff
other tag not in there in 2.2 and 2.3 versions git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28182 a1c6a512-1295-4272-9138-f99709370657
2010-09-28id3 parser: add id3v2.2 TPA tag for "part of set" as iTunes appears to use itTorne Wuff
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28181 a1c6a512-1295-4272-9138-f99709370657
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 06:23:58 +0000