summaryrefslogtreecommitdiff
path: root/apps/gui
AgeCommit message (Collapse)Author
2008-04-28Moved atoi declaration to stdlib.h. Deleted atoi.hBertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17280 a1c6a512-1295-4272-9138-f99709370657
2008-04-27Use smaller data types in structs which are in big arrays to save memoryNils Wallménius
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17256 a1c6a512-1295-4272-9138-f99709370657
2008-04-26Const police raid, making a lot of pointers to lang strings const and ↵Nils Wallménius
removing some ugly casting git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17251 a1c6a512-1295-4272-9138-f99709370657
2008-04-23option_screen() now accepts a viewportJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17223 a1c6a512-1295-4272-9138-f99709370657
2008-04-21And fix the bug which I was actually being pinged about...Jonathan Gordon
dont show the selection marker if its not supposed to be shown (i.e the debug lists) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17205 a1c6a512-1295-4272-9138-f99709370657
2008-04-21So, I was skimming the irc logs from my 3 day absense and I was pinged about ↵Jonathan Gordon
a bug in the simplelist code and this function in particular. Neither time was the actual bug explained so I dont know what this commit fixes... I'm fairly certain it does fix it though because the old code was rediculously wrong. MY guess is it has something to do with the radio debug screen seen as its the only call to this with the param != 0. Please use the damn tracker for bug reports.. pinging someone when they arnt even online (as opposed to idling in the channel) really is a waste of time.) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17204 a1c6a512-1295-4272-9138-f99709370657
2008-04-20Fix FS#8914 (WPS %mp tag inconsistency).Nicolas Pennequin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17198 a1c6a512-1295-4272-9138-f99709370657
2008-04-20Fix bug in r17188.Stéphane Doyon
The warning from the build page was valid and helpful, wish my compiler had given it to me... git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17189 a1c6a512-1295-4272-9138-f99709370657
2008-04-20FS#7980: Select default option in an option listStéphane Doyon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17188 a1c6a512-1295-4272-9138-f99709370657
2008-04-20Killed unnecessary global variables by making them static.Bertrik Sikken
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17184 a1c6a512-1295-4272-9138-f99709370657
2008-04-14Revert what was left of r17018 until I find a better way. It had quirks in ↵Nicolas Pennequin
some cases, and doesn't play well with what I'm about to commit. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17108 a1c6a512-1295-4272-9138-f99709370657
2008-04-12Move a function to gwps-common.c because it belongs thereNils Wallménius
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17084 a1c6a512-1295-4272-9138-f99709370657
2008-04-09Pass the buffer length to the list_get_name callback functions instead of ↵Nils Wallménius
using hardcoded MAX_PATH git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17049 a1c6a512-1295-4272-9138-f99709370657
2008-04-07r17018 caused the WPS playlist index display to be wrong with shuffled ↵Nicolas Pennequin
enabled, so we revert to using playlist_get_display_index() on HWCODEC. Using id3->index would require something like what was added in r3726. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17025 a1c6a512-1295-4272-9138-f99709370657
2008-04-07Bring the WPS playlist index display into sync with the track being played ↵Nicolas Pennequin
by using the index field of the ID3 info struct instead of directly asking the playlist code. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@17018 a1c6a512-1295-4272-9138-f99709370657
2008-04-04Add a comment to clarify how the WPS image buffer size is calculatedDave Chapman
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16961 a1c6a512-1295-4272-9138-f99709370657
2008-04-03fix FS#8841 - scrolling doesnt work when using cursor seelction iconJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16941 a1c6a512-1295-4272-9138-f99709370657
2008-04-01WPS parser: also revert to the default WPS when there were bitmap loading ↵Nicolas Pennequin
errors. The reverting is moved from wps_parse() to wps_data_load(). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16914 a1c6a512-1295-4272-9138-f99709370657
2008-03-29Remove unnecessary (and incorrect) #ifdefs surrounding #include ↵Dave Chapman
"backdrop.h", and correct remaining references to HAVE_LCD_REMOTE to HAVE_REMOTE_LCD git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16873 a1c6a512-1295-4272-9138-f99709370657
2008-03-28The const police raid playback.c, should be no change to behaviour.Steve Bavin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16860 a1c6a512-1295-4272-9138-f99709370657
2008-03-26Major cleanup of checkwps - fix all warnings and add a script to build ↵Dave Chapman
versions for all supported targets (plus some unsupported ones). You now need to run the version of checkwps that matches the device your WPS is for. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16831 a1c6a512-1295-4272-9138-f99709370657
2008-03-26Move checkwps to its own subdir in preparation for compiling target-specific ↵Dave Chapman
versions. Also remove a DEBUGF that should not have been left in. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16827 a1c6a512-1295-4272-9138-f99709370657
2008-03-26Fix yellow, and at the same time simplify some #ifdefsDave Chapman
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16823 a1c6a512-1295-4272-9138-f99709370657
2008-03-261) Make Rockbox reject any WPSs if there are errors loading any of the ↵Dave Chapman
required bmps; 2) Make checkwps actually load the images using the Rockbox bmp loader, and reject the WPS in the same was as Rockbox on bmp errors. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16822 a1c6a512-1295-4272-9138-f99709370657
2008-03-26fix the buttonbar in the browser and menus. Jonathan Gordon
fix a problem where the menus wouldnt redraw when they should have when settings change git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16816 a1c6a512-1295-4272-9138-f99709370657
2008-03-26the menu and list now accepts a parent viewport to draw in (and the menu can ↵Jonathan Gordon
be told to not show status/button bars). This lays the groundwork to fix colour problems with plugin menus (see star.c for an example.) This hopefully fixes some button bar issues as well as theme problems. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16812 a1c6a512-1295-4272-9138-f99709370657
2008-03-25Make checkwps compile again. Still more work is needed though, as checkwps ↵Dave Chapman
is compiled to emulate an iPod Color - this needs changing to allow the LCD (and remote LCD) dimensions/depth to be specified on the commandline - the new %V tags are validated against the LCD characteristics git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16807 a1c6a512-1295-4272-9138-f99709370657
2008-03-25Oops. Mop up red.Steve Bavin
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16799 a1c6a512-1295-4272-9138-f99709370657
2008-03-25Code police raid on the settings code, consting and putting headers ↵Steve Bavin
alongside their implementation. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16798 a1c6a512-1295-4272-9138-f99709370657
2008-03-25D'oh - fix a silly #ifdef mistake that caused problems with remote WPSs ↵Dave Chapman
using viewports. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16787 a1c6a512-1295-4272-9138-f99709370657
2008-03-24Stricter syntax checking of the %V tag - pay attention to the return-code ↵Dave Chapman
from parse_list, and check for the tailing | symbol. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16784 a1c6a512-1295-4272-9138-f99709370657
2008-03-24Hopefully get the viewport position/dimensions validation correct this time.Dave Chapman
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16782 a1c6a512-1295-4272-9138-f99709370657
2008-03-24Add another safety-check in the bitmap strips parsing - don't allow the ↵Dave Chapman
num_subimages parameter to %xl to be <= 0 git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16779 a1c6a512-1295-4272-9138-f99709370657
2008-03-24Add a sanity-check to ensure only in-range subimages are referenced in %xd ↵Dave Chapman
tags. Plus some tab policing. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16774 a1c6a512-1295-4272-9138-f99709370657
2008-03-23Add the ability to use bitmap strips (a single .bmp file containing many ↵Dave Chapman
images of the same dimensions, tiled vertically - similar to icon strips) in the WPS. The %xl tag now has an optional "number of subimages" parameter, and the %xd tag has an optional "subimage to display" parameter (a-z,A-Z - allowing up to 52 sub-images). So for example, a bitmap with 10 subimages is loaded with %xl|M|volume.bmp|134|153|10| and then this can be used in a conditional as %?pv<%xdMa|%xdMb|%xdMc|%xdMd|%xdMe|%xdMf|%xdMg|%xdMh|%xdMi|%xdMj>. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16764 a1c6a512-1295-4272-9138-f99709370657
2008-03-23Oops - correctly reset the bmp filenamesDave Chapman
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16762 a1c6a512-1295-4272-9138-f99709370657
2008-03-22Fix the display of peakmeters and progress bars (without a custom y ↵Dave Chapman
position) inside a viewport (broken by r16735). git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16739 a1c6a512-1295-4272-9138-f99709370657
2008-03-22Small simplification - take advantage of the fact that x/y/width/height are ↵Dave Chapman
non-negative integers when validating the viewport bounds. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16736 a1c6a512-1295-4272-9138-f99709370657
2008-03-22Reduce the shocking amount of RAM my viewports implementation was using. ↵Dave Chapman
The first version stored an array of lines for each of the 16 possible viewports (MAX_VIEWPORTS * the number of lines on the LCD with a 5-pixel high font). This version reverts back to a single global array of lines, with each viewport specifying the first and last lines as indexes into that array. This also turns out to be simpler, reducing binsize a little as well. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16735 a1c6a512-1295-4272-9138-f99709370657
2008-03-21Commit viewports-in-WPS patch (FS#8385). This adds the %V tag - see the ↵Dave Chapman
CustomWPS page for details (shortly...). There is still some work to do - decide how to handle font references, decide how to handle conditionals. Plus checkwps is broken - I'll fix that in a separate commit. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16733 a1c6a512-1295-4272-9138-f99709370657
2008-03-21Add a general-purpose parse_list function to parse a string containing a ↵Dave Chapman
delimited list of items and adapt the parse_image_load() function in the WPS parser to use it. This function will also be used to parse the upcoming WPS %V viewport tag, but I'm committing it separately as these changes are unrelated to the viewport implementation itself. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16728 a1c6a512-1295-4272-9138-f99709370657
2008-03-09Bugfix for new list implementation - correctly assign colours for remote ↵Dave Chapman
LCDs (fixes wrong colours on X5 remote) git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16599 a1c6a512-1295-4272-9138-f99709370657
2008-03-09more fixes for button bar... this will all disappear when viewports are ↵Jonathan Gordon
handled by a manager of some sort git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16589 a1c6a512-1295-4272-9138-f99709370657
2008-03-09fix recorder, buttonbar caused list problemsJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16584 a1c6a512-1295-4272-9138-f99709370657
2008-03-05fix the touchpad list codeJonathan Gordon
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16528 a1c6a512-1295-4272-9138-f99709370657
2008-03-05FS#8457 - convert the list drawing code to use viewports. This does not ↵Jonathan Gordon
include any of the customizability which was in the patch, so unless any bugs show up users should not notice any difference. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16527 a1c6a512-1295-4272-9138-f99709370657
2008-02-25Fix the simplelist redraw behaviour. It caused e.g. the 'Open with...' menu ↵Jens Arnold
items to not scroll as they should, making it partially unusable with small displays and/or large fonts. Thanks to JdGordon for pointing me into the right direction. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16415 a1c6a512-1295-4272-9138-f99709370657
2008-02-10Hopefully fix FS#8459 by updating the WPS data when returning from the ↵Nicolas Pennequin
context menu. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16277 a1c6a512-1295-4272-9138-f99709370657
2008-02-05(Hopefully) Revert the quickscreen changes. Many fixes need to be made, Paul Louden
and the exact implementation needs discussion. We apologize for the inconvenience and hope to bring an improved quickscreen to you soon. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16224 a1c6a512-1295-4272-9138-f99709370657
2008-02-05quiet the masses...Jonathan Gordon
stop the wps scrolling happening in the quickscreen green delta for non quickscreen targets nfi why colours arnt working... hopefully bug in firmware/? git-svn-id: svn://svn.rockbox.org/rockbox/trunk@16222 a1c6a512-1295-4272-9138-f99709370657