summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-03-10hosted: Consolidate the code that polls the battery charging statusSolomon Peachy
affects all hiby targets, fiiom3k, and ibasso dx50/dx90 As well as deduplicating a small pile of code, this also implements hysteresis so we're not doing a sysfs read/lookup multiple times back-to-back every time the power management tick fires. Change-Id: I2f7672acbb36341becf67e07960c24c681270d09
2021-03-10Move "View" option for playlists up one levelChristian Soffke
The "View" option for playlists/.m3u files is currently part of the "Current Playlist" submenu even though it refers to the selected file/playlist and has nothing to do with the current playlist. It has been relocated to the context menu of the playlist file where it makes more sense and is easier to get to. Change-Id: I806ed46a7315293d7d20f29ed004cc8ab58cdcb7
2021-03-10Fix "Playlist" vs. "Current Playlist" menu terminology in manualChristian Soffke
The manual has been updated to reflect the fact that the current title of the submenu for adding music in the context menu is "Current Playlist". (The WPS context menu has a different submenu called "Playlist") Change-Id: I2bbeabad6d24673c46d3322529478c4a7a61ca88
2021-03-10usb_hid: switch Battery Strength to use feature reportsJames Buren
This means we will no longer send them routinely and instead rely on the HID driver to send them when the host requests it. This also moves the reporting out of the power management code where it probably did not belong in the first place. Change-Id: I9c8420e81897f1f6caaa55ffacc7525589f1ef75
2021-03-09Move MIPS cache management functions to IRAMAidan MacDonald
Previously these were placed in DRAM, which is overwritten by RoLo when it loads a new image, but RoLo must call commit_discard_idcache() after loading the image. Change-Id: I5dcc4ca711b774166f83c668695edbcabfab2604
2021-03-09Update english-US translation.Solomon Peachy
Change-Id: I9906b6a7033e49d56f480ae80188a7154d2f7560
2021-03-09UI: Rename "Play Next" to "Clear List & Play Next"Christian Soffke
The "Play Next" function replaces the current dynamic playlist, so it makes sense to convey that information to the user when displaying the option in a context menu. Change-Id: Ic6e03e4adbd811e28b5cfeba36b64c5e8a7db2f9
2021-03-09Shortcuts Menu -- remove debug statementsWilliam Wilgus
Change-Id: I4ad370088a6b1da188611ae335fcd7a7e3a57f90
2021-03-09Shortcuts Menu -- Update2William Wilgus
make shortcuts menu drop back into WPS on exit different icons for plugins and files versus folders Change-Id: I1b590c223b63a6b6598c33e767738daaea1c8ad0
2021-03-09Updated Italian translation (Alessio Lenzi)Solomon Peachy
Change-Id: I93acf9d934429dadbc397e53555ae5b16c349b07
2021-03-09FS#13263: Rockbox deletes wrong fileChristian Soffke
The WPS calls onplay() with a pointer to the path of the current track . We need to make a copy of the path so it isn't affected by track changes. Change-Id: I10a2a93da644932033e01ffbfd85cad20abb555d
2021-03-09Reset filetype colors when resetting theme colorsChristian Soffke
Even though filetype colors can't currently be changed by going to Settings->Theme Settings->Colors, a user likely wishes to still reset them when selecting 'Reset Colors' after a .colours file may have been applied by a theme. Change-Id: I4494c83a502666900f6d9d2cc3fb1825af5e45f6
2021-03-09Show 'Play Next' option when playback is stoppedChristian Soffke
1) The Insert functionality was changed in abebc6b to not delete unfinished dynamic playlists anymore. "Play Next" has now been added as an option when playback is stopped. The behavior of "Play Next" as such has not changed and it is now the consistent way to replace a current playlist in all playback modes. 2) The 'Insert' and 'Insert Shuffle' options will now only be displayed if there is a resumable dynamic playlist Change-Id: Ib5c5469b9e2c583ab06e0f47a922c24e5adf6b5f
2021-03-08Shortcuts Menu UpdateWilliam Wilgus
Change Browser shortcut to the plugin icon drop back into WPS on opx return allow same action to exit shortcut menu as entered -- might be problematic Change-Id: Id7013a514c8e8862ee1da44b033d10b7519e9127
2021-03-07ibasso: Fix the dx50/dx90 build (and usb_mode selection)Solomon Peachy
(The usb_mode selection setting was actually broken even though it had been previously compiling...) Change-Id: I0cac31d24c0ef684b934e40ab14f683cc4a31738
2021-03-07usb_mode: Missed a #define that led to some sim build failures.Solomon Peachy
Change-Id: Ie872c5684a200bf99ee7083bb35700a663ef9788
2021-03-07settings: Fix inconsistent #ifdefs wrapping the usb_mode stuffSolomon Peachy
It should be: #if defined(HAVE_USB_POWER) && !defined(USB_NONE) && !defined(SIMULATOR) Change-Id: I49355d56834de3893a9a244793b39f662c27f136
2021-03-07Shortcuts.c -- UpdateWilliam Wilgus
Fix returns from shortcuts -- should now run plugins Fix formatting of file names to remove path from browser shortcuts Change-Id: I46e337110d04b84bedcb0c2945d5dd29a1860847
2021-03-07OpenPlugins Allow opx shortcutsWilliam Wilgus
Allow opx shortcuts to be run through the shortcut menu Change-Id: I6597b9485dfb224766c442257c4d9c8ac02eece4
2021-03-07voice: Allow voice prompt volume to be configurableSolomon Peachy
It defaults to 100%, allow it to be dialed back Change-Id: If997fb7d3057472a7fac0be4ae7d1e8fce654c49
2021-03-07build: Make all other language files "depend" on english.langSolomon Peachy
If we update english.lang, we need to re-run genlang on the other language files so any changes are picked up. Change-Id: I7d296b3cc814871e881bdeac2784e64705bde10b
2021-03-06Open_plugins.c fix redWilliam Wilgus
rb->strncasecmp Change-Id: Icb1e6d0db42bd4708d581e80596604fb97578761
2021-03-06Open_Plugins Add FeaturesWilliam Wilgus
Added an entry 'Add' to the main screen to lessen confusion side note: its actually a shortcut back to this plugin with flag '-add' passed as a parameter Change-Id: Ifeb0a1e5be99764b1d25d5a3b0e00f1449ec3d78
2021-03-06usb_hid: add support for Battery StrengthJames Buren
This allows rockbox to report its battery status through the HID Battery Strength method that is available through the Device Controls usage page. Change-Id: Ia7a7dd9b9d476dd9df5a5f5becabc5ae823e9a89
2021-03-05Announce_status plugin bugfix use artist prior to albumartistWilliam Wilgus
give id3->artist higer precedence than id3->albumartist Change-Id: I7f57ea274211673c04bf23458735796b03031a15
2021-03-05updatelang: Handle/flag the bad data that led to english-us breakingSolomon Peachy
Change-Id: Ifffea9557d50ab5a103e13473ebe074ae1aa7b6d
2021-03-05announce_status trackchange bugfixWilliam Wilgus
!Properly remove callback! don't play voice prompt at startup if something is actively playing Change-Id: I237d09c1496bc2bed8433dcdaa1469f3d0f2cb10
2021-03-05English-US language had some issues that caused it to fail.Solomon Peachy
Change-Id: I29d27ccb3b972393b234a0ace3f22d4b6c223a20
2021-03-05OOM on Audio_Reset_BufferWilliam Wilgus
Allow the talk file to be unloaded Change-Id: I7633c213f1bf7135894aed43171ea683e2867954
2021-03-04Talk.c, playlist.c fix bugsWilliam Wilgus
fix bug in talk.c playlist.c only dump voice buffer if we are out of space Change-Id: I75705d755db4193a87e542d062dbdc96b153dbb6
2021-03-04Announce_status plugin make USB plug awareWilliam Wilgus
Announce_status was blocking USB from working it now quits on USB plug Change-Id: I0b7e5e9c1ef118582febd459e706c9b61cf7fe25
2021-03-04Talk Fix outright disable after first clipWilliam Wilgus
Oops Sorry bout that ;P Change-Id: I2618e2565a218dd5640351dfef3b7cc2a64617d4
2021-03-05Talk.c Guard against use after free / failure to load voicefileWilliam Wilgus
load_voicefile_data wasn't checked for success leading to a use after free situation get_clip now checks for valid index_handle before using it Change-Id: Id66dba6dbd6becfc9e0fe922fbc1d0adec1f0393
2021-03-04ata: Make ata_disk_is_active() only special-case powermgmt-less devices.Solomon Peachy
SSDs that respect powermgmt commands should be treated the same, as the powermgmt commands are an important part of ensuring it's safe to shut down. And greatly expand the comment explaining things. Change-Id: Ia52b99fca802f495422b5ee097390a72dbc28f61
2021-03-04Always indicate inactive ata disk if device is solid state or doesn't ↵Christian Soffke
support power management Commit 5462907 made sure that SLEEP commands weren't issued on devices that don't support ATA power management commands (e.g. certain CF->SD converters including several iFlash models). Since Rockbox waits for the disk to become inactive in shutdown_hw(), which won't happen in this case, the OS would previously stall during the shutdown process until a timeout was reached. Change-Id: I03bb05f6f6401bb8f0da5d0b76bd3f07681fdc06
2021-03-04Fix typo in MIPS cache discardAidan MacDonald
Change-Id: I6a06e5f3098324d985bd59322755cd68122ec0bf
2021-03-04mips: Revert to commiting the cache when we're told to discard an unaligned ↵Solomon Peachy
block. The filesystem API often passes in unaligned receive buffers, and some code (eg BMP reader) processes data in-place, leading to data loss when we dropped the cache. (And document exactly what we're doing, so we don't go through this again at $future_date) Change-Id: If47a7f2148a5a1a43777f0bd3be1bdfe8239e91e
2021-03-04rolo: use audio_hard_stop() instead of audio_stop()Solomon Peachy
This kills the audio thread entirely, including voice stuff. Change-Id: Id6fd58a97d5a57285016351bbfd3e843b2f339f2
2021-03-04Check core max allocations for valid handleWilliam Wilgus
fix rolo warnings Change-Id: Ia2c669a5517aec54e5b2c0dc5934c88a4f49f2a9
2021-03-04Clean up places that use #if defined(CPU_ARM | CPU_COLDFIRE | CPU_MIPS)Solomon Peachy
Since that encompasses _all_ of our native targets in a post-archos world, either replace it with #if (CONFIG_PLATFORM & PLATFORM_NATIVE) or delete it altogher as appropriate. Change-Id: I9128a456e850d5c96a9e05806aad3acd923f90c5
2021-03-04ROLO check for OOMWilliam Wilgus
Splqash failure and return on OOM Change-Id: I97b8783ba42545e30a5639e8a751d1e6834aebc8
2021-03-04OOM on playlist_resumeWilliam Wilgus
Discovered on ClipZip but applicable to other LOW MEM targets Back off voice buffer on playlist_resume Change-Id: Ia316c4b7fc1bcb089d3069a13dd7c193edf2ba1e
2021-03-04Third try fixing MIPS cache codeAidan MacDonald
Changing this to be a pure discard operation after discussion on IRC Change-Id: I62955ae7975fdbbfd9eef376476042a36fe3d95a
2021-03-03jz4740: Fix incorrect dcache flush in the USB RX DMA code.Solomon Peachy
Change-Id: I01eff581b16569bda97c55afc7adac897b29e0e3
2021-03-03Really fix the MIPS cache bug this timeAidan MacDonald
In fixing the original bug I tried to optimize discard_dcache_range() to minimize writeback and inadvertently introduced a second bug, which typically ends in a TLB refill panic. It occurs only if the range fits within one cache line, and when both the start and end of the range are not aligned to a cache line. This causes ptr to be incremented and end to be decremented, so ptr > end, and the loop can't terminate. Change-Id: Ibaac072f1369268d3327d534ad08ef9dcee3db65
2021-03-03iPods: Allow using scroll wheel to change volume on QuickScreenChristian Soffke
As suggested by forum user yuuiko Change-Id: Ifb989f9513a9e3c59e4ab0f38c0a8e2675c68dd8
2021-03-03ihifi: use STORAGE_WANTS_ALIGN rather than STORAGE_NEEDS_ALIGNSolomon Peachy
Change-Id: I39284194d19785e92ca641c85b03d31849b85ec9
2021-03-03Fix MIPS cache operations and enable HAVE_CPU_CACHE_ALIGN on MIPSAidan MacDonald
- The range-based cache operations on MIPS were broken and only worked properly when BOTH the address and size were multiples of the cache line size. If this was not the case, the last cache line of the range would not be touched! Fix is to align start/end pointers to cache lines before iterating. - To my knowledge all MIPS processors have a cache, so I enabled HAVE_CPU_CACHE_ALIGN by default. This also allows mmu-mips.c to use the CACHEALIGN_UP/DOWN macros. - Make jz4760/system-target.h define its cache line size properly. Change-Id: I1fcd04a59791daa233b9699f04d5ac1cc6bacee7
2021-03-03Open Plugin -- Make first run show at least one item to userWilliam Wilgus
Open plugin needs the context menu to allow the user to add an item on the first run there are no items and therefore nothing to pop the context menu from Change-Id: I7a78454ff29b20c7b60db44349dd23d500ed887c
2021-03-03Battery Icon, Remove Hardcoded Overall WidthWilliam Wilgus
Icon no longer showed 100% with some fonts Change-Id: I6bb9d47007fa42f91daa5c336f5e9e960140db0f