output/Interface: allow Pause() to throw exception

Coverity discovered that the Pulse plugin could throw exceptions from
Pause(), but that method was marked "noexcept" because its caller was
not designed to catch exceptions.  So instead of avoiding exceptions
(by catching and logging them in each and every implementation), let's
allow them, and do the catch/log game in the MPD core.

1 files changed, 4 insertions, 8 deletions

diff --git a/src/output/plugins/ShoutOutputPlugin.cxx b/src/output/plugins/ShoutOutputPlugin.cxx
index b2aa904b4..70c9fc284 100644
--- a/src/output/plugins/ShoutOutputPlugin.cxx
+++ b/src/output/plugins/ShoutOutputPlugin.cxx
@@ -65,7 +65,7 @@ struct ShoutOutput final : AudioOutput {
 	void SendTag(const Tag &tag) override;
 	size_t Play(const void *chunk, size_t size) override;
 	void Cancel() noexcept override;
-	bool Pause() noexcept override;
+	bool Pause() override;
 
 private:
 	void WritePage();
@@ -378,16 +378,12 @@ ShoutOutput::Play(const void *chunk, size_t size)
 }
 
 bool
-ShoutOutput::Pause() noexcept
+ShoutOutput::Pause()
 {
 	static char silence[1020];
 
-	try {
-		encoder->Write(silence, sizeof(silence));
-		WritePage();
-	} catch (const std::runtime_error &) {
-		return false;
-	}
+	encoder->Write(silence, sizeof(silence));
+	WritePage();
 
 	return true;
 }