diff options
| author | Max Kellermann <max@musicpd.org> | 2018-07-17 21:08:41 +0200 |
|---|---|---|
| committer | Max Kellermann <max@musicpd.org> | 2018-07-17 21:08:41 +0200 |
| commit | 5b192beaa5cb8f007b04bb4c52fc2076c12107c6 (patch) | |
| tree | ea316e7beb98cbf6b6870d0d545d89f77425d0c7 /src/config | |
| parent | ef38330d748742945a781ef520ffd4de2d1f9301 (diff) | |
config/Global: remove ConfigBlock::SetUsed() call, let caller do that
This fixes an old bug which caused the "unused" warnings to be
unreliable; only the first block in the list was marked as being
"used", no matter if it was really used, and the rest was never marked
as "used", suppressing all warnings for them.
Diffstat (limited to 'src/config')
| -rw-r--r-- | src/config/Global.cxx | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/config/Global.cxx b/src/config/Global.cxx index 64f7883a7..2b224c318 100644 --- a/src/config/Global.cxx +++ b/src/config/Global.cxx @@ -83,10 +83,7 @@ config_get_param(ConfigOption option) noexcept const ConfigBlock * config_get_block(ConfigBlockOption option) noexcept { - const auto *block = config_data.blocks[unsigned(option)]; - if (block != nullptr) - block->SetUsed(); - return block; + return config_data.blocks[unsigned(option)]; } const ConfigBlock * |