summaryrefslogtreecommitdiff
path: root/src/MusicBuffer.cxx
diff options
context:
space:
mode:
authorMax Kellermann <max@musicpd.org>2018-09-23 15:26:42 +0200
committerMax Kellermann <max@musicpd.org>2018-09-23 15:46:29 +0200
commit5b2374b9495bb9da4b07d03328c1ecac204af8d4 (patch)
treeb6087f3627300322063d18f0c95d2b1ab72be21f /src/MusicBuffer.cxx
parentc1600bcf3d5af915a2c4d999d92d9418c5058f65 (diff)
player/Thread: calculate `buffered_before_play` based on a fixed duration
Previously, there was the setting `buffered_before_play` which specified a percentage of the audio buffer, defaulting to `10%`. That was working well enough for quite some time, until high-quality audio formats became common. At 44.1 kHz, 16 bit stereo, MPD collected 2.3 seconds worth of data in the buffer before starting playback. With the same default settings and 192 kHz, 24 bit stereo, that was only 0.27 seconds. Making this depend on the byte size only leads to high latency at low quality, and too little data at high quality. The natural choice would be to use a duration instead of a byte size, which should give the same good experience with all audio formats. Since the `buffered_before_play` configuration setting was not understood well by users and caused more harm than good, this commit deprecates it. It has now no effect.
Diffstat (limited to 'src/MusicBuffer.cxx')
0 files changed, 0 insertions, 0 deletions