mikmod: call MikMod_Exit() only in the finish() method

Hi -
independently of libmikmod's other problems - there seems
to be a problem in mpd's wrapper: MikMod_Exit() is called
after the first file is decoded, which frees some ressources
within the mikmod library. An attempt to play a second file
leads to a crash. The appended patch fixes this for me.
(I don't know what the "dup" entry is good for - someone
who knows should review that too.)
best regards
Matthias

[mk: removed 3 more MikMod_Exit() invocations]

2 files changed, 1 insertions, 6 deletions

diff --git a/NEWS b/NEWS
index 78f4aef18..9fb2c0e3f 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,7 @@ ver 0.14.2 (2009/??/??)
 * decoders:
   - ffmpeg: added support for the tags comment, genre, year
   - wavpack: pass NULL if the .wvc file fails to open
+  - mikmod: call MikMod_Exit() only in the finish() method
 * audio outputs:
   - jack: allocate ring buffers before connecting
   - jack: clear "shutdown" flag on reconnect
diff --git a/src/decoder/mod_plugin.c b/src/decoder/mod_plugin.c
index a391b2c77..a95f5345c 100644
--- a/src/decoder/mod_plugin.c
+++ b/src/decoder/mod_plugin.c
@@ -172,7 +172,6 @@ mod_decode(struct decoder *decoder, const char *path)
 
 	if (!(data = mod_open(path))) {
 		ERROR("failed to open mod: %s\n", path);
-		MikMod_Exit();
 		return;
 	}
 
@@ -195,8 +194,6 @@ mod_decode(struct decoder *decoder, const char *path)
 	}
 
 	mod_close(data);
-
-	MikMod_Exit();
 }
 
 static struct tag *modTagDup(const char *file)
@@ -212,7 +209,6 @@ static struct tag *modTagDup(const char *file)
 
 	if (moduleHandle == NULL) {
 		DEBUG("modTagDup: Failed to open file: %s\n", file);
-		MikMod_Exit();
 		return NULL;
 
 	}
@@ -228,8 +224,6 @@ static struct tag *modTagDup(const char *file)
 	if (title)
 		tag_add_item(ret, TAG_ITEM_TITLE, title);
 
-	MikMod_Exit();
-
 	return ret;
 }