summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Kellermann <max@musicpd.org>2020-09-07 20:46:53 +0200
committerMax Kellermann <max@musicpd.org>2020-09-07 20:52:37 +0200
commit979a7a1dccafe86eb253983252e293bb2493fd62 (patch)
tree385c86dcbbc14c3fd6ea717998b85694b8c21416
parent962cf32ba7b956733cc1ddb6d9ab707cfc577c02 (diff)
test/run_input: add option --chunk-size
-rw-r--r--test/run_input.cxx33
1 files changed, 29 insertions, 4 deletions
diff --git a/test/run_input.cxx b/test/run_input.cxx
index 63e5f2ab7..9af34e8d2 100644
--- a/test/run_input.cxx
+++ b/test/run_input.cxx
@@ -49,11 +49,15 @@
#include <unistd.h>
#include <stdlib.h>
+static constexpr std::size_t MAX_CHUNK_SIZE = 16384;
+
struct CommandLine {
const char *uri = nullptr;
FromNarrowPath config_path;
+ std::size_t chunk_size = MAX_CHUNK_SIZE;
+
bool verbose = false;
bool scan = false;
@@ -63,14 +67,27 @@ enum Option {
OPTION_CONFIG,
OPTION_VERBOSE,
OPTION_SCAN,
+ OPTION_CHUNK_SIZE,
};
static constexpr OptionDef option_defs[] = {
{"config", 0, true, "Load a MPD configuration file"},
{"verbose", 'v', false, "Verbose logging"},
{"scan", 0, false, "Scan tags instead of reading raw data"},
+ {"chunk-size", 0, true, "Read this number of bytes at a time"},
};
+static std::size_t
+ParseSize(const char *s)
+{
+ char *endptr;
+ std::size_t value = std::strtoul(s, &endptr, 10);
+ if (endptr == s)
+ throw std::runtime_error("Failed to parse integer");
+
+ return value;
+}
+
static CommandLine
ParseCommandLine(int argc, char **argv)
{
@@ -90,6 +107,12 @@ ParseCommandLine(int argc, char **argv)
case OPTION_SCAN:
c.scan = true;
break;
+
+ case OPTION_CHUNK_SIZE:
+ c.chunk_size = ParseSize(o.value);
+ if (c.chunk_size <= 0 || c.chunk_size > MAX_CHUNK_SIZE)
+ throw std::runtime_error("Invalid chunk size");
+ break;
}
}
@@ -130,7 +153,7 @@ tag_save(FILE *file, const Tag &tag)
}
static int
-dump_input_stream(InputStream &is, FileDescriptor out)
+dump_input_stream(InputStream &is, FileDescriptor out, size_t chunk_size)
{
const std::lock_guard<Mutex> protect(is.mutex);
@@ -150,8 +173,9 @@ dump_input_stream(InputStream &is, FileDescriptor out)
}
}
- char buffer[4096];
- size_t num_read = is.Read(buffer, sizeof(buffer));
+ char buffer[MAX_CHUNK_SIZE];
+ assert(chunk_size <= sizeof(buffer));
+ size_t num_read = is.Read(buffer, chunk_size);
if (num_read == 0)
break;
@@ -232,7 +256,8 @@ try {
Mutex mutex;
auto is = InputStream::OpenReady(c.uri, mutex);
- return dump_input_stream(*is, FileDescriptor(STDOUT_FILENO));
+ return dump_input_stream(*is, FileDescriptor(STDOUT_FILENO),
+ c.chunk_size);
} catch (...) {
PrintException(std::current_exception());
return EXIT_FAILURE;