From 041b67b389fc0118015e5adc62725d89127dcc71 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Thu, 2 Feb 2017 12:12:01 +0000 Subject: staging: rts5208: remove redundant retval status check The retval status checks in the proceeding do loop return out of function ms_read_attritbute_info if there is an error condition, thus we never reach the end of the loop with retval failed status. Therefore, the retval status check at end of the do loop is redundant and can be removed. Detected with CoverityScan, CID#143000 ("Logically dead code") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rts5208/ms.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'drivers/staging/rts5208/ms.c') diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c index 28d56c5d1449..806c12180714 100644 --- a/drivers/staging/rts5208/ms.c +++ b/drivers/staging/rts5208/ms.c @@ -1108,12 +1108,6 @@ static int ms_read_attribute_info(struct rtsx_chip *chip) i++; } while (i < 1024); - if (retval != STATUS_SUCCESS) { - kfree(buf); - rtsx_trace(chip); - return STATUS_FAIL; - } - if ((buf[0] != 0xa5) && (buf[1] != 0xc3)) { /* Signature code is wrong */ kfree(buf); -- cgit v1.2.3