From 6083096d961f3cf754c4da282179053f7b85ac16 Mon Sep 17 00:00:00 2001 From: Julia Lawall Date: Mon, 12 Oct 2015 22:43:15 +0200 Subject: soc: qcom: smd: delete unneeded of_node_put Device node iterators perform an of_node_put on each iteration, so putting an of_node_put before a continue results in a double put. A simplified version of the semantic match that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; iterator i; @@ i(..., child, ...) { ... when != of_node_get(child) * of_node_put(child); ... * continue; } // Signed-off-by: Julia Lawall Signed-off-by: Andy Gross --- drivers/soc/qcom/smd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'drivers/soc/qcom') diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c index ef5fed6ceb21..86b598cff91a 100644 --- a/drivers/soc/qcom/smd.c +++ b/drivers/soc/qcom/smd.c @@ -921,10 +921,8 @@ static struct device_node *qcom_smd_match_channel(struct device_node *edge_node, for_each_available_child_of_node(edge_node, child) { key = "qcom,smd-channels"; ret = of_property_read_string(child, key, &name); - if (ret) { - of_node_put(child); + if (ret) continue; - } if (strcmp(name, channel) == 0) return child; -- cgit v1.2.3