From 6b71f60ca205a02b80e07f930fe1be378568fc92 Mon Sep 17 00:00:00 2001 From: Lee Jones Date: Fri, 12 Mar 2021 09:47:34 +0000 Subject: scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header Fixes the following W=1 kernel build warning(s): drivers/scsi/atp870u.c:623: warning: expecting prototype for atp870u_queuecommand(). Prototype was for atp870u_queuecommand_lck() instead drivers/scsi/atp870u.c:724: warning: Function parameter or member 'dev' not described in 'send_s870' drivers/scsi/atp870u.c:724: warning: Function parameter or member 'c' not described in 'send_s870' drivers/scsi/atp870u.c:724: warning: Excess function parameter 'host' description in 'send_s870' Link: https://lore.kernel.org/r/20210312094738.2207817-27-lee.jones@linaro.org Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Marcelo Tosatti Cc: linux-scsi@vger.kernel.org Signed-off-by: Lee Jones Signed-off-by: Martin K. Petersen --- drivers/scsi/atp870u.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'drivers/scsi') diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index da6ca2b153d8..9d179cd15bb8 100644 --- a/drivers/scsi/atp870u.c +++ b/drivers/scsi/atp870u.c @@ -612,7 +612,7 @@ static irqreturn_t atp870u_intr_handle(int irq, void *dev_id) return IRQ_HANDLED; } /** - * atp870u_queuecommand - Queue SCSI command + * atp870u_queuecommand_lck - Queue SCSI command * @req_p: request block * @done: completion function * @@ -711,16 +711,15 @@ static int atp870u_queuecommand_lck(struct scsi_cmnd *req_p, static DEF_SCSI_QCMD(atp870u_queuecommand) -/** +/* * send_s870 - send a command to the controller - * @host: host * * On entry there is work queued to be done. We move some of that work to the * controller itself. * * Caller holds the host lock. */ -static void send_s870(struct atp_unit *dev,unsigned char c) +static void send_s870(struct atp_unit *dev, unsigned char c) { struct scsi_cmnd *workreq = NULL; unsigned int i;//,k; -- cgit v1.2.3