From 91f6a4afd1227f3806ca310b0a9c101c021ac6c5 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:07:09 +0100 Subject: gpio: 74x174: Include proper headers This driver has no business including or . Cut them and include and which is it they really needs. Signed-off-by: Linus Walleij --- drivers/gpio/gpio-74x164.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c index 6b535ec858cc..3c25f504a784 100644 --- a/drivers/gpio/gpio-74x164.c +++ b/drivers/gpio/gpio-74x164.c @@ -9,12 +9,11 @@ * published by the Free Software Foundation. */ -#include #include #include #include -#include -#include +#include +#include #include #include -- cgit v1.2.3 From 8a3b4f20d9d9157690dae98a5982c3be20ed97d2 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:12:07 +0100 Subject: gpio: adp5520: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-adp5520.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-adp5520.c b/drivers/gpio/gpio-adp5520.c index abf199609546..21452622d954 100644 --- a/drivers/gpio/gpio-adp5520.c +++ b/drivers/gpio/gpio-adp5520.c @@ -12,8 +12,7 @@ #include #include #include - -#include +#include struct adp5520_gpio { struct device *master; -- cgit v1.2.3 From d543668a6174ddc1f0460cce3737e27a39ccd9df Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:14:56 +0100 Subject: gpio: adp5588: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-adp5588.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index e717f8dc3966..3530ccd17e04 100644 --- a/drivers/gpio/gpio-adp5588.c +++ b/drivers/gpio/gpio-adp5588.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include -- cgit v1.2.3 From 40a1f9b2071c30c6f498b8b83fe03f6bd321e436 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:18:34 +0100 Subject: gpio: altera: Include GPIO driver header This is a GPIO driver so it should definately include . We want to get rid of but that will take a bit longer. Signed-off-by: Linus Walleij --- drivers/gpio/gpio-altera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gpio-altera.c index 8e76d390e653..8c3ff6e2366f 100644 --- a/drivers/gpio/gpio-altera.c +++ b/drivers/gpio/gpio-altera.c @@ -18,7 +18,8 @@ #include #include -#include +#include +#include /* For of_mm_gpio_chip */ #include #define ALTERA_GPIO_MAX_NGPIO 32 -- cgit v1.2.3 From 3708c665a778349072a2c49fbc5da40779a5b07a Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:22:49 +0100 Subject: gpio: amd8111: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-amd8111.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c index 30ad7d7c1678..fdcebe59510d 100644 --- a/drivers/gpio/gpio-amd8111.c +++ b/drivers/gpio/gpio-amd8111.c @@ -28,7 +28,7 @@ #include #include #include -#include +#include #include #include -- cgit v1.2.3 From 2e21ec4c40eb9d40d1b2d719fcb40726ae8bf4b2 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:47:48 +0100 Subject: gpio: arizona: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c index d4e6ba0301bc..ba51ea15f379 100644 --- a/drivers/gpio/gpio-arizona.c +++ b/drivers/gpio/gpio-arizona.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include #include -- cgit v1.2.3 From 14ec018e15595d3e5c11160eef3f18c0b9c72e3f Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:52:33 +0100 Subject: gpio: bcm-kona: Include proper header This driver has no business including , it is a driver so include . GPIOF_DIR_IN/GPIOF_DIR_OUT are for consumers and should not be used in drivers to use just 1/0 instead. Signed-off-by: Linus Walleij --- drivers/gpio/gpio-bcm-kona.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index dfcf56ee3c61..f4c793e9a92b 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include @@ -127,7 +127,7 @@ static int bcm_kona_gpio_get_dir(struct gpio_chip *chip, unsigned gpio) u32 val; val = readl(reg_base + GPIO_CONTROL(gpio)) & GPIO_GPCTR0_IOTR_MASK; - return val ? GPIOF_DIR_IN : GPIOF_DIR_OUT; + return !!val; } static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) @@ -144,7 +144,7 @@ static void bcm_kona_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) raw_spin_lock_irqsave(&kona_gpio->lock, flags); /* this function only applies to output pin */ - if (bcm_kona_gpio_get_dir(chip, gpio) == GPIOF_DIR_IN) + if (bcm_kona_gpio_get_dir(chip, gpio) == 1) goto out; reg_offset = value ? GPIO_OUT_SET(bank_id) : GPIO_OUT_CLEAR(bank_id); @@ -170,7 +170,7 @@ static int bcm_kona_gpio_get(struct gpio_chip *chip, unsigned gpio) reg_base = kona_gpio->reg_base; raw_spin_lock_irqsave(&kona_gpio->lock, flags); - if (bcm_kona_gpio_get_dir(chip, gpio) == GPIOF_DIR_IN) + if (bcm_kona_gpio_get_dir(chip, gpio) == 1) reg_offset = GPIO_IN_STATUS(bank_id); else reg_offset = GPIO_OUT_STATUS(bank_id); -- cgit v1.2.3 From e88a2ae2befb98f7c9a3accc18e77f0084d03de6 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sat, 13 Jan 2018 22:56:52 +0100 Subject: gpio: bt8xx: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-bt8xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-bt8xx.c b/drivers/gpio/gpio-bt8xx.c index acefb25e8eca..b8ec75cbd4b5 100644 --- a/drivers/gpio/gpio-bt8xx.c +++ b/drivers/gpio/gpio-bt8xx.c @@ -46,7 +46,7 @@ #include #include #include -#include +#include #include /* Steal the hardware definitions from the bttv driver. */ -- cgit v1.2.3 From 6ba40f875d12a8583a10b1c6996fc87a56ba8bdf Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sun, 14 Jan 2018 01:48:48 +0100 Subject: gpio: crystalcove: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-crystalcove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index b6f0f729656c..58531d8b8c6e 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -18,7 +18,7 @@ #include #include #include -#include +#include #include #include #include -- cgit v1.2.3 From 326a2926c900237ef2c67c3648ed5d64f4c6f090 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sun, 14 Jan 2018 01:56:24 +0100 Subject: gpio: cs5535: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-cs5535.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c index 90278b19aa0e..8814c8f47e57 100644 --- a/drivers/gpio/gpio-cs5535.c +++ b/drivers/gpio/gpio-cs5535.c @@ -12,7 +12,7 @@ #include #include #include -#include +#include #include #include #include -- cgit v1.2.3 From 45e8bd9cdc021f4a11eb50e68ff02058e95e8d86 Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sun, 14 Jan 2018 02:00:10 +0100 Subject: gpio: da905x: Include proper header These drivers has no business including , they are drivers so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-da9052.c | 2 +- drivers/gpio/gpio-da9055.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052.c index dd8977cf3e85..b6d3e997eb26 100644 --- a/drivers/gpio/gpio-da9052.c +++ b/drivers/gpio/gpio-da9052.c @@ -15,7 +15,7 @@ #include #include #include -#include +#include #include #include diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c index 82053b52cba0..2f1b5d23b10c 100644 --- a/drivers/gpio/gpio-da9055.c +++ b/drivers/gpio/gpio-da9055.c @@ -13,7 +13,7 @@ */ #include #include -#include +#include #include #include -- cgit v1.2.3 From 7220c43a4efa4f5107bc1b99410d2b01df1837ed Mon Sep 17 00:00:00 2001 From: Linus Walleij Date: Sun, 14 Jan 2018 02:05:38 +0100 Subject: gpio: davinci: Include proper header This driver has no business including , it is a driver so include . Signed-off-by: Linus Walleij --- drivers/gpio/gpio-davinci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/gpio') diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index f75d8443ecaf..34fc0a167b7c 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -9,7 +9,7 @@ * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. */ -#include +#include #include #include #include -- cgit v1.2.3