From 7aec53acc0504ab2abd73a6051e7b72f48545ceb Mon Sep 17 00:00:00 2001 From: Russell King Date: Sun, 22 Feb 2009 21:00:55 +0000 Subject: [ARM] omap: ensure that failing power domain lookups produce errors Use pr_err() for errors rather than pr_debug(). pr_debug() are compiled away unless -DDEBUG is used. Signed-off-by: Russell King --- arch/arm/mach-omap2/clockdomain.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'arch/arm/mach-omap2') diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-omap2/clockdomain.c index ae0c53abb55a..0e7d501865b6 100644 --- a/arch/arm/mach-omap2/clockdomain.c +++ b/arch/arm/mach-omap2/clockdomain.c @@ -74,14 +74,11 @@ static void _autodep_lookup(struct clkdm_pwrdm_autodep *autodep) pwrdm = pwrdm_lookup(autodep->pwrdm.name); if (!pwrdm) { - pr_debug("clockdomain: _autodep_lookup: powerdomain %s " - "does not exist\n", autodep->pwrdm.name); - WARN_ON(1); + pr_err("clockdomain: autodeps: powerdomain %s does not exist\n", + autodep->pwrdm.name); pwrdm = ERR_PTR(-ENOENT); } autodep->pwrdm.ptr = pwrdm; - - return; } /* @@ -211,8 +208,8 @@ int clkdm_register(struct clockdomain *clkdm) pwrdm = pwrdm_lookup(clkdm->pwrdm.name); if (!pwrdm) { - pr_debug("clockdomain: clkdm_register %s: powerdomain %s " - "does not exist\n", clkdm->name, clkdm->pwrdm.name); + pr_err("clockdomain: %s: powerdomain %s does not exist\n", + clkdm->name, clkdm->pwrdm.name); return -EINVAL; } clkdm->pwrdm.ptr = pwrdm; @@ -222,7 +219,7 @@ int clkdm_register(struct clockdomain *clkdm) if (_clkdm_lookup(clkdm->name)) { ret = -EEXIST; goto cr_unlock; - }; + } list_add(&clkdm->node, &clkdm_list); -- cgit v1.2.3