From 064326c0773af8a0e8bb82d895cceaedc8a51b9e Mon Sep 17 00:00:00 2001 From: Al Viro Date: Sun, 12 Feb 2012 21:06:12 -0500 Subject: clean up the failure exits in cifs_read_super() no need to make that iput() conditional, just take it to the right place... Signed-off-by: Al Viro --- fs/cifs/cifsfs.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index b1fd382d1952..8b7d7ff88792 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -119,7 +119,6 @@ cifs_read_super(struct super_block *sb) if (IS_ERR(inode)) { rc = PTR_ERR(inode); - inode = NULL; goto out_no_root; } @@ -127,6 +126,7 @@ cifs_read_super(struct super_block *sb) if (!sb->s_root) { rc = -ENOMEM; + iput(inode); goto out_no_root; } @@ -147,9 +147,6 @@ cifs_read_super(struct super_block *sb) out_no_root: cERROR(1, "cifs_read_super: get root inode failed"); - if (inode) - iput(inode); - return rc; } -- cgit v1.2.3