Age | Commit message (Collapse) | Author |
|
Rename show_engine_regs show function to engine_regs_show as per the
convention followed. The show function macro DEVICE_ATTR also replaced
by DEVICE_ATTR_RO. Issue reported by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/9c8c0d60cec70b99f55d6e228b7585d47be695c2.1603734679.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Reformat lines that exceed 100 column in length. Issue reported by
checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/c853e015ec460b909a3e2cd529bc0f69093bce3e.1603734679.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Replace bit masking by the BIT macro. This resolves the checkpatch issue
"CHECK: Prefer using the BIT macro"
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/2269298ae71605b47fa43a2ebaee23d0ad4ed5a5.1603295576.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Re-indent code as per the coding style guidelines. The changes improve
code readability. Issue reported by checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/29cf604e69435c1f0ef46397d0d8a1b62f32fa9b.1603295576.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Reformat lines that exceed 100 column in length. Issue reported by
checkpatch script.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Link: https://lore.kernel.org/r/809d142d109b4f0acfcb4fa204bdd03381fc051f.1603295575.git.mh12gx2825@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
There are a couple of duplicated "for" spelling mistakes in dev_err
error messages. Fix these.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200818164654.381588-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
As 3 goto level referring to same common code, those can be
accomodated with a single goto level and renameing it to
unpin_pages. Set the -ERRNO when returning partial mapped
pages in more appropriate place.
When dma_map_sg() failed, the previously allocated memory was
not freed properly. This is corrected now.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Bharath Vedartham <linux.bhar@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1593584264-16982-5-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
In 2019, we introduced pin_user_pages*() and now we are converting
get_user_pages*() to the new API as appropriate. [1] & [2] could
be referred for more information. This is case 2 as per document [1].
[1] Documentation/core-api/pin_user_pages.rst
[2] "Explicit pinning of user-space pages":
https://lwn.net/Articles/807108/
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Bharath Vedartham <linux.bhar@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1593584264-16982-4-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
First, convert set_page_dirty() to set_page_dirty_lock()
Second, there is an interval in there after set_page_dirty() and
before put_page(), in which the device could be running and setting
pages dirty. Moving set_page_dirty_lock() after dma_unmap_sg().
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Suggested-by: John Hubbard <jhubbard@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Bharath Vedartham <linux.bhar@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/1593584264-16982-3-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
There is a bug, when get_user_pages() failed but partially pinned
pages are not unpinned and positive numbers are returned instead of
-ERRNO. Fixed it.
Also, int is more appropriate type for rv. Changed it.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bharath Vedartham <linux.bhar@gmail.com>
Link: https://lore.kernel.org/r/1593584264-16982-2-git-send-email-jrdr.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
If device_create() fails during probing the device, kpc_dma_probe() does
not set the error code and returns 0. This can result in various bad
issues later. The patch sets the error code on the corresponding error
handling path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Link: https://lore.kernel.org/r/20200623082959.14951-1-novikov@ispras.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
This change converts the existing mmap_sem rwsem calls to use the new mmap
locking API instead.
The change is generated using coccinelle with the following rule:
// spatch --sp-file mmap_lock_api.cocci --in-place --include-headers --dir .
@@
expression mm;
@@
(
-init_rwsem
+mmap_init_lock
|
-down_write
+mmap_write_lock
|
-down_write_killable
+mmap_write_lock_killable
|
-down_write_trylock
+mmap_write_trylock
|
-up_write
+mmap_write_unlock
|
-downgrade_write
+mmap_write_downgrade
|
-down_read
+mmap_read_lock
|
-down_read_killable
+mmap_read_lock_killable
|
-down_read_trylock
+mmap_read_trylock
|
-up_read
+mmap_read_unlock
)
-(&mm->mmap_sem)
+(mm)
Signed-off-by: Michel Lespinasse <walken@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Reviewed-by: Laurent Dufour <ldufour@linux.ibm.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Davidlohr Bueso <dbueso@suse.de>
Cc: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Liam Howlett <Liam.Howlett@oracle.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ying Han <yinghan@google.com>
Link: http://lkml.kernel.org/r/20200520052908.204642-5-walken@google.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
|
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function. Also
removed var 'rv' since we can use 'err' instead.
Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200506134735.102041-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Cleanup Checkpatch.pl CHECKs about missing
spaces around multiple operators.
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/22025abc8f8f3452c2d886e8faf1fe0532e8bb1d.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Replace kzalloc(sizeof(...) * n, ...) with
kcalloc(n, sizeof(...), ...) since kcalloc is the
preferred API in case of allocating with multiply.
Checkpatch.pl: WARNING:
Prefer kcalloc over kzalloc with multiply.
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/4b8339d1e81e497c3c2f0dad57a9587338ec82b1.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
SPDK-License-Identifier comment should have this form
// SPDX-License-Identifier: <GPL-...>
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/7531e3e3fa7c046e93d2caaa6fa2e76c5c53f04d.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
<linux/io.h> is the preferred header to include
instead of <asm/io.h>.
Checkpatch.pl WARNING:
Use #include <linux/io.h> instead of <asm/io.h>
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/c7a824c3a2ddc5f44bd89504b8c03a328d69f81d.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Remove braces of single statement blocks,
they are not really needed.
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/0a3ec63321dce008fc8dd790f42ef8490135b307.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
kzalloc(sizeof(*var), ...) was the format been used
across the driver, which is the preferred format,
but missed two instances, correct them to match the
coding standards.
Checkpatch.pl CHECK: Prefer kzalloc(sizeof(*var)...)
over kzalloc(sizeof(struct var)...)
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/bbb3adbd20ae89db6a0d3360bc09d22eed778e86.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Comparison to NULL been used across the driver,
remove them and use (!var) instead.
Checkpatch.pl: CHECK:
Comparison to NULL could be written "!desc"... etc
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
Link: https://lore.kernel.org/r/f344afba0a8bb0413941a63678688435f04a96b4.1585143581.git.jane.pnx9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
In a recent change to the SPI subsystem in commit <bebcfd272df6>
("spi: introduce `delay` field for `spi_transfer` +
spi_transfer_delay_exec()"), a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.
The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).
Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Link: https://lore.kernel.org/r/20200304073746.19664-1-sergiu.cuciurean@analog.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
This function should not allow negative values of "wr_val". If
negatives are allowed then capping the upper bound at 7 is
meaningless. Let's make it unsigned.
Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200224103325.hrxdnaeqsthplu42@kili.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
Pull staging and IIO updates from Greg KH:
"Here is the big staging/iio driver patches for 5.6-rc1
Included in here are:
- lots of new IIO drivers and updates for that subsystem
- the usual huge quantity of minor cleanups for staging drivers
- removal of the following staging drivers:
- isdn/avm
- isdn/gigaset
- isdn/hysdn
- octeon-usb
- octeon ethernet
Overall we deleted far more lines than we added, removing over 40k of
old and obsolete driver code.
All of these changes have been in linux-next for a while with no
reported issues"
* tag 'staging-5.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (353 commits)
staging: most: usb: check for NULL device
staging: next: configfs: fix release link
staging: most: core: fix logging messages
staging: most: core: remove container struct
staging: most: remove struct device core driver
staging: most: core: drop device reference
staging: most: remove device from interface structure
staging: comedi: drivers: fix spelling mistake "to" -> "too"
staging: exfat: remove fs_func struct.
staging: wilc1000: avoid mutex unlock without lock in wilc_wlan_handle_txq()
staging: wilc1000: return zero on success and non-zero on function failure
staging: axis-fifo: replace spinlock with mutex
staging: wilc1000: remove unused code prior to throughput enhancement in SPI
staging: wilc1000: added 'wilc_' prefix for 'struct assoc_resp' name
staging: wilc1000: move firmware API struct's to separate header file
staging: wilc1000: remove use of infinite loop conditions
staging: kpc2000: rename variables with kpc namespace
staging: vt6656: Remove memory buffer from vnt_download_firmware.
staging: vt6656: Just check NEWRSR_DECRYPTOK for RX_FLAG_DECRYPTED.
staging: vt6656: Use vnt_rx_tail struct for tail variables.
...
|
|
Some namings in kpc2000_i2c are too ambiguous that may causing
confusion to the readers.
Rename some variable, function and struct name to prefix with 'kpc_i2c'
to eliminate confusions.
Signed-off-by: Jerry Lin <wahahab11@gmail.com>
Link: https://lore.kernel.org/r/20200121024620.GA10842@compute1
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Sparse complains about "dubious: x | !y".
This patch adds some macros to make it clear if a flag will be enabled or
not so Sparse stops complaining about dubious code construct.
Signed-off-by: Felipe Cardoso Resende <felipecardoso.fcr@gmail.com>
Link: https://lore.kernel.org/r/20200117004214.GA1800@felipe-pc
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
ioremap has provided non-cached semantics by default since the Linux 2.6
days, so remove the additional ioremap_nocache interface.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
|
|
In kpc_dma_transfer(), the assertion that priv is NULL and priv->ldev
is NULL, are never satisfied. The two callers of the function,
dereference the fields before the function is called. This patch
removes the two BUG_ON calls.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Link: https://lore.kernel.org/r/20191219172118.17456-1-pakki001@umn.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Resolved: CHECK: Unnecessary parentheses around table[i]
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
Link: https://lore.kernel.org/r/20191029091638.16101-4-chandra627@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
Link: https://lore.kernel.org/r/20191029091638.16101-3-chandra627@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Resolved: ERROR: else should follow close brace '}'
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
Link: https://lore.kernel.org/r/20191029091638.16101-2-chandra627@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl
Signed-off-by: Chandra Annamaneni <chandra627@gmail.com>
Link: https://lore.kernel.org/r/20191029091638.16101-1-chandra627@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Remove some commented out code.
Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/c101a2ff94b3d5dcd467407bfa083679f3bbc612.1572293975.git.jamal.k.shareef@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Fix lines over 80 characters warnings.
issue found by checkpatch.
Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
Link: https://lore.kernel.org/r/8273ad9efccfb2c37ff1e9a25d5ccb26780567aa.1572293975.git.jamal.k.shareef@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Remove unnecessary variable `val` in kp_spi_read_reg() that only holds
the return value from readq().
Issue found by coccinelle using the script:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191009170703.GA2869@wambui
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
It fixed following warning in kpc2000 driver
"constant XXXX is so big it is unsigned long"
Signed-off-by: Harsh Jain <harshjain32@gmail.com>
Link: https://lore.kernel.org/r/20190831115532.2398-1-harshjain32@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
This patch fixes the following sparse warnings:
kpc2000_i2c.c:137: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:137: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:137: got void *
kpc2000_i2c.c:146: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:146: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:146: got void *
kpc2000_i2c.c:147: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:147: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:147: got void *
kpc2000_i2c.c:166: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:166: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:166: got void *
kpc2000_i2c.c:166: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:166: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:166: got void *
kpc2000_i2c.c:168: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:168: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:168: got void *
kpc2000_i2c.c:168: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:168: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:168: got void *
kpc2000_i2c.c:171: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:171: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:171: got void *
kpc2000_i2c.c:174: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:174: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:174: got void *
kpc2000_i2c.c:193: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:193: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:193: got void *
kpc2000_i2c.c:194: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:194: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:194: got void *
kpc2000_i2c.c:214: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:214: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:214: got void *
kpc2000_i2c.c:219: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:219: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:219: got void *
kpc2000_i2c.c:226: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:226: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:226: got void *
kpc2000_i2c.c:238: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:238: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:238: got void *
kpc2000_i2c.c:244: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:244: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:244: got void *
kpc2000_i2c.c:252: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:252: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:252: got void *
kpc2000_i2c.c:257: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:257: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:257: got void *
kpc2000_i2c.c:259: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:259: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:259: got void *
kpc2000_i2c.c:267: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:267: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:267: got void *
kpc2000_i2c.c:273: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:273: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:273: got void *
kpc2000_i2c.c:293: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:293: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:293: got void *
kpc2000_i2c.c:294: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:294: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:294: got void *
kpc2000_i2c.c:309: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:309: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:309: got void *
kpc2000_i2c.c:312: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:312: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:312: got void *
kpc2000_i2c.c:317: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:317: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:317: got void *
kpc2000_i2c.c:324: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:324: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:324: got void *
kpc2000_i2c.c:328: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:328: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:328: got void *
kpc2000_i2c.c:329: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:329: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:329: got void *
kpc2000_i2c.c:330: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:330: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:330: got void *
kpc2000_i2c.c:338: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:338: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:338: got void *
kpc2000_i2c.c:340: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:340: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:340: got void *
kpc2000_i2c.c:342: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:342: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:342: got void *
kpc2000_i2c.c:350: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:350: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:350: got void *
kpc2000_i2c.c:350: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:350: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:350: got void *
kpc2000_i2c.c:351: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:351: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:351: got void *
kpc2000_i2c.c:414: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:414: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:414: got void *
kpc2000_i2c.c:420: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:420: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:420: got void *
kpc2000_i2c.c:422: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:422: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:422: got void *
kpc2000_i2c.c:427: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:427: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:427: got void *
kpc2000_i2c.c:428: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:428: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:428: got void *
kpc2000_i2c.c:430: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:430: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:430: got void *
kpc2000_i2c.c:435: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:435: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:435: got void *
kpc2000_i2c.c:436: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:436: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:436: got void *
kpc2000_i2c.c:438: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:438: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:438: got void *
kpc2000_i2c.c:439: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:439: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:439: got void *
kpc2000_i2c.c:445: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:445: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:445: got void *
kpc2000_i2c.c:446: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:446: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:446: got void *
kpc2000_i2c.c:454: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:454: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:454: got void *
kpc2000_i2c.c:459: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:459: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:459: got void *
kpc2000_i2c.c:461: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:461: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:461: got void *
kpc2000_i2c.c:472: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:472: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:472: got void *
kpc2000_i2c.c:472: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:472: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:472: got void *
kpc2000_i2c.c:475: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:475: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:475: got void *
kpc2000_i2c.c:475: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:475: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:475: got void *
kpc2000_i2c.c:493: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:493: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:493: got void *
kpc2000_i2c.c:493: warning: incorrect type in argument 2
(different address spaces)
kpc2000_i2c.c:493: expected void volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:493: got void *
kpc2000_i2c.c:512: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:512: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:512: got void *
kpc2000_i2c.c:516: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:516: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:516: got void *
kpc2000_i2c.c:516: warning: incorrect type in argument 1
(different address spaces)
kpc2000_i2c.c:516: expected void const volatile [noderef] <asn:2> *addr
kpc2000_i2c.c:516: got void *
Signed-off-by: Eduardo Barretto <edusbarretto@gmail.com>
Link: https://lore.kernel.org/r/20190818183555.7167-1-edusbarretto@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
This reverts commit 8e7cb7352ec85e9e4fbbd7bfe6c5c5a6806f70e3.
Bharath writes:
Could you drop this patch from the staging-next tree? This is
because John is making some changes to the put_user_page*()
functions. He has submitted a patch recently removing
put_user_page_dirty() function which is being used in this
patch. This might break the kernel build if John's patch gets
merged in.
I ll submit a patch once the put_user_page*() apis are fixed.
Reported-by: Bharath Vedartham <linux.bhar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
For pages that were retained via get_user_pages*(), release those pages
via the new put_user_page*() routines, instead of via put_page().
This is part a tree-wide conversion, as described in commit fc1d8e7cca2d
("mm: introduce put_user_page*(), placeholder versions").
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Matt Sickler <Matt.Sickler@daktronics.com>
Cc: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
Link: https://lore.kernel.org/r/1564058658-3551-1-git-send-email-linux.bhar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
A null check before a kfree is redundant, so remove it.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20190711140726.46732-1-yuehaibing@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Fixes checkpatch warning "Comparison to NULL could be written [...]".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Link: https://lore.kernel.org/r/20190704060811.10330-4-simon@nikanor.nu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Fixes checkpatch warning "Comparison to NULL could be written [...]".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Link: https://lore.kernel.org/r/20190704060811.10330-3-simon@nikanor.nu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Fixes checkpatch warning "Comparison to NULL could be written [...]".
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Link: https://lore.kernel.org/r/20190704060811.10330-2-simon@nikanor.nu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Fixes issues found by checkpatch:
- "WARNING: braces {} are not necessary for single statement blocks"
- "WARNING: braces {} are not necessary for any arm of this statement"
Signed-off-by: Simon Sandström <simon@nikanor.nu>
Link: https://lore.kernel.org/r/20190701091819.18528-1-simon@nikanor.nu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
The i2c-dev module is for access to I2C buses from user-space.
Kernel drivers do not care about its presence.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Matt Sickler <Matt.Sickler@daktronics.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
The unconditioned jump will prohibit to ever reach the break-statement.
Deleting this needless statement, the code becomes more understandable.
Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Instead of using the function name hard coded as string, using __func__
and the '%s'-placeholder will always give the current name of the
function. When renaming a function, the debugging-messages won't have to
be rewritten.
Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Replaced 'unsigned' with it's equivalent 'unsigned int' to reduce
confusion while reading the code.
Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Replaced __attribute__((packed)) with __packed. Both ways of attributing
are equivalent, but being shorter, __packed should be preferred.
This refactoring makes the core more readable.
Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
After the declarations in a function, there should be a blank line, so
that the declaration part is visibly separated from the rest.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
To fix some checkpatch-warnings some lines of this module had to be
shortened so that they do not exceed 80 characters per line.
This refactoring makes the code more readable.
Signed-off-by: Fabian Krueger <fabian.krueger@fau.de>
Signed-off-by: Michael Scheiderer <michael.scheiderer@fau.de>
Cc: <linux-kernel@i4.cs.fau.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|