summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-09-14Revert "usb: dwc2: make the scheduler handle excessive NAKs better"Greg Kroah-Hartman
This reverts commit f5717a75db0d4e590c0c050a6f49c6cc0afcec8a, as it wasn't ment to be applied to this branch / tree, it should go in through the USB tree, my fault. Reported-by: Paul Zimmerman <Paul.Zimmerman@synopsys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14staging: lustre: Cleaning up unnecessary use of memset in conjunction with ↵Rickard Strandqvist
strncpy Using memset before strncpy just to ensure a trailing null character is an unnecessary double writing of a string Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14Staging: lustre: lustre: mdc: mdc_request: Removed useless variableTina Johnson
Variable rc is initialised and returned by the function without modifying. Hence replaced rc with it's initial value in the return statement and removed the variable. Signed-off-by: Tina Johnson <tinajohnson.1234@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14staging: lustre: fix pointer whitespace styleSpencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Spencer Baugh <sbaugh@andrew.cmu.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14staging: lustre: fix function definition styleSpencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: open brace '{' following function declarations go on the next line Signed-off-by: Spencer Baugh <sbaugh@andrew.cmu.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14staging: lustre: Fix address space mismatch in ksocknal_recv_iov()Artemiy Volkov
This patch fixes the following sparse warnings: drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:51: warning: cast removes address space of expression drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:39: warning: incorrect type in assignment (different address spaces) drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:39: expected void [noderef] <asn:1>*iov_base drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:39: got void *<noident> by simplifying an expression containing non-__user-attributed type names. Signed-off-by: Artemiy Volkov <artemiyv@acm.org> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14drivers: staging: lustre: Cleanup src/dst comparisons in obdo_cmp_md()Greg Donald
Cleanup obdo_cmp_md() src/dst comparisons using bitwise OR assignments Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Donald <gdonald@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-14usb: dwc2: make the scheduler handle excessive NAKs betterNick Hudson
I'm seeing problems with a d-link dwcl-g122 wifi dongle that someone sent me. There are reports of other wifi dongles with the same/similar problem. The devices appear to be NAKing to the point of confusing the dwc2 driver completely. The attached patch helps with my d-link dwl-g122 - it's adapted from the Raspberry Pi dwc_otg driver, which is a modified version of the Synopsys vendor driver. The error recovery is still valid after the patch, I think. Cc: Dom Cobley <popcornmix@gmail.com> Signed-off-by: Nick Hudson <skrll@netbsd.org> Signed-off-by: Paul Zimmerman <paulz@synopsys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: vt6655: Remove unnecessary condition around includeTobias Klauser
ethtool (and SIOCETHTOOL in particular) is part of Linux since the pre-git era, it thus makes no sense no sense to make the include of linux/ethtool.h conditional. Also remove the unused define DEVICE_ETHTOOL_IOCTL_SUPPORT. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: vt6655: Use net_device_stats from struct net_deviceTobias Klauser
Instead of using an own copy of struct net_device_stats in struct vnt_private, use stats from struct net_device. Also remove the thus unnecessary device_get_stats(), as it would now just return netdev->stats, which is the default in dev_get_stats(). Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: vt6655: Remove unused member from struct vnt_privateTobias Klauser
The pci_state member of struct vnt_private is used nowhere in the code, so remove it. Supposedly it was used to save the PCI configuration space which is now done using pci_save_state(). Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging:rtl8188eu: Fix sparse warning cast to restricted __le16Tobenna P. Igwe
This patch fixes the following sparse warnings: CHECK drivers/staging/rtl8188eu/hal/fw.c drivers/staging/rtl8188eu/hal/fw.c:219:13: warning: cast to restricted __le16 drivers/staging/rtl8188eu/hal/fw.c:219:13: warning: cast to restricted __le16 drivers/staging/rtl8188eu/hal/fw.c:219:13: warning: cast to restricted __le16 drivers/staging/rtl8188eu/hal/fw.c:219:13: warning: cast to restricted __le16 by changing the signature from 'u16' to '__le16'. Signed-off-by: Tobenna P. Igwe <ptigwe@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: emxx_udc: fix style warnings: const strings should be const charVincenzo Scotti
Signed-off-by: Vincenzo Scotti <vinc94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: emxx_udc: fix style warnings: return in void functionsVincenzo Scotti
Signed-off-by: Vincenzo Scotti <vinc94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: emxx_udc: fix style warnings: blank line after declarationsVincenzo Scotti
Signed-off-by: Vincenzo Scotti <vinc94@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: speakup: fix missing blank lines after declarationsDomagoj Trsan
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: speakup: fix line indentationsDomagoj Trsan
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: speakup: fix redundant return in void functionsDomagoj Trsan
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: speakup: fix warnings: line over 80 charactersDomagoj Trsan
Signed-off-by: Domagoj Trsan <domagoj.trsan@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: unisys: uislib: uislib.c: sparse warning of context imbalanceSudip Mukherjee
fixed sparse warning : context imbalance in 'resume_device' unexpected unlock this patch will generate warning from checkpatch for lines over 80 character , but since those are user-visible strings so it was not modified. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Benjamin Romer <benjamin.romer@unisys.com> Tested-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11Staging: octeon-hcd: removed dummy labelNitin Kuppelur
This is a patch to the octeon-hcd.c file that fixes removes dummy label i.e. label followed by return of void function Signed-off-by: Nitin Kuppelur <nitinkuppelur@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging:r8190_rtl8256: coding style: Fixed commenting styleSanjeev Sharma
This is a patch to the r8190_rtl8256.c file that fixes commenting style Error Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11drivers: staging: rtl8723au: Fix 'code indent should use tabs where ↵Greg Donald
possible' errors Fix checkpatch.pl 'code indent should use tabs where possible' errors Signed-off-by: Greg Donald <gdonald@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: remove lvfs.hJohn L. Hammond
Move the definition of struct lvfs_run_ctxt to the one file that needed it (lustre/include/obd.h). Remove the then unneeded headers lustre/include/lvfs.h and lustre/include/linux/lvfs.h. Signed-off-by: John L. Hammond <john.hammond@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre/libcfs: remove upcall cacheJohn L. Hammond
The upcall cache is unused so remove include/linux/libcfs/lucache.h and lustre/libcfs/upcall_cache.c. Signed-off-by: John L. Hammond <john.hammond@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: remove unused lvfs codeJohn L. Hammond
Remove the unused "lvfs" functions obd_lvfs_fid2dentry(), ll_lookup_one_len(), l_dput(), lustre_rename(), push_ctxt(), and pop_ctxt(). Remove the unused members of struct lvfs_run_ctxt. Signed-off-by: John L. Hammond <john.hammond@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: remove lvfs_linux.hJohn L. Hammond
The definitions in lustre/include/linux/lvfs_linux.h are not used so remove that header. Signed-off-by: John L. Hammond <john.hammond@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: remove portals_compat25.hJames Simmons
Remove include/linux/libcfs/linux/portals_compat25.h. . remove some unused/unnecessary macros such as smp_num_cpus / SIGNAL_MASK_ASSERT etc. . replace some macros with direct kernel API calls such as RECALC_SIGPENDING/CLEAR_SIGPENDING/CURRENT_SECONDS, cfs_wait_event_interruptible/_exclusive etc. Signed-off-by: Liu Xuezhao <xuezhao.liu@emc.com> Signed-off-by: Peng Tao <tao.peng@emc.com> Signed-off-by: James Simmons <uja.ornl@gmail.com> Signed-off-by: John L. Hammond <john.hammond@intel.com> Reviewed-on: http://review.whamcloud.com/4778 Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: Keith Mannthey <keith.mannthey@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: remove linux/lustre_common.hJohn L. Hammond
Expand the two uses of ll_inode_blksize() and remove the then unnecessary header lustre/include/linux/lustre_common.h. Signed-off-by: John L. Hammond <john.hammond@intel.com> Reviewed-on: http://review.whamcloud.com/11495 Reviewed-by: Bob Glossman <bob.glossman@intel.com> Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre/lvfs: remove the lvfs layerJames Simmons
The lvfs layer is obsolete and unused by Lustre clients. So remove it and integrate the last of the procfs code into the obdclass layer. Signed-off-by: James Simmons <uja.ornl@gmail.com> Signed-off-by: Mikhail Pershin <mike.pershin@intel.com> Signed-off-by: John L. Hammond <john.hammond@intel.com> Reviewed-on: http://review.whamcloud.com/5512 Reviewed-by: Jian Yu <jian.yu@intel.com> Reviewed-by: Bob Glossman <bob.glossman@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: lustre: fix coding style of function's pointerHugues Morisset
Signed-off-by: Hugues Morisset <morisset.hugues@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: lustre: fix inappropriate enums declarations.Hugues Morisset
Signed-off-by: Hugues Morisset <morisset.hugues@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: lustre: fix coding style on long linesHugues Morisset
Signed-off-by: Hugues Morisset <morisset.hugues@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: lustre: lov: expand the GOTO macroJulia Lawall
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier lbl; identifier rc; constant c; @@ - GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ - GOTO(lbl,rc); + rc; + goto lbl; // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: remove unused function is_osp_on_mdtOleg Drokin
This function is no longer used anywhere. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging/lustre: use osc_reply_portal for OUT servicesMikhail Pershin
OUT service is used to server both MDS-MDS updates and MDS-OST therefore services on MDT and OST are set to use the same request and reply portals to be fully unified and able to serve any type of requests. Signed-off-by: Mikhail Pershin <mike.pershin@intel.com> Reviewed-on: http://review.whamcloud.com/8390 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3467 Reviewed-by: wangdi <di.wang@intel.com> Reviewed-by: Fan Yong <fan.yong@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11drivers: staging: lustre: Fix 'code indent should use tabs where possible' ↵Greg Donald
errors Fix checkpatch.pl 'code indent should use tabs where possible' errors Signed-off-by: Greg Donald <gdonald@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11drivers: staging: lustre: Fix "space prohibited after that open parenthesis ↵Greg Donald
'('" errors Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors Signed-off-by: Greg Donald <gdonald@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: adl_pci9118: replace comedi_board() callsIan Abbott
The `comedi_board(dev)` inline function calls just return `dev->board_ptr`. Expand the inline function calls. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: amplc_dio200_common: replace comedi_board() callsIan Abbott
The `comedi_board(dev)` inline function calls just return `dev->board_ptr`. Expand the inline function calls. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: hwdrv_apci3120: remove void function return statementChase Southwood
Returns at the end of void functions are useless. Remove this one. Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Cc: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: hwdrv_apci3120: else is not useful after returnChase Southwood
The statement nested in an else after a return may be brought out one indent level, the else is useless. Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Cc: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: hwdrv_apci3120: add a blank line after declarationsChase Southwood
Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Cc: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: hwdrv_apci3120: clean up commentsChase Southwood
This patch fixes improper comment indentation, removes dead code and obsolete comments, and conforms remaining comments to a consistent kernel commenting style. Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Cc: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: usbduxsigma: prevent "empty acquisition" async commandsH Hartley Sweeten
This driver currently allows a cmd->stop_src == TRIG_COUNT with a cmd->stop_arg of 0 for both the analog input and output async commands. The (*do_cmd) for both subdevices sets up and starts the command without handling the "empty acquisition". This results in the interrupt functions trying to transfer 0 data samples. Validate that the cmd->stop_arg is >= 1 in the (*do_cmdtest) to prevent the "empty acquisition". Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: usbdux: prevent "empty acquisition" async commandsH Hartley Sweeten
This driver currently allows a cmd->stop_src == TRIG_COUNT with a cmd->stop_arg of 0 for both the analog input and output async commands. The (*do_cmd) for both subdevices sets up and starts the command without handling the "empty acquisition". This results in the interrupt functions trying to transfer 0 data samples. Validate that the cmd->stop_arg is >= 1 in the (*do_cmdtest) to prevent the "empty acquisition". Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: s626: fix cmd->stop_arg validation for stop_src == TRIG_COUNTH Hartley Sweeten
The only limit for the stop_arg with a stop_src == TRIG_COUNT is that there is at least 1 scan in order to prevent an empty acquisition. The max test is bogus. Fix the validation. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: s626: 'ai_sample_count' is always 'stop_arg'H Hartley Sweeten
When the cmd->stop_src == TRIG_COUNT, the 'ai_sample_count' is the cmd->stop_arg. For a stop_src == TRIG_NONE the 'ai_sample_count' is currently set to 1 but the driver never actually uses the value. Simplify the 'stop_count' initialization by just setting it to the cmd->stop_arg. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: s626: clarify COMEDI_CB_EOA codeH Hartley Sweeten
The end-of-acquisition only applies when the cmd->stop_src == TRIG_COUNT. Refactor the code in s626_handle_eos_interrupt() that detects the end-of- acquisition to clarify this. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-11staging: comedi: s626: remove 'ai_continuous' from private dataH Hartley Sweeten
This member of the private data is set based on the cmd->stop_src. Just use the cmd->stop_src directly and remove the member. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 13:59:42 +0000