summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-20staging: iio: resolver: use blank line after array declarationEva Rachel Retuya
Add a blank line after array declaration. This clears the checkpatch check: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: resolver: add spaces around operatorsEva Rachel Retuya
Add spaces around operators to improve readability and to address the checkpatch issue: CHECK: spaces preferred around that '/' (ctx:VxV) Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: resolver: align to match open parenthesisEva Rachel Retuya
Use a combination of tabs and spaces to align parameters to its corresponding open parenthesis. Checkpatch found this issue. Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: light: fix multiple assignments in a single lineEva Rachel Retuya
Rewrite the multiple assignments to clear checkpatch check: CHECK: multiple assignments should be avoided Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: light: add space around '*"Eva Rachel Retuya
Address checkpatch check pointing out the lack of space around the operator '*'. Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: light: fix block comments according to kernel coding styleEva Rachel Retuya
Add the trailing */ accordingly to suit the preferred way of placing block comments. Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: light: omit space after a castEva Rachel Retuya
Remove the unneeded space as pointed out by checkpatch: CHECK: No space is necessary after a cast Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: light: indent to match open parenthesisEva Rachel Retuya
Indent the parameters to match open parenthesis as suggested by checkpatch. Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: accel: Remove unnecessary else after goto in if blockJanani Ravichandran
This patch removes the unnecessary else following an if block with a goto statement. Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Acked-by: Daniel Baluta <daniel.baluta@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: iio: adc: Remove unnecessary test from if conditionsAmitoj Kaur Chawla
Remove unnecessary test condition on ret variable which has been previously tested and returns its value if the value is non zero. This fixes the following smatch warnings: drivers/staging/iio/adc/ad7816.c:299 ad7816_set_oti() warn: we tested 'ret' before and it was 'false' drivers/staging/iio/adc/ad7816.c:306 ad7816_set_oti() warn: we tested 'ret' before and it was 'false' Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by: Daniel Baluta <daniel.baluta@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20Staging: wilc1000: Remove and rename struct typedefs from .c filesBhumika Goyal
Using typedef for a structure type is not suggested in Linux kernel coding style guidelines. So remove typedefs from structures wilc_sdio_t, wilc_spi_t and wilc_mac_cfg_t. Also remove '_t' suffix from the struct names by hand. The following semantic patch detects cases: @tn1@ type td; @@ typedef struct { ... } td; @script:python tf@ td << tn1.td; tdres; @@ coccinelle.tdres = td; @@ type tn1.td; identifier tf.tdres; @@ -typedef struct + tdres { ... } -td ; @@ type tn1.td; identifier tf.tdres; @@ -td + struct tdres Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20Staging: wilc1000: Remove unused function WILC_WFI_update_statsBhumika Goyal
This patch removes the function WILC_WFI_update_stats as it is not used anywhere in the kernel. Also remove its declaration from the header file. Grepped to find the occurences. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20Staging: lustre: lnet: Remove and rename struct typedef lstcon_session_tBhumika Goyal
This patch gets rid of struct typedef lstcon_session_t as it is not suggested to use typdefs for structure types. Also drop '_t' from the name. Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: lustre: Replace __attribute__((packed)) with __packedAmitoj Kaur Chawla
This patch fixes the following checkpatch.pl warning: "WARNING: __packed is preferred over __attribute__((packed))". Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: lustre: lustre: Remove unneeded else after gotoJanani Ravichandran
Remove unnecessary else following an if block with a goto statement. Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: lustre: lustre: Remove unnecessary else after returnJanani Ravichandran
Else is unnecessary when there is a return statement in the corresponding if block. Coccinelle patch used: @rule1@ expression e1; @@ if (e1) { ... return ...; } - else{ ... - } @rule2@ expression e2; statement s1; @@ if(e2) { ... return ...; } - else s1 Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20Staging: lustre: lov: Pull assignments out of function callBhumika Goyal
Assignments in function call arguments are undesirable. So pull such assignments out before function call. Made a coccinelle script to detect such cases: @@ expression fn,b,d; @@ * fn(...,d=b,...); Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: lustre: osc: osc_request: Declare local function and structure as ↵Amitoj Kaur Chawla
static Declare osc_cleanup() function and osc_obd_ops structure as static since they are defined and called only in this file. Removed osc_cleanup() function prototype since it wasn't required. This fixes the following sparse warnings: drivers/staging/lustre/lustre/osc/osc_request.c:3210:5: warning: symbol 'osc_cleanup' was not declared. Should it be static? drivers/staging/lustre/lustre/osc/osc_request.c:3259:16: warning: symbol 'osc_obd_ops' was not declared. Should it be static? Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: lustre: obdclass: obd_mount: Declare function as staticAmitoj Kaur Chawla
Declare lustre_mount() function static since it is defined and called in this file only. This fixes the following sparse warning: drivers/staging/lustre/lustre/obdclass/obd_mount.c:1169:15: warning: symbol 'lustre_mount' was not declared. Should it be static? Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging: lustre: Fixed the parenthesisShalin Mehta
The parentehsis are fixed in the macro for the ldlm lock to set and clear the flags. Signed-off-by: Shalin Mehta <shalinmehta85@gmail.com> Acked-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre: Convert cfs_str2num_check to use kstrtoulOleg Drokin
simple_strtoul is obsolete Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre: Convert cfs_trace_daemon_command to use kstrtoulOleg Drokin
simple_strtoul is obsolete Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre: Remove space after cast in cfs_crypto_hash_final()Oleg Drokin
This is against kernel-code style. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Get rid of multiple assignmentsOleg Drokin
They make checkpatch unhappy, and I guess overall might confuse people too. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre: Get rid of cfs_trace_buf_type_t typedefOleg Drokin
Replace it with enum cfs_trace_buf_type Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre: Update cfs_cpu_notify switch statement with a commentOleg Drokin
We do really mean to fall through to that default case statement from all previous ones, so add a comment to unconfuse verious tools Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Remove empty lines after/before bracesOleg Drokin
No need for an empty line after opening curvy brace and no need for an empty line before the closing one too. Remove them. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Remove useless returns in void functionsOleg Drokin
Return at the end of a void function does not serve any particular purpose and makes checkpatch unhappy, so eliminate them. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Update comments style to match kernelOleg Drokin
checkpatch complains that the trailing */ on the multiline comments should be on it's own line. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Move private tracefile structs out of headerOleg Drokin
the struct page_collection, struct cfs_trace_page and struct tracefiled_ctl are only used by tracefile.c, so move them there. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Remove unused cfs_tcd_owns_tage() functionOleg Drokin
Does not appear to be used anywhere. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Shortened too long linesOleg Drokin
Lines that were too long for not good reason were shortened in this patch. Found with checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Remove stray spaces after function nameOleg Drokin
Problem highlighted by checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: reformat cfs_tcd_for_each_type_lock defineOleg Drokin
Avoid using leading spaces that make checkpatch unhappy. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: style change to add missing spaces for operationsOleg Drokin
This fixes checkpatch messages about "spaces preferred around that '-' (ctx:VxV)" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Move EXPORT_SYMBOLs under function/variableOleg Drokin
Found with checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/libcfs: Cleanup: parenthesis alignment adjustmentsOleg Drokin
Adjust alignment of argments that were pushed to next lines to conform to kernel code style. Found with checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre: Remove the "write to FSF to get a copy of GPL" wordingOleg Drokin
Checkpatch highlighted that some of our Lustre files carry this extra paragraph and indeed it does seem somewhat redundant, so remove it. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/ptlrpc: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/osc: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/obdecho: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/obdclass: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/mgc: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/mdc: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/include: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/lclient: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/fld: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/fid: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/lmv: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-20staging/lustre/ldlm: Adjust NULL comparison codestyleOleg Drokin
All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-20 13:59:20 +0000