summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-11-26staging: rtl8192e: add missing tasklet_kill on remove pathDevendra Naga
The powersave tasklet is created in rtllib_softmac_init and it is not removed while unloading the module. Cc: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: wlan-ng: prism2fw: fixed code style issueAede Symen Hoekstra
Fixed checkpatch.pl warning message: line over 80 characters Signed-off-by: Aede Symen Hoekstra <aedesymen@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26Drivers:staging:dgap: Added a blank line after declarationAnjana Sasindran
This patch fixes the checkpatch.pl warning: WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran <anjanasasindran123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: olpc_dcon: Deletion of a check before backlight_device_unregister()Markus Elfring
The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: ozwpan: Deletion of unnecessary checks before the function call ↵Markus Elfring
"oz_free_urb_link" The oz_free_urb_link() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: fwserial: remove multiple blank linesLe Tan
This patch fixes the multiple blank lines issue complained by checkpatch.pl by removing useless blank lines. Signed-off-by: Le Tan <tamlokveer@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: panel: Use better names for two defined valuesMariusz Gorski
Give DEFAULT_KEYPAD and DEFAULT_LCD defines better names, so that their meaning is emphasized. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: panel: Reorder module parameter declarationsMariusz Gorski
Change the order of the module parameter declarations so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: panel: Reorder DEFAULT_* values redefinesMariusz Gorski
Change the order of the DEFAULT_* values redefines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: panel: Reorder initial DEFAULT_* definesMariusz Gorski
Change the order of the initial DEFAULT_* defines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> Acked-By: Willy Tarreau <w@1wt.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: octeon-usb: eliminate cvmx_dprintf() usageAaro Koskinen
Eliminate cvmx_dprintf() usage and use dev_err() instead. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: octeon-usb: move helper functionsAaro Koskinen
Move helper functions to make them visible to all functions. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: octeon-ethernet: drop multiple NAPI instancesAaro Koskinen
Octeon Ethernet driver is currently trying to wake up multiple CPU cores for parallel NAPI processing when needed, to cope with the fact that all network interfaces are handled through the same receive queue processed by a single core/interrupt (see http://marc.info/?l=linux-kernel&m=137209784914565&w=2). This partially overlaps with generic RPS functionality. Commit a6a39a7fcff5 ("staging: octeon-ethernet: disable load balance for receiving packet when CONFIG_RPS is enabled") already disabled this when RPS is enabled. Let's delete this code altogether as it has issues like packet reordering and potential problems with CPU offlining/onlining. Tested on EdgeRouter Lite. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Acked-By: David Daney <david.daney@cavium.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: android: ion: Deletion of unnecessary checks before two function callsMarkus Elfring
The functions ion_heap_destroy() and vfree() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c clean up function commentsMalcolm Priestley
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c Removed unneeded commentsMalcolm Priestley
Type and function that are not present comments Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c: Remove author commentsMalcolm Priestley
Moving names to file header comment Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c camel calse vnt_private rename pDevice to privMalcolm Priestley
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: IFRFbWriteEmbedded replace __iomem with vnt_privateMalcolm Priestley
Fixing callers to vnt_private Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf remove __iomem *dwIoBase from functionsMalcolm Priestley
replacing with vnt_private and removing dereferencing from callers Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: card.c move __iomem into functions.Malcolm Priestley
Removing dereferencing from callers Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: card Remove function vUpdateIFSMalcolm Priestley
vUpdateIFS does the same operations of CARDbSetPhyParameter there is not need to call this function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: always keep abyCurrentNetAddr aligned to 2Malcolm Priestley
Because the driver now uses ether_addr_copy the alignment of this variable must be maintained at 2. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: change typedef enum _VIA_PKT_TYPE to macroMalcolm Priestley
Replacing for u8 type and removing cast for byBBType. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: replace typedef enum _VIA_BB_TYPE with macrosMalcolm Priestley
Replacing type with u8 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: CARDbSetPhyParameter remove unused parametersMalcolm Priestley
wCapInfo byERPField, *pvSupportRateIEs *pvExtSupportRateIEs Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: dead code remove typedef enum _CARD_PHY_TYPEMalcolm Priestley
Removing unused eCurrentPHYType Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: s_vCalculateOFDMRParameter use bb_type for CARD_PHY_TYPEMalcolm Priestley
using u8 for bb_type and replacing PHY_TYPE_11A with BB_TYPE_11A Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: CARDvSetRSPINF us bb_type for CARD_PHY_TYPEMalcolm Priestley
Using u8 for bb_type Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: CARDbSetPhyParameter change CARD_PHY_TYPE to bb_typeMalcolm Priestley
using u8 for bb_type Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: dead code remove CARDbAddBasicRateMalcolm Priestley
we nonlonger set rates in the driver Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: CARDvUpdateBasicTopRate use basic_rates to find top rateMalcolm Priestley
basic_rates should now be used to find it. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Remove space before braces for defined() checkAndreas Ruprecht
checkpatch complains about two places where a space is prohibited before the braces for in "#if defined()" check. This patch removes these warnings. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Remove unnecessary braces at ifsAndreas Ruprecht
checkpatch complains about three places where braces are not necessary. This patch removes the braces. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Remove unnecessary line continuationsAndreas Ruprecht
checkpatch finds two unnecessary line continuations in ldlm_lockd.c which are removed by this patch. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Fix warning about unneeded return statementAndreas Ruprecht
checkpatch complains about an unneeded return statement in the function search_granted_lock(), which is removed by this patch. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Fix initialization of static variablesAndreas Ruprecht
checkpatch complains about static variables being initialized to 0 which is unnecessary. This patch removes the initialization. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Fix indentation errors for switch-caseAndreas Ruprecht
checkpatch complains about two indentation errors where the case statements are on a higher indentation level than the corresponding switch statement. This patch removes these errors. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Fix warning about missing spacesAndreas Ruprecht
checkpatch.pl complains about a number of places where spaces were missing. This patch fixes all of these errors. For better readability, the warning of hitting the 80 character per line limit in line 1349 introduced by this change is ignored deliberately. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Fix overlong linesAndreas Ruprecht
checkpatch complains about a number of lines which are over the 80 character line limit. This patch changes most of them to comply, the few remaining lines with warnings are not changed for readability reasons. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: lustre: ldlm: Add missing newlines after declarationsAndreas Ruprecht
checkpatch.pl complains about a number of missing newlines after declarations. This patch gets rid of these warnings. Signed-off-by: Andreas Ruprecht <rupran@einserver.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging:rtl8723au: fix sparse warning: incorrect type in assignmentKinka Huang
Signed-off-by: Kinka Huang <kinkabrain@gmail.com> Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging:rtl8723au: Fix sparse warning cast to restricted __le16Tobenna P. Igwe
This patch fixes the following sparse warning: drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:343:36: warning: cast to restricted __le16 by using the le16_to_cpus function. Signed-off-by: Tobenna P. Igwe <ptigwe@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: rtl8723au: fix sparse warningAleh Suprunovich
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:747:1: warning: symbol 'rtl8723a_EfusePgPacketRead' was not declared. Should it be static? Function 'rtl8723a_EfusePgPacketRead' seems to be unused in current staging code. Before, it was available as 'static s32 Hal_EfusePgPacketRead', but code that was using it removed, in the same commit as rename and signature change to 'bool rtl8723a_EfusePgPacketRead' has taken place. Signed-off-by: Aleh Suprunovich <br@ahlamon.org> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging:rtl8723au: core: Fix checkpatch warningSanjeev Sharma
This is a patch to the rtw_cmd.c file that fixes following Warning by introducing temporary structure. WARNING: line over 80 characters Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging:rtl8723au: core: Added missing space reported by checkpatch.Sanjeev Sharma
This is a patch to the rtw_cmd.c file that fixes following Error. ERROR: spaces required around that '>' (ctx:WxV) Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: rtl8723au: Remove sw led handlingJes Sorensen
The rtl8723au relies on hw led support, so no point carrying a large unused sw led infrastructure around. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: rtl8723au: Remove no-op function Hal_InitChannelPlan23a()Jes Sorensen
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: rtl8723au: Remove unused rtl8723a_update_txdesc() and child functionsJes Sorensen
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: rtl8723au: pxmitframe->frame_tag is never set to a value > 8Jes Sorensen
No point of masking out high bits since we never set the value to anything exceeding bits 0-3. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>