summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-06-28staging: comedi (adv_pci1723): coding style, fix whitespace before quoted ↵Matt Billenstein
newline Small fix in adv_pci1723.c for a "whitespace before quoted newline" warning from checkpatch.pl Signed-off-by: Matt Billenstein <matt@vazor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: intel_sst: Fix memory leakAndre Bartke
In case of an error stream_bufs is not freed here. Signed-off-by: Andre Bartke <andre.bartke@gmail.com> Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: altera-stapl: Fix memory leak of altera_init()Peter Huewe
In case kzalloc() fails the second or third time we should free the previous allocated resources. In order to keep one return point and to keep the cleanup code to one place, some reordering was necessary. Also while at it, removed the *sizeof(char) - to quote Linus: "" Also removed the silly "* sizeof(u8)". If that isn't 1, we have way deeper problems than a simple multiplication can fix. """ Reported-by: Andre Bartke <andre.bartke@gmail.com> Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: use videobuf2 framework for drivers/staging/dt3155v4l driverMarin Mitov
This patch transforms drivers/staging/dt3155v4l driver to use videobuf2 framework. Tested and works with "xawtv -f". Either streaming API or read method should be selected during kernel configuration. If both are selected into the driver (not possible without another patching), either due to my misunderstanding or problems in xawtv (or both), I get kernel panic after some start/stop of xawtv (not strictly reproducible). Signed-off-by: Marin Mitov <mitov@issp.bas.bg> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: synaptics: Implement error handling for rmi4 touch regulatorNaveen Kumar Gaddipati
Implement the error handling for regulator in synaptics rmi4 touch screen Signed-off-by: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: sep: fix function name in kernel-docJonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: sep: clean up some checkpatch.pl issuesTim Retout
Use consistent spacing in array indexing, and a whitespace fix. Signed-off-by: Tim Retout <tim@retout.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: Convert vmalloc/memset to vzallocJoe Perches
Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: tty: fixed some whitespace coding style issuesRalf Thielow
Fixed some whitespace coding style issues. Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: comedi: fixed a declaration coding style issueRalf Thielow
Fixed a declaration coding style issue. Signed-off-by: Ralf Thielow <ralf.thielow@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28Remove unneeded version.h include from drivers/staging/mei/main.cJesper Juhl
It was pointed out by 'make versioncheck' that include of linux/version.h is not needed in drivers/staging/mei/main.c . This patch removes it. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: fix possible usage of uninitialized variableTomas Winkler
Fix warning: reported in http://marc.info/?l=linux-kernel&m=130812960402606&w=2 drivers/staging/mei/interrupt.c: warning: 'buffer' may be used uninitialized in this function: => 198 It is a real issue and wrong path in execution is taken when list is empty or (cl && _mei_irq_thread_state_ok(cl, mei_hdr)) evaluates to false Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: io_list functions revampTomas Winkler
1. remove list used for loop. There were only 2 loops used in non time critical places so we can safely unroll them 2. normalize functions names operating on io_list to mei_io_list_<op> 3. rename mei_fe_same_id to mei_cl_cmp_id used for comparing list elements containing struct mei_cl 4. group together io_list functions in the header file Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: rename num_mei_me_clients to me_clients_numTomas Winkler
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: mei_dev - kill unused membersTomas Winkler
remove write only/unsed variables mei_dev.write_hang and mei_io_lis.tdevice_extension Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: mei_dev - use type bool instead of intTomas Winkler
use type bool for boolean variables in struct mei_dev this should save some space providing boolean is 8 bits Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: fix mei driver namespaceTomas Winkler
All global functions must start with mei_ to reduce the risk of name colisions Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: mei: mei_dev.h: don't break lines where not needed.Tomas Winkler
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Oren Weil <oren.jer.weil@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28ath6kl: Add PMKSA cache management commandsJouni Malinen
Implement cfg80211_ops set_pmksa, del_pmksa, and flush_pmksa to enable PMKSA caching support. kvalo: backported from ath6kl-cleanup tree Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28ath6kl: testmode supportKalle Valo
Add testmode support for running low level hardware tests. The testmode is enabled by setting testmode module parameter to 1. For now only a simple command passing is supported. More advanced support will be implemented later. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28ath6kl: export firmware version to user spaceKalle Valo
cfg80211 exports wiphy->fw_version to user space via ethtool interface. The obligatory screenshot: $ sudo ethtool -i wlan0 driver: ath6kl_hifdev version: 2.6.39-rc4+ firmware-version: 3:1:1:149 bus-info: mmc0:0001:1 $ Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28Remove unneeded version.h includes from drivers/staging/ath6kl/Jesper Juhl
It was pointed out by 'make versioncheck' that some includes of linux/version.h are not needed in drivers/staging/ath6kl/. This patch removes them. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28ath6kl: cache firmwareKalle Valo
Drivers should not request firmware during resume. Fix ath6kl to cache the firmware instead. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Cc: stable <stable@kernel.org> [3.0] Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28ath6kl: fix crash when interface is closed but scan is ongoingKalle Valo
When ath6kl module was resumed while a scan was ongoing, for example during suspend, the driver would crash in ar6k_cfg80211_scanComplete_event(): [26581.586440] Call Trace: [26581.586440] [<f99ffeda>] ? ar6k_cfg80211_scanComplete_event+0xaa/0xaa [ath6kl] [26581.586440] [<f9a0a020>] wmi_iterate_nodes+0xb/0xd [ath6kl] [26581.586440] [<f99ffe78>] ar6k_cfg80211_scanComplete_event+0x48/0xaa [ath6kl] [26581.586440] [<f9a038ae>] ar6000_close+0x77/0x7e [ath6kl] [26581.586440] [<c139c25d>] __dev_close_many+0x87/0xab [26581.586440] [<c139c30a>] dev_close_many+0x54/0xab [26581.586440] [<c139c437>] rollback_registered_many+0xa5/0x19e [26581.586440] [<c139c595>] rollback_registered+0x23/0x2f [26581.586440] [<c139c5ed>] unregister_netdevice_queue+0x4c/0x69 [26581.586440] [<c139c6b2>] unregister_netdev+0x18/0x1f [26581.586440] [<f9a00d4c>] ar6000_destroy+0xf8/0x115 [ath6kl] [26581.586440] [<f9a0c765>] ar6k_cleanup_module+0x20/0x29 [ath6kl] [26581.586440] [<c1062843>] sys_delete_module+0x181/0x1d9 [26581.586440] [<c105876b>] ? lock_release_holdtime+0x2b/0xcd [26581.586440] [<c10b55dc>] ? sys_munmap+0x3b/0x42 [26581.586440] [<c14a99dc>] ? restore_all+0xf/0xf [26581.586440] [<c14aeb6c>] sysenter_do_call+0x12/0x32 [26581.586440] Code: 89 53 6c 75 07 89 d8 e8 c0 ff ff ff 89 f0 e8 2c f2 a9 c7 5b 5e 5d c3 55 89 e5 57 56 53 89 c3 83 ec 08 89 55 f0 8d 78 04 89 4d ec <8b> b0 b8 00 00 00 46 89 b0 b8 00 00 00 89 f8 e8 ae ed a9 c7 8b Fix the function not to iterate nodes when the scan is aborted. The nodes are already freed when the module is being unloaded. Patch "ath6kl: Fix a kernel panic furing suspend/resume" tried to fix this already but it wasn't enough as a pointer was still used even after the null check. This patch removes the null check entirely as the wmi structure is not accessed anymore during module unload. Also fix a bug where the status was checked as a bitfield with '&' operator. But it's not a bitfield, just a regular (enum like) value. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Cc: stable <stable@kernel.org> [3.0] Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: remove unnecessary codeGreg Dietsche
Compile tested. remove unnecessary code that matches this coccinelle pattern if (...) return ret; return ret; Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu> Acked-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: change wl_cfg80211_suspend corresponding to cfg80211Roland Vossen
Change wl_cfg80211_suspend in fullmac to meet cfg80211 interface update. Signed-off-by: Franky Lin <frankyl@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: fix checkpatch errors in brcmsmac driverArend van Spriel
Several source files in brcmsmac driver have checkpatch errors that have been removed (see below). ERROR: spaces required around that ':' (ctx:VxV) + (u8)NPHY_RSSI_SEL_TSSI_5G:(u8)NPHY_RSSI_SEL_TSSI_2G; -- ERROR: code indent should use tabs where possible + ^Ierr = initvars_table(base, vp, vars, count);$ -- Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: fix checkpatch errors from main.cArend van Spriel
The softmac source file main.c was passed through checkpatch to see what issues against coding style are still present. This patch removes the checkpatch errors listed below. ERROR: trailing whitespace +^Imemcpy(wlc->default_bss->rateset.rates, rs.rates, $ -- ERROR: spaces required around that ':' (ctx:VxV) + pval = arg ? (int *)arg:NULL; -- Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: remove checkpatch errors found in fullmacArend van Spriel
A checkpatch run was done over the complete source files to determine how much coding style issues there are in the driver. This patch fixes the checkpatch errors in fullmac driver brcmfmac listed below. ERROR: do not initialise globals to 0 or NULL +uint dhd_poll = false; -- ERROR: do not use assignment in if condition + if (!ifp && !(ifp = kmalloc(sizeof(dhd_if_t), GFP_ATOMIC))) { -- ERROR: do not use assignment in if condition + if (unlikely(!(wl_cfg80211_dev && \ -- ERROR: do not initialise statics to 0 or NULL + static bool iscan_pass_abort = false; -- Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: replaced wlc_ by brcms_c_, part 2Roland Vossen
Code cleanup. Function renaming. Triggered by feedback comment from John Linville, just like the other function renames that preceded this patch. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: further replaced wlc_ by brcmsmac_c_Roland Vossen
Code cleanup. Renamed functions. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: removed superfluous forward struct declarationsRoland Vossen
Code cleanup. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reported-by: Julian Calaby <julian.calaby@gmail.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: replaced wlc_ by brcms_c_Roland Vossen
Code cleanup. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: replaced bmac acronym by brcms_b_Roland Vossen
Code cleanup. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: Fix for suspend issue in brcmfmac driverSukesh Srikakula
Issue with disconnect at the time of suspend is fixed by properly setting connection status bits maintained by brcmfmac driver. Signed-off-by: Sukesh Srikakula <sukeshs@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: fixed double #include problemRoland Vossen
Code cleanup. Removed one redundant include and reshuffled #include order as to include Linux header files first. Reported-by: julie Sullivan <kernelmail.jms@gmail.com> Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: remove unused fields from struct si_infoArend van Spriel
Two fields were not used in the driver code so they have been removed from struct si_info definition. Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: remove device id parameter from ai_attach()Arend van Spriel
The device id is passed to ai_attach() and subsequent functions without actually being used. It can be removed. Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: remove d11regs_t parameter from wlc_tbtt functionArend van Spriel
The function wlc_tbtt() has variable regs as parameter, but it is not used. Parameter has been removed from the function. Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: remove regs variable from brcms_ioctl functionArend van Spriel
This variable was declared and initialized but never used so it has been removed. Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: remove 'used' keyword from function ai_ispcie()Arend van Spriel
The function ai_ispcie() is a static function that is currently being called from the c sources in the driver. Side-effect of the keyword is that warning will suppressed when this function is no longer used. As there is no assembly code using this function, the keyword is removed. Signed-off-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: Remove flags from wl_is_nonetworkFranky Lin
Remove this debug only variable in fullmace driver to avoid compile warning when BCMDBG is off Signed-off-by: Franky Lin <frankyl@broadcom.com> Reviewed-by: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: #include reductionRoland Vossen
Code cleanup. Number of includes has been reduced by only including what is necessary. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: cleaned brcmu_utils.hRoland Vossen
Code cleanup. Moved softmac specific definitions into brcmsmac/types.h Removed unused definitions. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-28staging: brcm80211: moved typedefs to decrease header file dependenciesRoland Vossen
Code cleanup. Moved the typedefs to brcmsmac/types.h for source files that only require opaque pointer definitions. Next patches will decrease the number of #includes for each file. Signed-off-by: Roland Vossen <rvossen@broadcom.com> Reviewed-by: Arend van Spriel <arend@broadcom.com> Reviewed-by: Franky Lin <frankyl@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-09Merge Linus's tree into staging-nextGreg Kroah-Hartman
This was done to resolve the conflicts that were in a number of files due to changes done upstream with others done in the staging-next branch. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-09Staging: brcm80211: disable drivers for PPC platformsGreg Kroah-Hartman
Right now, bad things happen if you try to build these drivers for the PPC platform as it seems that the code only has been tested and built on the MIPS big endian platform. So disable it on the PPC32 and PPC64 platforms for now, hopefully this will be resolved in the future as I'm sure someone will want to use these chips with that platform someday. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Henry Ptasinski <henryp@broadcom.com> Cc: Brett Rudley <brudley@broadcom.com> Cc: Roland Vossen <rvossen@broadcom.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-06-09Merge branch 'staging-linus' of ↵Linus Torvalds
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6 * 'staging-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6: staging: iio: max517: Fix iio_info changes Staging: mei: fix debug code Staging: cx23885: fix include of altera.h staging: iio: error case memory leak fix staging: ath6kl: Fix a kernel panic during suspend/resume staging: gma500: get control from firmware framebuffer if conflicts staging: gma500: Skip bogus LVDS VBT mode and check for LVDS before adding backlight staging: usbip: bugfix prevent driver unbind staging: iio: industrialio-trigger: set iio_poll_func private_data staging: rts_pstor: use bitwise operator instead of logical one staging: fix ath6kl build when CFG80211 is not enabled staging: brcm80211: fix for 'multiple definition of wl_msg_level' build err staging: fix olpc_dcon build, needs BACKLIGHT_CLASS_DEVICE Staging: remove STAGING_EXCLUDE_BUILD option Staging: altera: move .h file to proper place
2011-06-09Merge branch 'stable/xen-swiotlb.bugfix' of ↵Linus Torvalds
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb-2.6 * 'stable/xen-swiotlb.bugfix' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb-2.6: swiotlb: Export swioltb_nr_tbl and utilize it as appropiate.
2011-06-09Merge branch 'stable/broadcom.ibft-bugfixes' of ↵Linus Torvalds
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft-2.6 * 'stable/broadcom.ibft-bugfixes' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft-2.6: iscsi_ibft: iscsi_ibft_find unused variable i