summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2010-08-31Staging: lirc: fix compiler warningJarod Wilson
On Fri, Aug 13, 2010 at 03:38:40PM +0200, Dan Carpenter wrote: > Speak of left over stuff, it's weird that I didn't notice this before > but gcc complains about an unitialized variable in > imon_incoming_packet(). > > drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’: > drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used > uninitialized in this function > > I don't know how to fix that, but it looks important. Ew. Yeah, that doesn't look so hot like it is right now. The old lirc_imon driver had chunk_num = buf[7], and made much more extensive use of chunk_num. Simply removing chunk_num and using buf[7] should be fine. Signed-off-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: cx25821: call disable_pci_device() if pci_probe() failedKulikov Vasiliy
Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: sm7xx: call disable_pci_device() if pci_probe() failedKulikov Vasiliy
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: rtl8187e: call disable_pci_device() if pci_probe() failedKulikov Vasiliy
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: quickstart: acpi_status is unsignedDan Carpenter
acpi_bus_register_driver() returns an int, not acpi_status. It returns zero on success and negative error codes on failure, but acpi_status is unsigned. We can just use "ret" here. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: ti-st: writing past end of arrayDan Carpenter
In the original source it would write past the end of the array before returning the error code. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: rtl8192e: add curly braces to if statementDan Carpenter
In the original code there was some extra semicolons after the if statement: if (!channel_map[ieee->current_network.channel]); ^^^ >From the indenting it looked like that should be curly braces instead. Also I made some white space changes to stop checkpatch.pl from complaining. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: lirc: remove unneeded variableDan Carpenter
We never use control_req so I removed it. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: spectra: call disable_pci_device() if pci_probe() failedKulikov Vasiliy
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: rtl8187se: call disable_pci_device() if pci_probe() failedKulikov Vasiliy
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: crystalhd: call disable_pci_device() if pci_probe() failedKulikov Vasiliy
Driver should call disable_pci_device() if it returns from pci_probe() with error. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> Acked-by: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: xgifb: use DEFINE_PCI_DEVICE_TABLE() macroJavier Martinez Canillas
Use DEFINE_PCI_DEVICE_TABLE() to make xgifb_pci_table const and marked as __devinitconst Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (cb_pcidas): use PCI_DEVICE() macroJavier Martinez Canillas
This is the first of a patch series that uses PCI_DEVICE() macro for pci table entries on comedi drivers and thus improving readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (cb_pcidda): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (cb_pcidio): user PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (rtd520): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (me4000): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (cb_pcimdas): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (adv_pci_dio): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (adl_pci6208): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (adl_pci9118): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (skel): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (adv_pci1710): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (adv_pci1723): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (cb_pcidas64): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: comedi (dt3000): use PCI_DEVICE() macroJavier Martinez Canillas
Use PCI_DEVICE() macro for pci table entries on comedi driver and thus improves readability. Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: RT2860: Fixed the spacing error in oid.hNeil Munro
Fixed the single spacing error in oid.h. Signed-off-by: Neil Munro <neilmunro@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: RT2860: Fixed both coding style errors in eeprom.hNeil Munro
Fixed two coding style errors in the form of pointer style issues in eeprom.h. Signed-off-by: Neil Munro <neilmunro@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: otus: fix compile warning and some style issuesRoberto Rodriguez Alkala
In today linux-next I got a compile warning in staging/otus driver. This patch solves the issue and also improves the coding style. Signed-off-by: Roberto Rodriguez Alcala <rralcala@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: slicoss: Remove explicit arch dependenciesDenis Kirjanov
Remove explicit arch dependencies Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio: hmc5843 change ABI to comply with documentationManuel Stahl
this one completes my last patch set to compile fine for all drivers. Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Datta, Shubhrajyoti <shubhrajyoti@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio sync scale unitsManuel Stahl
g -> ms/s^2 deg -> rad deg/s -> rad/s some temperatures still broken Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio sync drivers with current ABIManuel Stahl
Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio partial documentation updateManuel Stahl
Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio move scan_elements into ring bufferManuel Stahl
tested with sca3000, adis16400 Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio: lis3l02dq adjust lis3l02dq_configure_ringManuel Stahl
Now fits other driver's structure for easier modification. Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: iio rename ring attributesManuel Stahl
bps -> bytes_per_datum ring_enable -> enable Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: iio: signedness bugDan Carpenter
i2c_smbus_read_byte_data() returns an s32 type. We need to change "rate" to signed for the error handling to work. Also I changed it to propogate the error code instead of just returning -EINVAL. Other error codes could be -EAGAIN for example. Signed-off-by: Dan Carpenter <error27@gmail.com> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31drivers/staging/iio: call mutex_unlock in error handling codeJulia Lawall
Adjust the error handling code so that it benefits from the call to mutex_unlock at the end of the function. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @rcu exists@ position p1; expression E; @@ mutex_lock@p1(E); ... mutex_unlock(E); @exists@ position rcu.p1; expression E; @@ *mutex_lock@p1(E); ... when != mutex_unlock(E); ?*return ...; // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31Staging: vt6656: problems in error handlingDan Carpenter
The first kfree(pDevice) is pointless because pDevice is NULL. The second kfree(pDevice) is a double free because pDevice is the driver's private data and that is already freed by free_netdev(netdev). Also the free_netdev() error path doesn't call usb_put_dev(). Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: vt6656: resolved checkpatch findingLuis Bosch
Added spaces in for loop arguments. Signed-off-by: Luis Bosch <luis.bosch@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: vt6656: removed extra spacesVictor Rosales
Removed spaces between functions name and parenthesis. Signed-off-by: Victor Rosales <victorhrosales@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: vt6656: changed comments convention and removed spaces before tabAlejandro Emanuel Paredes
resolved checkpatch finding Signed-off-by: Alejandro Emanuel Paredes <aleparedes@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: vt6656: removed macro to test bitsAndres More
Removed custom macro used to test bits. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: vt6656: removed NDIS_STATUS int redefinitionAndres More
Removed int redefinition for function results. Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: vt6656: removed custom definitions of Ethernet packet typesAndres More
Removed some unused definitions of Ethernet packet types, also replaced two of them with in-kernel counterparts from include/linux/if_ether.h Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: tidspbridge: Remove services.c and services.hIvan Gomez Castellanos
The services_init() and services_exit() functions don't do anything, so they are removed, and as these are the only two functions defined in services.c and services.h, then these files are also removed. Signed-off-by: Ivan Gomez Castellanos <ivan.gomez@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: tidspbridge: Remove cfg.c and cfg.h filesIvan Gomez Castellanos
So far, the cfg.c file is empty, and the function prototypes in cfg.h are not used in any place. So they can be removed. Signed-off-by: Ivan Gomez Castellanos <ivan.gomez@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: tidspbridge: Remove cfg_set_object()Ivan Gomez Castellanos
As the services directory is going to be removed, the cfg_set_object function has also to be removed. Since the driver object handle is retrieved from the drv_data structure, then the word "Registry" is replaced by "driver data" in the comments. Signed-off-by: Ivan Gomez Castellanos <ivan.gomez@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-08-31staging: tidspbridge: Remove cfg_set_dev_object()Ivan Gomez Castellanos
As the services directory is going to be removed, the cfg_set_dev_object function has also to be removed. Signed-off-by: Ivan Gomez Castellanos <ivan.gomez@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 21:36:15 +0000