summaryrefslogtreecommitdiff
path: root/tools/testing/selftests/netfilter
diff options
context:
space:
mode:
authorFabian Frederick <fabf@skynet.be>2020-09-09 20:26:13 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2020-09-22 01:55:11 +0200
commit5b1a995bfa93667762badbe1d8f0f7ad680bdf29 (patch)
tree86ac64a722ec51d333e638c357b39110371128a8 /tools/testing/selftests/netfilter
parentf02ced62ec35e847ebadb1c6759320345c30fcb5 (diff)
selftests: netfilter: fix nft_meta.sh error reporting
When some test directly done with check_one_counter() fails, counter variable is undefined. This patch calls ip with cname which avoids errors like: FAIL: oskuidcounter, want "packets 2", got Error: syntax error, unexpected newline, expecting string list counter inet filter ^ Error is now correctly rendered: FAIL: oskuidcounter, want "packets 2", got table inet filter { counter oskuidcounter { packets 1 bytes 84 } } Signed-off-by: Fabian Frederick <fabf@skynet.be> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'tools/testing/selftests/netfilter')
-rwxr-xr-xtools/testing/selftests/netfilter/nft_meta.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/netfilter/nft_meta.sh b/tools/testing/selftests/netfilter/nft_meta.sh
index 17b2d6eaa204..1f5b46542c14 100755
--- a/tools/testing/selftests/netfilter/nft_meta.sh
+++ b/tools/testing/selftests/netfilter/nft_meta.sh
@@ -90,7 +90,7 @@ check_one_counter()
if [ $? -ne 0 ];then
echo "FAIL: $cname, want \"$want\", got"
ret=1
- ip netns exec "$ns0" nft list counter inet filter $counter
+ ip netns exec "$ns0" nft list counter inet filter $cname
fi
}