diff options
author | Tyler Hicks <tyhicks@linux.microsoft.com> | 2020-07-09 01:19:04 -0500 |
---|---|---|
committer | Mimi Zohar <zohar@linux.ibm.com> | 2020-07-16 21:53:55 -0400 |
commit | db2045f5892a9db7354442bf77f9b03b50ff9ee1 (patch) | |
tree | 071449c083f538a668b58ba87788dbe2139abd36 /security/yama/yama_lsm.c | |
parent | 712183437ebebc89cd086ef96cf9a521fd97fd09 (diff) |
ima: Fail rule parsing when the KEXEC_CMDLINE hook is combined with an invalid cond
The KEXEC_CMDLINE hook function only supports the pcr conditional. Make
this clear at policy load so that IMA policy authors don't assume that
other conditionals are supported.
Since KEXEC_CMDLINE's inception, ima_match_rules() has always returned
true on any loaded KEXEC_CMDLINE rule without any consideration for
other conditionals present in the rule. Make it clear that pcr is the
only supported KEXEC_CMDLINE conditional by returning an error during
policy load.
An example of why this is a problem can be explained with the following
rule:
dont_measure func=KEXEC_CMDLINE obj_type=foo_t
An IMA policy author would have assumed that rule is valid because the
parser accepted it but the result was that measurements for all
KEXEC_CMDLINE operations would be disabled.
Fixes: b0935123a183 ("IMA: Define a new hook to measure the kexec boot command line arguments")
Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Diffstat (limited to 'security/yama/yama_lsm.c')
0 files changed, 0 insertions, 0 deletions