diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-02-05 14:53:30 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-02-06 14:00:12 +0100 |
| commit | 7a02ea65027523386ab4ba4af0ab93497b3073df (patch) | |
| tree | b37ff5686ea87247c68728945fe03d13addb3ef4 /net/sched/cls_flow.c | |
| parent | 86b18aaa2b5b5bb48e609cd591b3d2d0fdbe0442 (diff) | |
net: sched: prevent a use after free
The bug is that we call kfree_skb(skb) and then pass "skb" to
qdisc_pkt_len(skb) on the next line, which is a use after free.
Also Cong Wang points out that it's better to delay the actual
frees until we drop the rtnl lock so we should use rtnl_kfree_skbs()
instead of kfree_skb().
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_flow.c')
0 files changed, 0 insertions, 0 deletions