diff options
| author | DENG Qingfang <dqfext@gmail.com> | 2021-03-01 01:08:23 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-01 13:09:55 -0800 |
| commit | 9eb8bc593a5eed167dac2029abef343854c5ba75 (patch) | |
| tree | 358d30687bd52b942e3f1da8ae9a6561367e4999 /net/ipv6/sit.c | |
| parent | 826d82170b539f16e1955ab940222543c012044e (diff) | |
net: dsa: tag_rtl4_a: fix egress tags
Commit 86dd9868b878 has several issues, but was accepted too soon
before anyone could take a look.
- Double free. dsa_slave_xmit() will free the skb if the xmit function
returns NULL, but the skb is already freed by eth_skb_pad(). Use
__skb_put_padto() to avoid that.
- Unnecessary allocation. It has been done by DSA core since commit
a3b0b6479700.
- A u16 pointer points to skb data. It should be __be16 for network
byte order.
- Typo in comments. "numer" -> "number".
Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/sit.c')
0 files changed, 0 insertions, 0 deletions