diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2010-10-29 22:54:45 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2010-11-01 10:26:23 +0100 |
| commit | bb617ee3f82ba94072c8b08043d9166bbfe397a2 (patch) | |
| tree | 2ad6d51e5d84fc765a3fd35b4e73f1fc37bd1def /include/net/ip_vs.h | |
| parent | 8a8d56b2a2f9aa423c3d8b6b1e2792c0492059ed (diff) | |
ALSA: cs46xx memory management fixes for cs46xx_dsp_spos_create()
When reading through sound/pci/cs46xx/dsp_spos.c I noticed a couple of
things in cs46xx_dsp_spos_create().
It seems to me that we don't always free the various memory buffers we
allocate and we also do some work (structure member assignment) early,
that is completely pointless if some of the memory allocations fail and
we end up just aborting the whole thing.
I don't have hardware to test, so the patch below is compile tested only,
but it makes the following changes:
- Make sure we always free all allocated memory on failures.
- Don't do pointless work assigning to structure members before we know
all memory allocations, that may abort progress, have completed
successfully.
- Remove some trailing whitespace.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Tested-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/net/ip_vs.h')
0 files changed, 0 insertions, 0 deletions