diff options
author | Michael Opdenacker <michael.opdenacker@free-electrons.com> | 2014-10-16 06:58:35 +0200 |
---|---|---|
committer | Brian Norris <computersforpeace@gmail.com> | 2014-10-22 01:35:41 -0700 |
commit | a0fa0b66ac1ce73ff791df977b07410a6f4cd337 (patch) | |
tree | b2c7d2753fc20293174b41e63082c2550a2083e3 /firmware/keyspan | |
parent | 59af5c7acde3d5cbbf8fadbc81a352a892cbc34c (diff) |
mtd: orion_nand: fix error code path in probe
This replaces kzalloc() and ioremap() calls by devm_ functions
in the probe() routine, which automatically release the corresponding
resources when probe() fails or when the device is removed.
This simplifies simplifies the error management code, and brings
the below improvements or changes:
A. Fixing a bug reported by "make coccicheck":
If "board = devm_kzalloc()" fails, the probe() function jumps
incorrectly to label "no_res" and therefore returns without
running iounmap().
B. Requesting the memory region
Using devm_ioremap_resource() makes the probe() function request
the corresponding memory region before running ioremap(), as
it is supposed to do.
C. Standardizing the error codes:
The use of devm_ioremap_resource() changes the return value:
* -ENOMEM instead of -EIO in case of ioremap() failure,
* -EINVAL instead of -ENODEV in case of platform_get_resource()
failure.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'firmware/keyspan')
0 files changed, 0 insertions, 0 deletions