diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2014-09-11 23:44:35 +0200 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2014-09-12 22:04:36 +0200 |
commit | 13c42c2f43b19aab3195f2d357db00d1e885eaa8 (patch) | |
tree | ede04f1e8fd3233259af8dd0b6ff92e9be7ee929 /drivers/watchdog/nv_tco.h | |
parent | 471cff7c42b56dbbd69003c25bbd97cf6776d464 (diff) |
futex: Unlock hb->lock in futex_wait_requeue_pi() error path
futex_wait_requeue_pi() calls futex_wait_setup(). If
futex_wait_setup() succeeds it returns with hb->lock held and
preemption disabled. Now the sanity check after this does:
if (match_futex(&q.key, &key2)) {
ret = -EINVAL;
goto out_put_keys;
}
which releases the keys but does not release hb->lock.
So we happily return to user space with hb->lock held and therefor
preemption disabled.
Unlock hb->lock before taking the exit route.
Reported-by: Dave "Trinity" Jones <davej@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Darren Hart <dvhart@linux.intel.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1409112318500.4178@nanos
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/watchdog/nv_tco.h')
0 files changed, 0 insertions, 0 deletions