diff options
| author | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2011-12-27 14:16:07 +0000 |
|---|---|---|
| committer | Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2012-01-03 16:00:04 +0000 |
| commit | fe05f8b1c3d28e6204a9ec54dec0d68af6cbf4c8 (patch) | |
| tree | 555461116bd970354ec7bc129dc832fcbef7ba2f /drivers/video/valkyriefb.c | |
| parent | 05342c0bdfd519873462e04ad81be07c9cd3c1e1 (diff) | |
video: s3c-fb: Make runtime PM functional again
The change in "video: s3c-fb: modify runtime pm functions" (commit
35784b) renders the runtime power management for the device completely
ineffectual as while it leaves runtime power management notionally
enabled a runtime power reference is held for the entire time the device
is registered meaning it will never actually do anything.
A further issue is introduced as runtime power management is added
during the system suspend path which is not something which drivers are
supposed to do and would interact poorly if there were any operations
done in the runtime power management callbacks.
While this does make things simpler (the main motivation for the
original change) it will not only cause us to use more power in the
framebuffer controller but will also prevent us entering lower power
domain and SoC wide states as we can never power down the domain
containing the device. Since neither of these things is desirable
revert the change.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'drivers/video/valkyriefb.c')
0 files changed, 0 insertions, 0 deletions