diff options
author | Devendra Naga <devendra.aaru@gmail.com> | 2012-06-09 00:52:11 +0530 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2012-06-12 13:35:32 +0200 |
commit | 3a86a5f8abb33956446ae31b1e9c149d7b2d1d21 (patch) | |
tree | e5a6c3a69c7b8e3e67b9d45fc2ee4aab9f47e790 /drivers/pci | |
parent | e85bbc19d5a9ad2b48bf8f2fd3277d6fe58f23ce (diff) |
pinctrl: pinctrl-imx: free allocated pinctrl_map structure only once and use kernel facilities for IMX_PMX_DUMP
a) as we allocate the pinctrl_map structure at imx_dt_node_to_map at line 167, anyway
if its an element, or a num_elements * (sizeof(type)) elements allocated to one single
pointer must be freed only once.
CASE. A)
as new_map is not moved and allocated like,
for (i = 0; i < MAX_ELEMS; i++) {
new_map[i] = kmalloc(numelems * size, GFP_KERNEL);
}
its freed as
for (i = 0; i < MAX_ELEMS; i++) {
kfree(new_map[i]);
}
CASE. B)
and its allocated like
new_map = kmalloc(numelems * size, GFP_KERNEL);
it just needs kfree not as case A's.
b) use KERN_DEBUG facility for the IMX_PMX_DUMP macro.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pci')
0 files changed, 0 insertions, 0 deletions