summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet
diff options
context:
space:
mode:
authorIdo Schimmel <idosch@nvidia.com>2021-03-14 14:19:37 +0200
committerDavid S. Miller <davem@davemloft.net>2021-03-14 15:00:44 -0700
commite1f78ecdfd59d560c42bc04b9bfb746ef8a9dfb1 (patch)
treee8f7027f75db867c46fd19a7b4723f645d99135e /drivers/net/ethernet
parent5ab6dc9fa2720cbbbdf2686c06a90c9a6c86b6fd (diff)
mlxsw: spectrum: Remove unnecessary RCU read-side critical section
Since commit 7d8e8f3433dc ("mlxsw: core: Increase scope of RCU read-side critical section"), all Rx handlers are called from an RCU read-side critical section. Remove the unnecessary rcu_read_lock() / rcu_read_unlock(). Signed-off-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet')
-rw-r--r--drivers/net/ethernet/mellanox/mlxsw/spectrum.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 3b15f8d728a3..3d8e8d8dfff5 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -2225,15 +2225,12 @@ void mlxsw_sp_sample_receive(struct mlxsw_sp *mlxsw_sp, struct sk_buff *skb,
goto out;
}
- rcu_read_lock();
sample = rcu_dereference(mlxsw_sp_port->sample);
if (!sample)
- goto out_unlock;
+ goto out;
md.trunc_size = sample->truncate ? sample->trunc_size : skb->len;
md.in_ifindex = mlxsw_sp_port->dev->ifindex;
psample_sample_packet(sample->psample_group, skb, sample->rate, &md);
-out_unlock:
- rcu_read_unlock();
out:
consume_skb(skb);
}